Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1256804rwb; Wed, 26 Jul 2023 09:42:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlFC7QnM19BZKN5rEwhBbtpzsyXT4pF3AASnuDJK0uNRDg2h3qaUPGI3sU5IiHtAAmHyoMzi X-Received: by 2002:a05:6a21:3613:b0:133:449c:677c with SMTP id yg19-20020a056a21361300b00133449c677cmr1827020pzb.58.1690389728974; Wed, 26 Jul 2023 09:42:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690389728; cv=none; d=google.com; s=arc-20160816; b=uDyy4gnHT1pLx+jj+ptJ8IUFOY5H7N7DgwMy+RqMG0CmdDx6b4wk9zc6Af5i+vxaHR /9QzEgoBRw5/BQdEz2DBQvMNjtUV3XFzcoY0kyHihFEx+rqKlQl/iRB1lhFj2AzXMZ0X 9hLO7LflHT4MT5Suw2RCVcs9yRJOgDu5iVzKZ/uPeR6t5k0d+DoRPylmcaotyxBJb6TE lkT/C+siBSaZSlacMwq+yeSzoy7C08ZbFniR72Mxto6hbKIyDsgUYaZVenmNHNqe7wQ5 XCyc+W81KASuLV40rDf1DfC7fkPGvkP59A0qx/wGDesAclLcn4pe3i6qMz20igKMJ1dP SEhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=fg3Sl4K/cT3xqS+J7LjsdHMVs7ad14fM17X++5JIUBU=; fh=SjoDTfOKXv2a1iOKZZHPenwhGHtN8KsqvIO0JvHwKCc=; b=PcG06lci6isQ5+byFZtNdqd1QH+rTJYMTowpDokPEKwMl5hO/0SjFY01EOYE8Qg8BF 9PTfYAM1l5lsz+SqHaZ4HM36htxDH2Yp3gR5DUCdyRMz3aUx++AlcwrE4SeK3ZLQCNnt i/d1RPh1Hjq/ihpuN8W8jWwSGPxmWvX7hxzs+CZelDWZ9+sNTCYvNIbzeN4CdqyW9cZ3 C18Pi2zT6Am0VRZ4K/S+P+LXl5bvw70smhiujtXtxgDTD5AWKMFFvM1LfIVdpe54YtkX L+h79+yFTiU3gkqQeepIFM+kJUNLFYviyqAzss0vJyFzXm8JFBlFy38o7KdJivntvE3e Bg8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQR7tIRD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k72-20020a636f4b000000b00563a0c1bf06si8321698pgc.428.2023.07.26.09.41.55; Wed, 26 Jul 2023 09:42:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQR7tIRD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234837AbjGZPu5 (ORCPT + 99 others); Wed, 26 Jul 2023 11:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234033AbjGZPuz (ORCPT ); Wed, 26 Jul 2023 11:50:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AC0E193; Wed, 26 Jul 2023 08:50:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9110961B96; Wed, 26 Jul 2023 15:50:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CA7AC433C7; Wed, 26 Jul 2023 15:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690386654; bh=qTUx1ibkNZiv2Ulvi2UjI9je+Gr+m7TlTSI0DAZX4MM=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=RQR7tIRDjvAkVF7nwmsvm+XRvECbXqIyhem6BswxnB5RnNw2M369NR83PIWcg4n0i 7b0RZKPr2GvGuR6uE4koLC+tOeaOyuikWjIB7eG40tMtMTpglL/VW6wMq5wlEn4Jep X9GTyhBJK4B2P5m5dc6yDV/z+yZ1RrQ5/JK5qdcsqu11Eh6gHBG307Mlv/35Mku4hb 6txkqSh/1L8CkTwU9rHQzUXjyULY+qGd9PtogVdVZVNpQuqZaH/sHX2d5RqJ2bLQ/0 +iqkakXsRXhbDH70G4/avVkkPs/X9MEhbJbAc7EGxm0EqxXezV1uhey/z/rzqVeGpv Z75dmtAjeVpRA== From: Mark Brown To: Douglas Anderson Cc: Vijaya Krishna Nivarthi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org In-Reply-To: <20230725110226.1.Ia2f980fc7cd0b831e633391f0bb1272914d8f381@changeid> References: <20230725110226.1.Ia2f980fc7cd0b831e633391f0bb1272914d8f381@changeid> Subject: Re: [PATCH 1/2] spi: spi-qcom-qspi: Fallback to PIO for xfers that aren't multiples of 4 bytes Message-Id: <169038665208.73112.11925690374692993446.b4-ty@kernel.org> Date: Wed, 26 Jul 2023 16:50:52 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-099c9 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jul 2023 11:02:26 -0700, Douglas Anderson wrote: > The Qualcomm QSPI driver appears to require that any reads using DMA > are a mutliple of 4 bytes. If this isn't true then the controller will > clobber any extra bytes in memory following the last word. Let's > detect this and falback to PIO. > > This fixes problems reported by slub_debug=FZPUA, which would complain > about "kmalloc Redzone overwritten". One such instance said: > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/2] spi: spi-qcom-qspi: Fallback to PIO for xfers that aren't multiples of 4 bytes commit: 138d73b627c71bf2b2f61502dc6c1137b9656434 [2/2] spi: spi-qcom-qspi: Add mem_ops to avoid PIO for badly sized reads commit: cc71c42b3dc1085d3e72dfa5603e827b9eb59da1 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark