Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 14:04:54 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     kevin.tian@intel.com, alex.williamson@redhat.com,
        yi.l.liu@intel.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, shuah@kernel.org,
        linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
        kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
        mjrosato@linux.ibm.com, farman@linux.ibm.com
Subject: Re: [PATCH v8 4/4] vfio: Support IO page table replacement
Message-ID: <ZMFSNgZgGVV4LXDC@nvidia.com>
References: <cover.1690226015.git.nicolinc@nvidia.com>
 <182b79f3838f84f220ede6089a0326b6f3f44acf.1690226015.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <182b79f3838f84f220ede6089a0326b6f3f44acf.1690226015.git.nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rOt0tT8ze3Xyfn3SXYU8bjnNgtTUtFzgbBVRg3yKyK2HZxgL0XVmjw0/Y4l/?=
 =?us-ascii?Q?EFg7OI9xBTfyIf06Lfw6bFPURdY/ZAe6t0maLrQIRlTMlHFNOL1veVA7nHx3?=
 =?us-ascii?Q?IC7jl4QAvoIkpWGkckL36cCOBHpuiZKNJtkpSjFy8khYOcH10NrgCeFahJQ/?=
 =?us-ascii?Q?UHiqf/sxzkOBLEHEkXbZ5SMhDC16WDGylnYrC1Vkonb00qG/mod70Aw9bXd6?=
 =?us-ascii?Q?c+j3MoIXk6heR4m53qkdrMLhm55avjYlP4FilM/Ec+Txnb5E1IO5ODsAJ5wL?=
 =?us-ascii?Q?2Uiiu1YlIu/7rLK+GqGI+NRBVYNgEkhFdKAR0n2oGdedGvSEloxjFmzWeCcu?=
 =?us-ascii?Q?aZYahjYY8r01IJJPlKjHXb94KWOmZmd//P3seyvXTsxpwgvZD2JYTT5Hoqc2?=
 =?us-ascii?Q?OthCdUZs9yRfza/U9jgcJyzdhaOZNmjxnYY5OOCnOx9aBYNEZoiNDfufSQD+?=
 =?us-ascii?Q?DVXLapeYidWk8yNDxu0p0W2KRyw3912pC+N2szvGPPUEMz1qIBdtRf1lb/jW?=
 =?us-ascii?Q?N3u4T7JwHJmzC/fpGA+CoTHtsgmRGsJD9fQy7ZQdhDbQb6XMHi2LAAvznhaw?=
 =?us-ascii?Q?Lu8c7QczSHP5H94U2Upgv7xwwnzk1lMRcp+IeW0+nBIg0fx+x51iFHdd1jk+?=
 =?us-ascii?Q?74M7LX42ow83YrGRCDyb9qefKuXFckFzdAksG40M9aSZZZeCjc8Vv9I7mIEp?=
 =?us-ascii?Q?3vTJ8oqstRNSuOQl+dduyWVgf7uSOaEr18yn7keOVefj0NklKVLwZYdF2+Is?=
 =?us-ascii?Q?Tql3+QvoAfzwapIwVN7wbuOKhj9NDougXR7n79J4Zc3tKa4CZOzMeaVbLaGH?=
 =?us-ascii?Q?qNKzMuK1IkVjdT1XEwSOiptOiCia63uVFWbI4usJ5YRa/C65gpzbMGK66KqG?=
 =?us-ascii?Q?xr+XFYGNhLfaxdx2CkMJr+NsZuE4KPbquRlGnYVagpyTGT7ctRaxD47ZRVzS?=
 =?us-ascii?Q?rYVEpBajNJ6Ic8G3UmZ1b1OUIiDXFuMY8HGZlrKVKgCAvMy3/omkisCRKcbu?=
 =?us-ascii?Q?QnPPt7vYNYPtbHhLh0aczRChD63v/5gpD+latl9JLzl4lGkpGnLR3j6joW8e?=
 =?us-ascii?Q?B5S/1DtjNVkHg+muFum+fdH7WRN+u4eTdtMHnQEl5IK7s4cxOFL7JlZBPIjV?=
 =?us-ascii?Q?dthvF3kpAXsypHNQDfiVYaaP9CJJI6kZFoS8+3zcsJQeGnpgWUXNCrFokBvA?=
 =?us-ascii?Q?PqNbNHc0NTaKhcpSShO+vG09Lg7NAiX8kLd5wkwCYFXQBLxiZ1zudPtip3rz?=
 =?us-ascii?Q?ZOuh8z0ZPL0QPDExBY5EEJ3/wkfNqZSD415Xj8/Vbc9W4OdlLs5OXI+ygsAx?=
 =?us-ascii?Q?92+UZmH4l5JP75llk49bBHlk5MSHuHd1YiIr28Ywc91TBTo7phXN0Ln9tnbN?=
 =?us-ascii?Q?OgVpZQt7Q20GxAGw1zlQr/qI5QDw8ULE7n7N5y9E2oZx+2YQS9x//0KgvXjl?=
 =?us-ascii?Q?2DQL5dCTe/Tt9DrELHQHV94lwg04L7xm0emBkaryQzDLaDH43NS+hMdEeS8s?=
 =?us-ascii?Q?OnwVBs0q+6bj8Lul+osxZ5Y0JMrCvzFBm7I4E4tyogF8Kv2YCBqruSTp5nYe?=
 =?us-ascii?Q?1/n/tQ+owTpP+pNvHEvi5Q9cNidJdTOM6OVM5y3/?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e58e757b-627b-4fe9-aa0d-08db8dfa6f42
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 17:04:55.2432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ae/0RwLHBJjJHiffRzirBiGQ6RraNXgLlCzClUocZN/z7hhy7Ok8/DZJhCD64RsB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5060
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 24, 2023 at 12:47:07PM -0700, Nicolin Chen wrote:
> Now both the physical path and the emulated path should support an IO page
> table replacement. Call iommufd_device_replace/iommufd_access_replace(),
> when vdev->iommufd_attached is true.
> 
> Also update the VFIO_DEVICE_ATTACH_IOMMUFD_PT kdoc in the uAPI header.
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/vfio/iommufd.c    | 11 ++++++-----
>  include/uapi/linux/vfio.h |  6 ++++++
>  2 files changed, 12 insertions(+), 5 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason