Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b
Mime-Version: 1.0
Message-Id: <034f0b5e-3c61-4392-8360-ebd57749d53e@app.fastmail.com>
In-Reply-To: <CAKwvOdnk+e_QmE+QpcqzntNVgf8mL+NOPtUggj4F__iTf_XD+A@mail.gmail.com>
References: <20230726143348.724611-1-arnd@kernel.org>
 <CAKwvOdnk+e_QmE+QpcqzntNVgf8mL+NOPtUggj4F__iTf_XD+A@mail.gmail.com>
Date:   Wed, 26 Jul 2023 19:02:55 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Nick Desaulniers" <ndesaulniers@google.com>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "Paul E. McKenney" <paulmck@kernel.org>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Kees Cook" <keescook@chromium.org>,
        "Peter Zijlstra" <peterz@infradead.org>,
        "Sami Tolvanen" <samitolvanen@google.com>,
        "Alexey Dobriyan" <adobriyan@gmail.com>,
        "Masahiro Yamada" <masahiroy@kernel.org>,
        "Josh Poimboeuf" <jpoimboe@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: keep boot_command_line after init
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 26, 2023, at 18:25, Nick Desaulniers wrote:
> On Wed, Jul 26, 2023 at 7:33=E2=80=AFAM Arnd Bergmann <arnd@kernel.org=
> wrote:
>>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The boot command line is not available after the init section gets di=
scarded,
>> so adding a permanent reference to it causes a link time warning:
>>
>> WARNING: modpost: vmlinux: section mismatch in reference: cmdline_loa=
d_proc_show+0x2 (section: .text) -> boot_command_line (section: .init.da=
ta)
>
> cmdline_load_proc_show is probably inlined, but should it also be
> marked __init?  It's lone call site seems to be __init AFAICT.
>

No, that's not what it does: cmdline_load_proc_show() is called
when someone reads /proc/cmdline_load from userspace. It's only
the function that creates this procfs file that is __init, but the
call happens later.

      Arnd