Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20230717170552.466914-1-gratian.crisan@ni.com>
 <5fdc06b2-22bc-1470-e60c-1e388774ee4b@redhat.com>
User-agent: mu4e 1.8.14; emacs 28.2
From:   Gratian Crisan <gratian.crisan@ni.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
        felipe.balbi@linux.intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, gratian@gmail.com
Subject: Re: [PATCH] usb: dwc3: pci: skip BYT GPIO lookup table for
 hardwired phy
Date:   Wed, 26 Jul 2023 14:00:21 -0500
In-reply-to: <5fdc06b2-22bc-1470-e60c-1e388774ee4b@redhat.com>
Message-ID: <875y66h4v2.fsf@ni.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9XAvoHzjJlQ14T7KrJ+zj+T0M/Mo5pJTSqaZmJ6sNBf5XTYEFFWJNyqpbPnl?=
 =?us-ascii?Q?7TERtDmZ29z5mt6YBL3VTj5qHXdy5HcRTFYOxhIgifhAVOx9Xjwci38R4f/2?=
 =?us-ascii?Q?E171VbcN0GXQhWpr7i4vh2bHzBbKOPGDvmgqOKgt0ZTwkaznVzNaIehlEzFd?=
 =?us-ascii?Q?Xj5ZOhQi0D6HPljyk2J9/3vR990jrUyHLgAWUNqtBnaBjNSr56PgN1LuAXc6?=
 =?us-ascii?Q?DJwbx6xBx7Pu5QUmPzfhBO/mGSiuOh/iDOjplqwuFScWI+wDilrOukz+MLeU?=
 =?us-ascii?Q?D3IEPtSgcdW3NTtZfLLwC9v8a5wk/uKhP6NuaCAxVZxg5SZL8mZ6ZIgCKf/4?=
 =?us-ascii?Q?cJbpXhZ2RDbsMs5KW48RnuTUyl6ig8/7WGQeCSDUX1eDAthaBzTnbTe1YQZQ?=
 =?us-ascii?Q?1KL1IoTFEAupgnCL3W7ze8fFuFzpIJ/u97p/wYP6PdDljFb0a9Ph2OkBnJfl?=
 =?us-ascii?Q?KJ/EIAZNw8Tbrvu2Bo9CGNbO+0JR80UufvREmd/3NwdVXRPVw26dgPOHW9sQ?=
 =?us-ascii?Q?QdCGFz3kwMFnkyuExIMX+g6Gyd8kHvckqWom5bMyAiTa2ZsqceoLG10DFKHL?=
 =?us-ascii?Q?5pEZuXCUTjg033e1FLMnHHgS9O1nec5oHOuQ4aiZwGl+dWbxYdmalb18Abpf?=
 =?us-ascii?Q?yqorE+kGWAWQMD2kp/kd+fmMfhBgqUaMPaHRNPHy4oHsTmDoNX0WnQ7Et9uR?=
 =?us-ascii?Q?eztmqDpMMXU7xbqczE+YMjImaQhGVVdLgY7Io+A5imS11OtozbWPYHdPZPqc?=
 =?us-ascii?Q?Q5ZjYcoqhjsZfuPhn6RfBLGbAz0YwJmn02IWQDxVQuekVHUo3hJiBkjf1TBq?=
 =?us-ascii?Q?lwhUubXK1JXMRE3fZ7XiCgD6hTDc/LCH/E1p4CphePh1wPYZZwi/mSuBjiL5?=
 =?us-ascii?Q?hJQeLpnZnVqJm4LemXtECJWr/rcakT1NGTo5DRcRpVAMbvzbhbNzI0ksG0yL?=
 =?us-ascii?Q?9B6zvS9yGBDxF2uEhzZu39zIgEJZ5/db5W36WyezScJBcmLUwJcaZs3HjG0o?=
 =?us-ascii?Q?tme4b57tMA6/wbIEjaFVdJ/6vkco7zrht+tSxcGA8EqAvDWzcw6xaUmb/j4j?=
 =?us-ascii?Q?adqOUDigXGZ8l9wEu+uwgxYwPDW1r3eUZFKb5oIiiGVMSTtgyeMLURSMJDSg?=
 =?us-ascii?Q?pLobmfjmoXDd2Z8Imte8lLg4n5e4fJKXRZn1+VT0TxmkvooNWBNwLYkm9YZ0?=
 =?us-ascii?Q?CuAKWnVrlqC9woRP8s068OCT+U6MuLwYpzLRCFKYyriqQYVYyFJiXhdcJjra?=
 =?us-ascii?Q?ap1KkT0MeEB4nHY14A36RmOjWi2EYH+WSvCZ/jBBOrah0empE5kGeX1WB0MH?=
 =?us-ascii?Q?fOgKhcg2z8RwwC4PNO8j7MliFfTwAV4mzGvFxw71pukObUWo4fcTMj2UNFaV?=
 =?us-ascii?Q?s1Igl9n2R5eZ+vFoJjkcKgE2jxniWAcfTVuylXcgceAHMnLLF4CkRT6vqIbp?=
 =?us-ascii?Q?6WYytbu2gQibR2ckSyAMZ0nLYWbBnWJxRzu0XzKRbiEjfCC+Oedv5v3DhRed?=
 =?us-ascii?Q?IGjizh6lAmMTTfl3nwy4jCvmhTf9xKLt7jfMsFDUf846cYb1qpLBMQBbs/ez?=
 =?us-ascii?Q?CSaVX6mS9fHlkEAO8xhlfc4/rjVr2vGTjliojx3E?=
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10c9d9b5-4b8f-48a3-f7ca-08db8e0b13ed
X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB4496.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 19:04:03.5065
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n5mZqsaUsI34UvuAWELAYs5waF2kk2PSNi3olo+JJRyE94RX7L3h56A/RHRSgQvRNBjPkXMeDI0IjfZsmwqHaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7762
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hans de Goede <hdegoede@redhat.com> writes:

> Thanks this change looks good to me.
>
>> @@ -247,8 +249,10 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc,
>>  			if (IS_ERR(gpio))
>>  				return PTR_ERR(gpio);
>>  
>> -			gpiod_set_value_cansleep(gpio, 1);
>> -			gpiod_put(gpio);
>> +			if (gpio) {
>> +				gpiod_set_value_cansleep(gpio, 1);
>> +				gpiod_put(gpio);
>> +			}
>>  
>>  			gpio = gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);
>>  			if (IS_ERR(gpio))
>
> But this is not necessary both gpiod_set_value_cansleep() and gpiod_put() handle being called with NULL gracefully (so they handle NULL returned by gpiod_get_optional() without issues) .
>
> Can you please post a version 2 of this patch dropping this unnecessary change?

V2 posted: https://lore.kernel.org/linux-usb/20230726184555.218091-2-gratian.crisan@ni.com/

Thanks,
    Gratian