Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 26 Jul 2023 16:22:51 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Anup Sharma <anupnewsmail@gmail.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Adding Support for Firefox's Gecko Profile Format
Message-ID: <ZMFyi5S4JlFeZ/9c@kernel.org>
References: <CAP-5=fU7ukrQSh_8OwH9C+a-EwCamCrMaZxjqDhE9f+bFJwQBQ@mail.gmail.com>
 <ZIHPXV5/ZopqcSSc@yoga>
 <ZIofrGKElc3nkNk0@yoga>
 <CAP-5=fV9tXNpYHH9DW0cVbRoFLGvG9SNn-MUhuyKuVBRuDqjoA@mail.gmail.com>
 <ZJyT8bt0LFLw6hKV@yoga>
 <CAM9d7ch7TdagV+dzj6MCp4fY15Vc4oGJjKAoQDyc=BXqy7qi+A@mail.gmail.com>
 <287bf3c8-fa0e-8c36-df14-7d728c63c265@intel.com>
 <ZKQu00bJZwO+Fc6m@yoga>
 <ZKRcTqAsKxF/Q3fQ@yoga>
 <ZMFgIekihhoGFBpn@yoga>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZMFgIekihhoGFBpn@yoga>
Precedence: bulk

Em Wed, Jul 26, 2023 at 11:34:17PM +0530, Anup Sharma escreveu:
> Dear all,
> 
> I want to share a recent development in our project that
> I have been working on this week. I have successfully
> implemented a new feature that allows users to directly
> open the browser and visualize the output of perf.data
> on Firefox Profiler.

Excellent news!
 
> To enhance user experience, I have made sure this option
> is enabled by default. Additionally, I've also added a
> handy command line argument, "--save-only," which allows
> users to save the output file as needed. This enhancement
> replaces the previous standard output method, providing a
> much-improved experience.
> 
> Moreover, Everything is processed locally, and no data is
> sent to any server.

That addresses the worry about sending possibly sensitive data over the
network by default, great.
 
> During this implementation, I had the opportunity to delve
> into several exciting topics, including threading, HTTP server,
> and CORS mechanisms. The learning process has been both
> challenging and rewarding.

Cool that you're so excited learning all this.
 
> Currently, I am in the process of performing some clean-up tasks.
> Once that is complete, I will be sharing the next version of the
> series, which includes this fantastic new feature, with all of
> you very soon.
> 
> Thank you for your ongoing support and encouragement.

Keep it up!

- Arnaldo

> Thanks,
> Anup
> 
> > > Regards,
> > > Anup
> > > > > 
> > > > >>
> > > > >> The second challenge revolved around the usage of event hooks provided with the perf script
> > > > >> python event handlers. I found myself deliberating between two approaches. The first
> > > > >> approach involved creating custom functions that would be called using the event
> > > > >> handlers. These functions would then save the data in an organized format within
> > > > >> globally created data structures. The alternative approach was to write the entire
> > > > >> logic inside the event handlers themselves.
> > > > >>
> > > > >> Additionally, I contemplated whether it would be more suitable to handle the creation of
> > > > >> a Gecko format for JSON and the profile format within the same script or to separate
> > > > >> them into different scripts.
> > > > >>
> > > > >> I will discuss this points during tomorrow's office hour.
> > > > >>
> > > > >> However, I have gained a deeper understanding of the problem at hand and will use this
> > > > >> knowledge to make more informed decisions and progress more effectively in the coming weeks.
> > > > > 
> > > > > Sounds like you did a good amount of research on how perf script
> > > > > works.  We can talk about the details in the meeting.
> > > > > 
> > > > > Thanks,
> > > > > Namhyung
> > > > 

-- 

- Arnaldo