Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     "shuah@kernel.org" <shuah@kernel.org>,
        "mhiramat@kernel.org" <mhiramat@kernel.org>,
        Ching-lin Yu <chinglinyu@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-trace-kernel@vger.kernel.org" 
        <linux-trace-kernel@vger.kernel.org>,
        "lkp@intel.com" <lkp@intel.com>, Nadav Amit <namit@vmware.com>,
        "oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>,
        Alexey Makhalov <amakhalov@vmware.com>,
        "er.ajay.kaher@gmail.com" <er.ajay.kaher@gmail.com>,
        "srivatsa@csail.mit.edu" <srivatsa@csail.mit.edu>,
        Tapas Kundu <tkundu@vmware.com>,
        Vasavi Sirnapalli <vsirnapalli@vmware.com>
Subject: Re: [PATCH v5 02/10] eventfs: Implement tracefs_inode_cache
Thread-Topic: [PATCH v5 02/10] eventfs: Implement tracefs_inode_cache
Thread-Index: AQHZvNQKHw/Q6Fj22kO7XI2K5rFska/LH5OAgAFJcQA=
Date:   Wed, 26 Jul 2023 18:45:34 +0000
Message-ID: <0FE7065F-6536-4311-AF41-4ABBD8E3ECF8@vmware.com>
References: <1690054625-31939-1-git-send-email-akaher@vmware.com>
 <1690054625-31939-3-git-send-email-akaher@vmware.com>
 <20230725190617.14c85997@rorschach.local.home>
In-Reply-To: <20230725190617.14c85997@rorschach.local.home>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tzCl7LcGI2W1oTq/aE4j33F1oTcqL934eqvVC/Q2+gWexVG8YfAio7R2N00I?=
 =?us-ascii?Q?0TOLyuRnRltOc8VWrVxXEfjjj3Wg6wubYUCCncp22Oom9MlrxFHxTbkWX2vo?=
 =?us-ascii?Q?d+VREnlSCNVll7ABUBBr4AJvphPn+zSBP6ESgoJwEVG1AFexE6iB5yufXdCt?=
 =?us-ascii?Q?S/oOYfc+LlZfh4UsnwiyH/ISl4Y4AehkjO19/2uyeNnhzHxQqBnmjmZ0TZq/?=
 =?us-ascii?Q?nn45VvEoIQqTWF3OZE0X3QGnI4vgnB5wESlSEwNLoZPEctfuIogGmr+CUO83?=
 =?us-ascii?Q?T962XJ8qE62Pa9h7NZyTGGvEzkTvTofo3hZdEaYnQ7LOg6dbwV530c/nWj8K?=
 =?us-ascii?Q?bF3pEFWaTTrVEIpm+nvL5XIXcc/OBKY5M8MPiwyqxZ4AkNaug1Dnad9dak10?=
 =?us-ascii?Q?qZ6j4CLHxDz8veV4T+nkpJr238IwrKjAI/zKwaCL95PwwlZNVBnHV4sG162q?=
 =?us-ascii?Q?bQsGMMoSJ5ZJZmFCAV4Lu4Yx7CpPfAe7OcaYdpEUaK4B7ewm6ifswqOlhvVT?=
 =?us-ascii?Q?YTaKloSU0IRDRQD91ap9O3jwY5c+toT1u+LZ4f7d/zK8h/7uxOEpmNMYpcm2?=
 =?us-ascii?Q?REqYB0Mp1pSkhJcFOnK+D9vtoPmJ8Luzh/lwVlDPoizbkPirrl8dcbPDSWVY?=
 =?us-ascii?Q?GIKUkrXycVtxkP+scyvtHl1M/urS7mP0MMP8AuIeLxDCDGTNYZwbDH0ewf1b?=
 =?us-ascii?Q?f6JzrKoXaatSowxNjeKva/gqkv1nafmoPvBnVsiKITsfQxt6gVWy3M6SyyG/?=
 =?us-ascii?Q?2RJQt3ehwqW1eiqOuXwe1xxxDpHyCThfJdSwX3Hp6gmdc9zfa5CQGMVvXtBS?=
 =?us-ascii?Q?cGHM1/R9h/GuQ6yT6t0Aw6MFhwaUx26YjWrg6IIrXLhPXFuCrGwbm+745Dow?=
 =?us-ascii?Q?wUo6S3Ua97p4FkWjCdx57rppqer9HtjJHsWCBfo3Jvn1tOHvD8DW8i39aeK9?=
 =?us-ascii?Q?+lywnDk5ueAUow0w69ojnVUAx3+8ADnH3oaare6nqf8snrYdxjb2g9TYyK6T?=
 =?us-ascii?Q?6NTKuW9tNncvr2Eefq/fBmlhp6iCwo5XR2ghjr2ik2mYOyHhknRJ2ryuI/07?=
 =?us-ascii?Q?6tZfWQhmPU0q/98bcK83WKF2owQH3jAa3l9Y4KSV1ORwTjtkQL5sLm8ROG8Y?=
 =?us-ascii?Q?42K2Chp9R4VzKZw96/Lz1tgVm8xP1DDJMXMJqVoTV45Oz6QZ0CHmtGpQVWzo?=
 =?us-ascii?Q?ULkPpfTSywyyEr0+0fVdHmSz3qoruUWH/jTZjMEXaEtO3On/vuPfihK6B6w1?=
 =?us-ascii?Q?VMzxpRrdKN6O9Q/JjCkCTqPrKux5MEvGVaojPkIxucYtCKTOftwqIJIWgJzf?=
 =?us-ascii?Q?voDkMey0YQwGupQZpqB/xZiaWsTjrttTr5tk8FAAovVWCNB/DvjqPPYxvZ8L?=
 =?us-ascii?Q?xRLkFAxQmMnoE9dZZHcr8oUGjlLQ/YVY1dsgXoWUVbytoUQU3uchC4YOyYiR?=
 =?us-ascii?Q?g3pwXkoSOdU1O8LoUF7vUQXKp++SPIqW0W4j4NfAEoE0Xvp7vY+WLjpNYK/7?=
 =?us-ascii?Q?zB0fPywVYRz9OhvfwF5LGqlY0XsWnI8sposaxdT4HYhzrry3yh5DYMMhsXks?=
 =?us-ascii?Q?etMvwlgeZ8Si7fUzOubzauJrMBVyaKYki33bAOD1?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D439C1FB6769CE48B24CD7F9CE9BB7E1@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5c1c82b-beb4-46f6-2c1a-08db8e087f39
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 18:45:34.8231
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wr+tm+0wYKcIoMrgyVbQuVDIAOInGA+JPemCltCmqIjSWN3m2PgRjSmPdW+2WoCpa7bMgy/sHP7//m4UCes7ig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR05MB7428
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
>> index 57ac8aa4a724..2508944cc4d8 100644
>> --- a/fs/tracefs/inode.c
>> +++ b/fs/tracefs/inode.c
>> @@ -21,13 +21,33 @@
>> #include <linux/parser.h>
>> #include <linux/magic.h>
>> #include <linux/slab.h>
>> +#include "internal.h"
>>=20
>> #define TRACEFS_DEFAULT_MODE 0700
>> +static struct kmem_cache *tracefs_inode_cachep __ro_after_init;
>>=20
>> static struct vfsmount *tracefs_mount;
>> static int tracefs_mount_count;
>> static bool tracefs_registered;
>>=20
>> +static struct inode *tracefs_alloc_inode(struct super_block *sb)
>> +{
>> +     struct tracefs_inode *ti;
>> +
>> +     ti =3D kmem_cache_alloc(tracefs_inode_cachep, GFP_KERNEL);
>> +     if (!ti)
>> +             return NULL;
>> +
>> +     ti->flags =3D 0;
>> +
>> +     return &ti->vfs_inode;
>> +}
>> +
>> +static void tracefs_free_inode(struct inode *inode)
>> +{
>> +     kmem_cache_free(tracefs_inode_cachep, get_tracefs(inode));
>> +}
>> +
>> static ssize_t default_read_file(struct file *file, char __user *buf,
>>                               size_t count, loff_t *ppos)
>> {
>> @@ -346,6 +366,9 @@ static int tracefs_show_options(struct seq_file *m, =
struct dentry *root)
>> }
>>=20
>> static const struct super_operations tracefs_super_operations =3D {
>> +     .alloc_inode    =3D tracefs_alloc_inode,
>> +     .free_inode     =3D tracefs_free_inode,
>> +     .drop_inode     =3D generic_delete_inode,
>>      .statfs         =3D simple_statfs,
>>      .remount_fs     =3D tracefs_remount,
>>      .show_options   =3D tracefs_show_options,
>> @@ -628,10 +651,26 @@ bool tracefs_initialized(void)
>>      return tracefs_registered;
>> }
>>=20
>> +static void init_once(void *foo)
>> +{
>> +     struct tracefs_inode *ti =3D (struct tracefs_inode *) foo;
>> +
>> +     inode_init_once(&ti->vfs_inode);
>> +}
>> +
>> static int __init tracefs_init(void)
>> {
>>      int retval;
>>=20
>> +     tracefs_inode_cachep =3D kmem_cache_create("tracefs_inode_cache",
>> +                                              sizeof(struct tracefs_ino=
de),
>> +                                              0, (SLAB_RECLAIM_ACCOUNT|
>> +                                                  SLAB_MEM_SPREAD|
>> +                                                  SLAB_ACCOUNT),
>> +                                              init_once);
>> +     if (!tracefs_inode_cachep)
>> +             return -ENOMEM;
>> +
>>      retval =3D sysfs_create_mount_point(kernel_kobj, "tracing");
>>      if (retval)
>>              return -EINVAL;
>> diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
>> new file mode 100644
>> index 000000000000..49b5e8949e1c
>> --- /dev/null
>> +++ b/fs/tracefs/internal.h
>> @@ -0,0 +1,19 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +#ifndef _TRACEFS_INTERNAL_H
>> +#define _TRACEFS_INTERNAL_H
>> +
>> +enum {
>> +     TRACEFS_EVENT_INODE     =3D BIT(1),
>> +};
>=20
> Let's not introduce the enum until it is used.


Ok, I will move this to v6 04/10.
Let me know once you will complete the review of v5.

-Ajay