Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1497932rwb; Wed, 26 Jul 2023 13:31:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlFZHF5Ccq5uhaTCXffhShF6FTkqF/KcalI3eUQBMAJjOj7jj0uJJ4T6kVXJoQz3OTEH84Pu X-Received: by 2002:a05:6a20:3d89:b0:136:e26b:6401 with SMTP id s9-20020a056a203d8900b00136e26b6401mr3948266pzi.16.1690403494350; Wed, 26 Jul 2023 13:31:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690403494; cv=none; d=google.com; s=arc-20160816; b=CIVGkrN5yab8XVb2czrY4cr0w2UsLcOd2/n4h1gipb+rGF9BnNLWNGZ5o9zJGloxHp i4B+5Ra9lkDIkpghXL44d0G321MrOet7QIqEnahM/c/G//thgEzQqMlSFjnt/+8RKROh fXwkvM/kE7Zdjd8hxtJ36fbcIb84AuHkIiz7dYzDt4a7+gUORCMMgt0InSZ0XJ13ecuC f5J6SCCGz5XvSKcm2M3mIoAh8B1itAqide2+s2dTcFieQzOrwVsEIBVnlLA4zgCEA8xy oMFmZHnxYpe+FYtZJKWs+k8owEYBYOapepGVex4ZVW47JCKDQkczSBRE9P+wqnfu0L/l EgOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=CT/Wqurjfb8oNcirx3GnfFJTTZVmhBDsd7W79f7cnKk=; fh=xPmNu/zb4TJmzSCohQ7keUNq+Pr9uTZvqCyxPJaP82o=; b=eeouDvEerRhBGq9tr3nquy17/8UiSUW5cJ3syC/Fg18ISF8pa1OXPKZoXC6BBAQ0Ey ChrAPurzrsY1ZcbKfzdF+2sdtwIdp0fUmY77oGUwYmLq/JqYnv9euQ0bqM78kn93peTs 2hFhybmxig1TUZMqwFsjaniuVR8PWCR5I/A1gBiRdyctpG9mmlf1aJd/CPtiQ+3Kxiy9 RVcKqdLWBKqSHkfq5L/L74yyGMG44vdu7PlIYc2ReqPnNsMXFZhAy8n90wL1SHFX9Du1 p+LAA7D4QkWgDaqhJ9twi9wrCdDj1N3HNpKMXw98TRl3Kkk35X+efELQjVZL9c5I2fKC vp4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TSpMUIur; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m1-20020a656a01000000b00548e140a1a4si14510456pgu.644.2023.07.26.13.31.20; Wed, 26 Jul 2023 13:31:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TSpMUIur; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbjGZUIY (ORCPT + 99 others); Wed, 26 Jul 2023 16:08:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjGZUIX (ORCPT ); Wed, 26 Jul 2023 16:08:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993652706; Wed, 26 Jul 2023 13:08:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FFE761C63; Wed, 26 Jul 2023 20:08:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0861C433C7; Wed, 26 Jul 2023 20:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690402101; bh=tkm5m6riRK6JiPDBJ3xtHiTEA7gBu5th4OS3XdarM5c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TSpMUIurbr1bdPa/0B6DOsiuTbVYbYdn1w3Y7xsqo/U8GbwvNsc+J4PEbd+BSWgDg DfIrSvjcMk6VubAyi5DhS3kIVk1nU/Re2CFRBWg4ziggvxwJAHngCA9FozCAef+xCe 8VeOB00p7A3EdAdVg8o3k6pTY+Y6zKOkQyFMykrCcZkz4jbdWQjwa3FAlWRdpCvOzR vhJ4gkmZ1/ILwHRkxBH9i+ENvEDsISTlBVGM0+iSpMkRzVyYuewU+GapzRblvcE79/ le+jGJbme2f1E5tR6UmraYRRWhqLC/ZkZi+LF0UnsNew5Ryjz9Eq3FKcLq9Jmcj0Ou tkfw6LwxZKPNg== Date: Wed, 26 Jul 2023 13:08:19 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: David Howells , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() Message-ID: <20230726130819.6cc6aa0c@kernel.org> In-Reply-To: References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> <776549.1687167344@warthog.procyon.org.uk> <7337a904-231d-201d-397a-7bbe7cae929f@gmail.com> <20230630102143.7deffc30@kernel.org> <20230705091914.5bee12f8@kernel.org> <20230725173036.442ba8ba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jul 2023 22:20:42 +0300 Tariq Toukan wrote: > > There is a small bug in this commit, we should always set SPLICE. > > But I don't see how that'd cause the warning you're seeing. > > Does your build have CONFIG_DEBUG_VM enabled? > > No. > > # CONFIG_DEBUG_VM is not set > # CONFIG_DEBUG_VM_PGTABLE is not set Try testing v6.3 with DEBUG_VM enabled or just remove the IS_ENABLED() from: https://github.com/torvalds/linux/blob/v6.4/net/ipv4/tcp.c#L1051