Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <20230726112913.4393-1-machel@vivo.com>
References: <20230726112913.4393-1-machel@vivo.com>
From:   Jay Vosburgh <j.vosburgh@gmail.com>
Date:   Wed, 26 Jul 2023 13:31:14 -0700
Message-ID: <CAAoacNk1sdkvdkdNpOu9yy9RtRW2zRbuNWnPV2cFzijfuQbMLw@mail.gmail.com>
Subject: Re: [PATCH net v5] bonding: Remove error checking for debugfs_create_dir()
To:     Wang Ming <machel@vivo.com>
Cc:     Andy Gospodarek kjmatt <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
        gregkh@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On 7/26/23, Wang Ming <machel@vivo.com> wrote:
> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in bond_debug_reregister().

I'm confused; I recall that the prior version kept the pr_warn(), but
changed the
test from a NULL check  to instead use IS_ERR().  I'll state again
that I think printing the error is useful, as it would provide an
indication of why the debugfs directory isn't available.  I also don't
see an obvious way the error could be used to spam the dmesg.

        -J


>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
>  drivers/net/bonding/bond_debugfs.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_debugfs.c
> b/drivers/net/bonding/bond_debugfs.c
> index 594094526..a41f76542 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -87,9 +87,6 @@ void bond_debug_reregister(struct bonding *bond)
>  void bond_create_debugfs(void)
>  {
>  	bonding_debug_root = debugfs_create_dir("bonding", NULL);
> -
> -	if (!bonding_debug_root)
> -		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>  }
>
>  void bond_destroy_debugfs(void)
> --
> 2.25.1
>
>