Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <20230726143419.19392-1-yuehaibing@huawei.com>
References: <20230726143419.19392-1-yuehaibing@huawei.com>
From:   Jay Vosburgh <j.vosburgh@gmail.com>
Date:   Wed, 26 Jul 2023 13:45:27 -0700
Message-ID: <CAAoacNmRXNbc5wZAjre3U-VwzKh_V==bmJZCoXLAHcWmNVW9Eg@mail.gmail.com>
Subject: Re: [PATCH 27/29] bonding: 3ad: Remove unused declaration bond_3ad_update_lacp_active()
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     andy@greyhouse.net, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, jon.toppins+linux@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        liuhangbin@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On 7/26/23, YueHaibing <yuehaibing@huawei.com> wrote:
> This is not used since commit 3a755cd8b7c6 ("bonding: add new option
> lacp_active")

To be clear, it appears that the cited commit added the declaration of
bond_3ad_upate_lacp_active() to bond_3ad.h, but did not add the actual
function definition.  A brief search suggests that the function has
never existed.

Regardless, the declaration shouldn't be there now.

Acked-by: Jay Vosburgh <j.vosburgh@gmail.com>


> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  include/net/bond_3ad.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h
> index a016f275cb01..c5e57c6bd873 100644
> --- a/include/net/bond_3ad.h
> +++ b/include/net/bond_3ad.h
> @@ -301,7 +301,6 @@ int  __bond_3ad_get_active_agg_info(struct bonding
> *bond,
>  int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
>  			 struct slave *slave);
>  int bond_3ad_set_carrier(struct bonding *bond);
> -void bond_3ad_update_lacp_active(struct bonding *bond);
>  void bond_3ad_update_lacp_rate(struct bonding *bond);
>  void bond_3ad_update_ad_actor_settings(struct bonding *bond);
>  int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats
> *stats);
> --
> 2.34.1
>
>