Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kees Cook <keescook@chromium.org>
To:     Hans de Goede <hdegoede@redhat.com>,
        Kees Cook <keescook@chromium.org>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH] vboxsf: Use flexible arrays for trailing string member
Date:   Wed, 26 Jul 2023 14:55:48 -0700
Message-Id: <169040854617.1782642.4557415464507636357.b4-ty@chromium.org>
In-Reply-To: <20230720151458.never.673-kees@kernel.org>
References: <20230720151458.never.673-kees@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Thu, 20 Jul 2023 08:15:06 -0700, Kees Cook wrote:
> The declaration of struct shfl_string used trailing fake flexible arrays
> for the string member. This was tripping FORTIFY_SOURCE since commit
> df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"). Replace the
> utf8 and utf16 members with actual flexible arrays, drop the unused ucs2
> member, and retriain a 2 byte padding to keep the structure size the same.
> 
> 
> [...]

Applied to for-linus/hardening, thanks!

[1/1] vboxsf: Use flexible arrays for trailing string member
      https://git.kernel.org/kees/c/a8f014ec6a21

Best regards,
-- 
Kees Cook