Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1644134rwb; Wed, 26 Jul 2023 16:20:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEiPy2p8SK6KzsMslSyZLbS2I5XzRdY/Tavm7UNg2an8ZOFPjb0XdWRIIu4TJmtVH2znGNu X-Received: by 2002:a05:6a20:3952:b0:138:2fb8:6aab with SMTP id r18-20020a056a20395200b001382fb86aabmr3505017pzg.8.1690413601715; Wed, 26 Jul 2023 16:20:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690413601; cv=none; d=google.com; s=arc-20160816; b=0oeX3vQEyh4lNylOz9acX7oV0NkVcHecc2lgjFnAksne+r+KG/CkxiPxiQII+zCzQB Uk+M88OkflVDdeE201II85scD52xkwlgJVChb0qAv2fPW9bSZ26vzqJS8VGKl/fwloNU vhkjHsKJGeJwjlJjs8dqLKy9EggqqAkhr2ZV3rJLu8QSqyMHfXxW/BW1hWXGv7Ke6v0j c7NxJWEzl/pAXFWkvoqf6KtY9cLuQKdKnyNxCDSl3B1K0MiFTVmq12EFyoxQwYOlkVs4 xaMN1T6pl3k/gblqWlkFrLGksWnqUV6WoccKnKHTQqF3UOemo9hpsazXh/j/GF+NIE/R Qe0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=gWm5Ooo/kPPI+DF0mtQhpptTHmyIMGjRoncz1iWxpxc=; fh=8aRJmp2JykrbUv0hboL7a9uUbLnhUg6oUc71sznDeCY=; b=gB+cmydklzxA8CF//lYcsx16Y+Vicd1VtNrL9vFPmy9OSEGrv30h/R4NjQG8gDKQrk CmU4lyLnghCCKWiwd+YJNPxARiV1yYsMcEF7gCv1+4TTqrZzUch3Pvs78OFfuEg6E/Ok 1ipV+EkPN0fjnpZUIupZ50C1wR1awjWyxZ8D0VYbUc8g8qtAqRhuET3RQNaqdWXfTQ45 83av5Et86UzESOAX4Kisdj1BC0hfxaU4T+HbW7sPDRHInAmGUNCJurDwTVEwLA6MwBBJ 2infBeK5VIfVn5bNwHCEzHriUlqPPkK/apyz54o2IHkmzTU9luFtgQJs/9c19AmAc00j caDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cm5-20020a056a00338500b0067d204bf281si226842pfb.3.2023.07.26.16.19.47; Wed, 26 Jul 2023 16:20:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbjGZWTE (ORCPT + 99 others); Wed, 26 Jul 2023 18:19:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjGZWTD (ORCPT ); Wed, 26 Jul 2023 18:19:03 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 223E81BFF; Wed, 26 Jul 2023 15:19:01 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id AE4CC24E26F; Thu, 27 Jul 2023 06:18:59 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 27 Jul 2023 06:18:59 +0800 Received: from [192.168.60.107] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 27 Jul 2023 06:18:59 +0800 Message-ID: <9c38930b-4bd9-4956-74c7-3be2915f4676@starfivetech.com> Date: Thu, 27 Jul 2023 06:18:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 3/6] media: starfive: camss: Add basic driver Content-Language: en-US To: Bryan O'Donoghue , Mauro Carvalho Chehab , Robert Foss , Todor Tomov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart , Hans Verkuil , Eugen Hristev , Ezequiel Garcia CC: , , , References: <20230619112838.19797-1-jack.zhu@starfivetech.com> <20230619112838.19797-4-jack.zhu@starfivetech.com> From: Jack Zhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bryan, Thank you for your comments. On 2023/7/26 18:58, Bryan O'Donoghue wrote: > On 19/06/2023 12:28, Jack Zhu wrote: >> Add basic platform driver for StarFive Camera Subsystem. > > Another nit here. > > "Add basic driver" isn't a great title. Recommend "Add core driver". > > Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc. > > Use "core" not "basic" to describe this. > Ok, I will modify this title. > --- > bod > -- Regards, Jack Zhu