Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230726164535.230515-1-amiculas@cisco.com> <20230726164535.230515-11-amiculas@cisco.com>
 <CALNs47ss3kV3mTx4ksYTWaHWdRG48=97DTi3OEnPom2nFcYhHw@mail.gmail.com>
In-Reply-To: <CALNs47ss3kV3mTx4ksYTWaHWdRG48=97DTi3OEnPom2nFcYhHw@mail.gmail.com>
From:   Wedson Almeida Filho <wedsonaf@gmail.com>
Date:   Wed, 26 Jul 2023 20:47:41 -0300
Message-ID: <CANeycqqTdL9vr=JF+Fij5EY0TW_+_FY1p2qGdvGhYcyH9=9J9w@mail.gmail.com>
Subject: Re: [RFC PATCH v2 10/10] rust: puzzlefs: add oci_root_dir and
 image_manifest filesystem parameters
To:     Trevor Gross <tmgross@umich.edu>
Cc:     Ariel Miculas <amiculas@cisco.com>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tycho@tycho.pizza, brauner@kernel.org, viro@zeniv.linux.org.uk,
        ojeda@kernel.org, alex.gaynor@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 26 Jul 2023 at 18:08, Trevor Gross <tmgross@umich.edu> wrote:
>
> On Wed, Jul 26, 2023 at 12:55=E2=80=AFPM Ariel Miculas <amiculas@cisco.co=
m> wrote:
> >
> > These parameters are passed when mounting puzzlefs using '-o' option of
> > mount:
> > -o oci_root_dir=3D"/path/to/oci/dir"
> > -o image_manifest=3D"root_hash_of_image_manifest"
> >
> > For a particular manifest in the manifests array in index.json (located
> > in the oci_root_dir), the root hash of the image manifest is found in
> > the digest field.
> >
> > It would be nicer if we could pass the tag, but we don't support json
> > deserialization.
> >
> > Example of mount:
> > mount -t puzzlefs -o oci_root_dir=3D"/home/puzzlefs_oci" -o \
> > image_manifest=3D"2d6602d678140540dc7e96de652a76a8b16e8aca190bae141297b=
cffdcae901b" \
> > none /mnt
> >
> > Signed-off-by: Ariel Miculas <amiculas@cisco.com>
> > ---
> >  samples/rust/puzzlefs.rs | 63 ++++++++++++++++++++++++++--------------
> >  1 file changed, 41 insertions(+), 22 deletions(-)
> >
> > diff --git a/samples/rust/puzzlefs.rs b/samples/rust/puzzlefs.rs
> > index dad7ecc76eca..4e9a8aedf0c1 100644
> > --- a/samples/rust/puzzlefs.rs
> > +++ b/samples/rust/puzzlefs.rs
> > @@ -7,6 +7,7 @@
> >  use kernel::{
> >      c_str, file, fs,
> >      io_buffer::IoBufferWriter,
> > +    str::CString,
> >      sync::{Arc, ArcBorrow},
> >  };
> >
> > @@ -31,27 +32,29 @@ struct PuzzlefsInfo {
> >      puzzlefs: Arc<PuzzleFS>,
> >  }
> >
> > +#[derive(Default)]
> > +struct PuzzleFsParams {
> > +    oci_root_dir: Option<CString>,
> > +    image_manifest: Option<CString>,
> > +}
> > +
> >  #[vtable]
> >  impl fs::Context<Self> for PuzzleFsModule {
> > -    type Data =3D ();
> > -
> > -    kernel::define_fs_params! {(),
> > -        {flag, "flag", |_, v| { pr_info!("flag passed-in: {v}\n"); Ok(=
()) } },
> > -        {flag_no, "flagno", |_, v| { pr_info!("flagno passed-in: {v}\n=
"); Ok(()) } },
> > -        {bool, "bool", |_, v| { pr_info!("bool passed-in: {v}\n"); Ok(=
()) } },
> > -        {u32, "u32", |_, v| { pr_info!("u32 passed-in: {v}\n"); Ok(())=
 } },
> > -        {u32oct, "u32oct", |_, v| { pr_info!("u32oct passed-in: {v}\n"=
); Ok(()) } },
> > -        {u32hex, "u32hex", |_, v| { pr_info!("u32hex passed-in: {v}\n"=
); Ok(()) } },
> > -        {s32, "s32", |_, v| { pr_info!("s32 passed-in: {v}\n"); Ok(())=
 } },
> > -        {u64, "u64", |_, v| { pr_info!("u64 passed-in: {v}\n"); Ok(())=
 } },
> > -        {string, "string", |_, v| { pr_info!("string passed-in: {v}\n"=
); Ok(()) } },
> > -        {enum, "enum", [("first", 10), ("second", 20)], |_, v| {
> > -            pr_info!("enum passed-in: {v}\n"); Ok(()) }
> > -        },
> > +    type Data =3D Box<PuzzleFsParams>;
> > +
> > +    kernel::define_fs_params! {Box<PuzzleFsParams>,
> > +        {string, "oci_root_dir", |s, v| {
> > +                                      s.oci_root_dir =3D Some(CString:=
:try_from_fmt(format_args!("{v}"))?);
> > +                                      Ok(())
> > +                                  }},
> > +        {string, "image_manifest", |s, v| {
> > +                                      s.image_manifest =3D Some(CStrin=
g::try_from_fmt(format_args!("{v}"))?);
> > +                                      Ok(())
> > +                                  }},
> >      }
> >
> > -    fn try_new() -> Result {
> > -        Ok(())
> > +    fn try_new() -> Result<Self::Data> {
> > +        Ok(Box::try_new(PuzzleFsParams::default())?)
> >      }
> >  }
> >
> > @@ -136,11 +139,27 @@ impl fs::Type for PuzzleFsModule {
> >      const FLAGS: i32 =3D fs::flags::USERNS_MOUNT;
> >      const DCACHE_BASED: bool =3D true;
> >
> > -    fn fill_super(_data: (), sb: fs::NewSuperBlock<'_, Self>) -> Resul=
t<&fs::SuperBlock<Self>> {
> > -        let puzzlefs =3D PuzzleFS::open(
> > -            c_str!("/home/puzzlefs_oci"),
> > -            c_str!("2d6602d678140540dc7e96de652a76a8b16e8aca190bae1412=
97bcffdcae901b"),
> > -        );
> > +    fn fill_super(
> > +        data: Box<PuzzleFsParams>,
> > +        sb: fs::NewSuperBlock<'_, Self>,
> > +    ) -> Result<&fs::SuperBlock<Self>> {
> > +        let oci_root_dir =3D match data.oci_root_dir {
> > +            Some(val) =3D> val,
> > +            None =3D> {
> > +                pr_err!("missing oci_root_dir parameter!\n");
> > +                return Err(ENOTSUPP);
> > +            }
> > +        };
> > +
> > +        let image_manifest =3D match data.image_manifest {
> > +            Some(val) =3D> val,
> > +            None =3D> {
> > +                pr_err!("missing image_manifest parameter!\n");
> > +                return Err(ENOTSUPP);
> > +            }
> > +        };
> > +
>
> The guard syntax (available since 1.65) can make these kinds of match sta=
tements
> cleaner:

This is unstable though.

We try to stay away from unstable features unless we really need them,
which I feel is not the case here.

>     let Some(oci_root_dir) =3D data.oci_root_dir else {
>         pr_err!("missing oci_root_dir parameter!\n");
>         return Err(ENOTSUPP);
>     }
>
>     let Some(image_manifest) ...
>
> > +        let puzzlefs =3D PuzzleFS::open(&oci_root_dir, &image_manifest=
);
> >
> >          if let Err(ref e) =3D puzzlefs {
> >              pr_info!("error opening puzzlefs {e}\n");
> > --
> > 2.41.0
> >
> >