Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <39dc0aba-54f7-5c36-01a0-b48d91b6f1c8@amlogic.com>
Date:   Thu, 27 Jul 2023 10:24:03 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH V2 3/4] soc: c3: Add support for power domains controller
Content-Language: en-US
To:     Kevin Hilman <khilman@baylibre.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>
References: <20230707003710.2667989-1-xianwei.zhao@amlogic.com>
 <20230707003710.2667989-4-xianwei.zhao@amlogic.com>
 <7ha5vii9ew.fsf@baylibre.com>
From:   Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <7ha5vii9ew.fsf@baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RENrK3BoOGx1amdBU2V4S3k2TkZDaFlOODZUTG9YcC9RdkFFMGI0SXMyVGlJ?=
 =?utf-8?B?VHVicnVrQWNrWmllMHdPVWRVOTJGUkhodzk2YWhmM0F4UHlPNzYrQS9mS01R?=
 =?utf-8?B?NVVyMGRnUWVUV2JZOUs3STl2NDU0QTRCSzBQaTYxOVB4N2ZQbDF1dGpGOVJh?=
 =?utf-8?B?YW9pZUhvOThaRDF0ZXdZSlRYb0FsS2xraUVkNXRVWkdmMklxV21DZmhTcyt5?=
 =?utf-8?B?Uy9WNlB6dU4yRlgyaTdMT05xZ0NnSCsraXM4QkZJNkgxSEdoNEx4ZGdBdC9u?=
 =?utf-8?B?OC9QMkVmU1hLMGZ6SVlNMVArNGZQWTBNeGZLQS9EVS8rTmhHRVNvZE1zZUg0?=
 =?utf-8?B?Unk2WUlKb3VrLzlQWDZHNHR0MzIwdFNIb0NXN2xyV0o1V1RBSWcrL2U3VGdH?=
 =?utf-8?B?R3FuUnQwRHNNUVVoZXFVaHlReDRaSHJQMFZwNjFSNG5reE5HNmlaNzhvU1ho?=
 =?utf-8?B?dEE2dG5iSDdlWEYwMGxLcDJzeEd6c1VuT2ZxejRLTGdhUDNBTDhRbXZ3VlJ4?=
 =?utf-8?B?VUx3T3FpaTd0L0VuMTY0TmE4bHV6Vm1aVHpZUWczQWdBSXNLczhLdStvMitn?=
 =?utf-8?B?QkV6MjgvV2NiV05jL2thTGM0Sk5yMCtlN2x4Q3VEU2VUa3VPQkNQSmFqd2J6?=
 =?utf-8?B?ZWI0T0tuTG1GS284WUlkUjhDcG1nZnhPUk1MYm1oTHVLRllPUEdrNCtvTml6?=
 =?utf-8?B?YXcxWWovekJSZFVNVkNlcmQrZStoVEVwWUVQcm9ia2xwdmtKWHkrQlBHNDlr?=
 =?utf-8?B?UFlEZytVRVo3aDZHeURXK2FEQUNITzhnRnRPT05lK3RBZUNZTEQyQUlndFVL?=
 =?utf-8?B?bFhDVkJtQWdJdmtFWERWVTJNUGRoYXVxK1kxQmFldDVZeVRoUlBXa0pML3NG?=
 =?utf-8?B?YXMyN3FsQUhFekRqem0zTEh2QkJlV2NZU0FsbWw0YXFNQkNTeEFrbG9KYmwy?=
 =?utf-8?B?MGQ4YjkxVUhTaWVONWdMMlFlcDVtUElPMytaRm45aE1iSlUzRm5Vb0lLaEVQ?=
 =?utf-8?B?dzVGaVpWVFgyUUdoUTVBaGRraWQwUzRQMU01YnQ4M3lPTi96T1VVaGVZM3ov?=
 =?utf-8?B?aFZLd2lDY0c3bnNRV3ZCV25pY2YzUGw5d3pnS2Y2V0VkcEhZVWUxUFFjbGVI?=
 =?utf-8?B?VVVjbDVSM2lMbDdZTHNvTDhOM21tYmxhR2NVVTdRT29Ick9KdFNBNTA3V20x?=
 =?utf-8?B?a2QybUs1ZDNCTlFGN0kzK3BpbHlSZ1R5N2F3eWc4d0htZHRnY3l0dGtpQkl3?=
 =?utf-8?B?N25rMWNleWl1aG1EY3V6MnR5T1JES01aWWd3bnQ5YUJrUUVJUXFtdTFZcFVm?=
 =?utf-8?B?M0xrdnNidEJRSU5CQ0FOOXpwWlYxOFF2NGhVRU9MT0pJd2twYzJQdGlyTU14?=
 =?utf-8?B?dFRyWWpUcm9ON3ZvdlZkV0NrcDJQeExUMGhjUGoyVXNaT05yUjBBOVhyZ1dl?=
 =?utf-8?B?K1pjT3UwSzZPVlZMR0RrN0N4MTBZUUxnL1VXRTRWWGNwZGc4U3NaOFRQMDJI?=
 =?utf-8?B?VHJHZ0lBYUVHU3FZL3V4SW85Vm1FSG5tNlFMVWpSSHBRbUM4UE1KQXFaajAz?=
 =?utf-8?B?VndPZTBVcTBnc0VkNEpZYjdMSWc2bjAwcGpaZU1HM0wvU0UySTAwam5zdUF0?=
 =?utf-8?B?NnJtY1dSVVNDaXlyTnBuUy9VMmc0YVJyNWF3M0hXQ2U1aGJub25uckFSYUlL?=
 =?utf-8?B?VG5HM0VJTFhNNm5XcEdoVm1Hcm56Q3pBNjAzWVhWbnJEbjJOdnJJSlgxRS9J?=
 =?utf-8?B?UWVwTjNNeS9FRWNYekpLbWd5TEc1Wkg4VXZNZlJtdGV0aW4xZ0hpWUM4aTRk?=
 =?utf-8?B?ZnFjVE5qL3R2ZFZZREsvMW5oU3pzLzdBR0dONUU1THNFTSsrbS83WHE2RUpD?=
 =?utf-8?B?YVVVcDZkNkFZTU1UdFhOMSs2ZE5ZVFkzQktLVi9sL1JtSjBEZ3RGUU54S0NZ?=
 =?utf-8?B?Y0xDSnFxRTBsYXRZOVQyYVVRa2JoVEoraklSSE1EdzFJc2F3Q1RxYVVJUTRP?=
 =?utf-8?B?Z29Jd1JSaUJJdHNpak4zeEtiVmwyM0RFT3daZ3NiUjVFcWVLK0dSaUUwLy9K?=
 =?utf-8?B?eE1FcUM4cFpYZXdyVXlFY3BkL1NLanhxNWQ4RFBqQlVCWXFwWlpVaDIvUVFW?=
 =?utf-8?B?OXo0M3pHclB1TitlUXVjTFpNN3lUYVNTTWJjcW9QRWsvRDF0b3pOL1ZlcHpu?=
 =?utf-8?B?VEE9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b277a72-8079-4693-a6cb-08db8e488df5
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 02:24:07.7653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7uZire5sU02tzTzukAIplJDARIg1WsFhY0tRGdULYRWnyQrsBbuKtSeT/XQ2520Morm9OVjS2Bu8ZilGYQ2XlP0AGvIoM/y7O9q8sKWDFek=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB7027
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kevin,
      Thanks for your reply.

On 2023/7/27 06:40, Kevin Hilman wrote:
> [ EXTERNAL EMAIL ]
> 
> Xianwei Zhao <xianwei.zhao@amlogic.com> writes:
> 
>> Add support for C3 Power controller. C3 power control
>> registers are in secure domain, and should be accessed by SMC.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> V1 -> V2: Fixed some formatting.
>> ---
>>   drivers/soc/amlogic/meson-secure-pwrc.c | 26 +++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/drivers/soc/amlogic/meson-secure-pwrc.c b/drivers/soc/amlogic/meson-secure-pwrc.c
>> index c11d65a3e3d9..a1ffebf70de3 100644
>> --- a/drivers/soc/amlogic/meson-secure-pwrc.c
>> +++ b/drivers/soc/amlogic/meson-secure-pwrc.c
>> @@ -11,6 +11,7 @@
>>   #include <linux/platform_device.h>
>>   #include <linux/pm_domain.h>
>>   #include <dt-bindings/power/meson-a1-power.h>
>> +#include <dt-bindings/power/amlogic,c3-pwrc.h>
>>   #include <dt-bindings/power/meson-s4-power.h>
>>   #include <linux/arm-smccc.h>
>>   #include <linux/firmware/meson/meson_sm.h>
>> @@ -120,6 +121,22 @@ static struct meson_secure_pwrc_domain_desc a1_pwrc_domains[] = {
>>        SEC_PD(RSA,     0),
>>   };
>>
>> +static struct meson_secure_pwrc_domain_desc c3_pwrc_domains[] = {
>> +     SEC_PD(C3_NNA,  0),
>> +     SEC_PD(C3_AUDIO,        GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_SDIOA,        GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_EMMC, GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_USB_COMB, GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_SDCARD,       GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_ETH,  GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_GE2D, GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_CVE,  GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_GDC_WRAP,     GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_ISP_TOP,              GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_MIPI_ISP_WRAP, GENPD_FLAG_ALWAYS_ON),
>> +     SEC_PD(C3_VCODEC,       0),
>> +};
> 
> All of these domains being hard-coded to ALWAYS_ON looks suspicious, and
> can also be an indicator that the drivers for these domains are not
> (properly) using runtime PM, or not connected to the correct domains the DT.
> 
> Similar to the tables for s4 and a1 in this same file, please describe
> the reason that each of these domains needs to be hard coded to be
> always on.
Will do.
> 
> Thanks,
> 
> Kevin