Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   carlos.song@nxp.com
To:     andi.shyti@kernel.org, aisheng.dong@nxp.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com
Cc:     carlos.song@nxp.com, xiaoning.wang@nxp.com, haibo.chen@nxp.com,
        linux-imx@nxp.com, linux-i2c@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4] i2c: imx-lpi2c: directly return ISR when detect a NACK
Date:   Thu, 27 Jul 2023 11:03:47 +0800
Message-Id: <20230727030347.3552992-1-carlos.song@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sUM8BozRvX0NzQPgZ7oSGaVw5ZTB3ywlkTMJmuO57nNFqZOWNpdoPJFgk9l2?=
 =?us-ascii?Q?LXugFwNc8vDLedDJcDuapjV82cQplrR4xTDj14MmcOybWU0Oz5hxDQZQjODa?=
 =?us-ascii?Q?OhrRD4kB6ysoy5D0Ds0QsWeHHRaiBzh/uKTMn1+TVL0OkbyJx4CwxK9ljlNP?=
 =?us-ascii?Q?/m13Krd2TZAiku3J/ab9ZjHfZlAyEAAmKedq05UPQIPtrB26Yw0ZFgQY2CCT?=
 =?us-ascii?Q?c3EGN2MWbAvOq2IRro2i+9W7ebBXneyfthVQVwS/h6lDNgtY3p7LgGGMRj1m?=
 =?us-ascii?Q?jaIsY5U5tPK3eemfGE0Uj48XlnuwPdCPzOwjFo8dvtEQWX3tFRIFEWicO+eA?=
 =?us-ascii?Q?qDsG9nl7oy+FvgZTCrelViPY9+KhXFNv96fHWlh/GCHOaisVoUKXWD7yxHIx?=
 =?us-ascii?Q?nSH+vXd8Or8NwKDEmNhHuBrdWIPyKgflFeiwd7BtPN2r0VXLSLHejhzv+m85?=
 =?us-ascii?Q?scRC4lM6bEGipsaMWrZjvKt2Pp0z5U6vxisAgAVe777LFrHDH5Dn89ATnImj?=
 =?us-ascii?Q?ce5nnLkO9tv7Vw/BbtH6aXAblbNc9lhNxdRLq2gvXvJOMFMCUnEflLEokEFi?=
 =?us-ascii?Q?ctVBnZVTT+zcTbsDIHdCTEZbjp6iRunIimk55YKyq2PzaSO/D4EswoWiZt7N?=
 =?us-ascii?Q?9IG/IqLaLy0VtbX6RpoMxRIAUpKZdO+Wf7BVcbdlsrkaX1fKrvs1BnYmqlKO?=
 =?us-ascii?Q?WGUvdp6nHhFFakmaGwGN8zQn7OAc78WQzX/g4Nw1IWwL2qgQl04ihCrM/KDf?=
 =?us-ascii?Q?t6YoMzQ5ZW2Fasn038zKngglagBf+9FwI6mtltUpXW3rgivV61fybIW5wkcl?=
 =?us-ascii?Q?gsbfaUym7iRt5tzQz8omsyBHjSCLd+zAt/K2W+56AJfg9XLVd5UgwpfzB1wt?=
 =?us-ascii?Q?Lv5Oma3GbJAv4RyPoKJRQXIwRpigpItBA1ixyUjn4GyzURt2d9CJ3J2Gy55j?=
 =?us-ascii?Q?XdG9a358/tpt8sxXmcBRNxgBjx6mCs+I7e0f/d7ptEBsxNgrYs03pLUaiB0g?=
 =?us-ascii?Q?51vW1jugfy3C+hoBEVB5/XErDPra4x2uwz8YfyOeYHXesydcuGzAEB/ErVZ7?=
 =?us-ascii?Q?NaybhXGyJSeU8dKrm0X2Y7uSbdF48YEtLjAZdFdKlrpoaCm1iPp1yH8kbwlp?=
 =?us-ascii?Q?3Q3+hP3O+n+IooYVabBpBC/7ftN+U/pfzsKwUIff5bicE4BvwIyhVk8H3sNI?=
 =?us-ascii?Q?V+wYTnE9a1vWkc1hTJkO1sDd+tB2NRIBCypE55/4gmf/t6clq3twLAUwW30V?=
 =?us-ascii?Q?Dv/E1k3O6M6v4J+2XLdP8/0VUVroBBTcGfGCMlI8koAW9yKc/EZm3e1tmG1b?=
 =?us-ascii?Q?Mf1Sy8h0gSXREqq52u1/o6ZwMnEs4FTFBSVowOKc9lWawzbmLdDN8/wG56NA?=
 =?us-ascii?Q?XJP2bkvqRDyg0LvhwkS+2rUtrwzm3TGdEpW3DdM/cqrNmVJa4Qhs9a9Ankth?=
 =?us-ascii?Q?lcRIFNJ+iTBQwYDr7baC8/+jlwX6y6JYC8IJ1vznNZ5hN+AZX++JC9gR3RA0?=
 =?us-ascii?Q?LIJPATyR0OQTgQ0ZSUfW0fC4xENi5sXTku5f3mAjT4Jm0S/Dv4zwFV/LFEuY?=
 =?us-ascii?Q?TtNZweTZcqTnNEavBRENRXMmCfip50ResQUjsHES?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 860ba24d-944d-40e2-d9c1-08db8e4d9175
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 03:00:01.0731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L9PlSXb4hIM92WDx6IiXdMxjJGwZfa3N8VX/rRQGCHQacTJxHY5qghr9uHz3NAyJoJNs3i87LlcKctBY5V8NEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8259
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Carlos Song <carlos.song@nxp.com>

A NACK flag in ISR means i2c bus error. In such condition,
there is no need to do read/write operation.

In this patch, i2c will check MSR_NDF, MSR_RDF and MSR_TDF
flag in turn, it's making mutually exclusive NACK/read/write.
So when a NACK is received(MSR_NDF), i2c will return ISR
directly and then stop i2c transfer.

Signed-off-by: Carlos Song <carlos.song@nxp.com>
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index 150d923ca7f1..9a3e3a1bc4ee 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -517,14 +517,12 @@ static irqreturn_t lpi2c_imx_isr(int irq, void *dev_id)
 	temp = readl(lpi2c_imx->base + LPI2C_MSR);
 	temp &= enabled;
 
-	if (temp & MSR_RDF)
-		lpi2c_imx_read_rxfifo(lpi2c_imx);
-
-	if (temp & MSR_TDF)
-		lpi2c_imx_write_txfifo(lpi2c_imx);
-
 	if (temp & MSR_NDF)
 		complete(&lpi2c_imx->complete);
+	else if (temp & MSR_RDF)
+		lpi2c_imx_read_rxfifo(lpi2c_imx);
+	else if (temp & MSR_TDF)
+		lpi2c_imx_write_txfifo(lpi2c_imx);
 
 	return IRQ_HANDLED;
 }
-- 
2.34.1