Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230725232913.2981357-1-joel@joelfernandes.org>
 <20230725232913.2981357-6-joel@joelfernandes.org> <a28a2b4d-18f3-418a-ab9d-46d42616a118@paulmck-laptop>
In-Reply-To: <a28a2b4d-18f3-418a-ab9d-46d42616a118@paulmck-laptop>
From:   Joel Fernandes <joel@joelfernandes.org>
Date:   Wed, 26 Jul 2023 22:55:24 -0400
Message-ID: <CAEXW_YSUOzRxCX9cBeaXbBODt6EaNG+Xm-KF3nx7UoVCV4L3NQ@mail.gmail.com>
Subject: Re: [PATCH 5/5] Revert "checkpatch: Error out if deprecated RCU API used"
To:     paulmck@kernel.org
Cc:     linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
        Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>, rcu@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jul 26, 2023 at 5:12=E2=80=AFPM Paul E. McKenney <paulmck@kernel.or=
g> wrote:
>
> On Tue, Jul 25, 2023 at 11:29:10PM +0000, Joel Fernandes (Google) wrote:
> > The check for single-argument kfree_rcu() is no longer needed as all
> > users have been converted.
> >
> > This reverts commit 1eacac3255495be7502d406e2ba5444fb5c3607c.
> >
> > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>
> Good eyes, thank you!
>
> I applied this with an updated commit log as shown below.  Please let
> me know if I messed something up.

LGTM. Thank you!

 - Joel


>
>                                                         Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit 1f5f0053f7662385d9ead46d4c0d2d4fe9aaa73a
> Author: Joel Fernandes (Google) <joel@joelfernandes.org>
> Date:   Tue Jul 25 23:29:10 2023 +0000
>
>     Revert "checkpatch: Error out if deprecated RCU API used"
>
>     The definition for single-argument kfree_rcu() has been removed,
>     so that any further attempt to use it will result in a build error.
>     Because of this build error, there is no longer any need for a specia=
l
>     check in checkpatch.pl.
>
>     Therefore, revert commit 1eacac3255495be7502d406e2ba5444fb5c3607c.
>
>     Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>     Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index a9841148cde2..528f619520eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6422,15 +6422,6 @@ sub process {
>                         }
>                 }
>
> -# check for soon-to-be-deprecated single-argument k[v]free_rcu() API
> -               if ($line =3D~ /\bk[v]?free_rcu\s*\([^(]+\)/) {
> -                       if ($line =3D~ /\bk[v]?free_rcu\s*\([^,]+\)/) {
> -                               ERROR("DEPRECATED_API",
> -                                     "Single-argument k[v]free_rcu() API=
 is deprecated, please pass rcu_head object or call k[v]free_rcu_mightsleep=
()." . $herecurr);
> -                       }
> -               }
> -
> -
>  # check for unnecessary "Out of Memory" messages
>                 if ($line =3D~ /^\+.*\b$logFunctions\s*\(/ &&
>                     $prevline =3D~ /^[ \+]\s*if\s*\(\s*(\!\s*|NULL\s*=3D=
=3D\s*)?($Lval)(\s*=3D=3D\s*NULL\s*)?\s*\)/ &&