Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Suman Ghosh <sumang@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [EXT] Re: [net-next PATCH] octeontx2-af: Tc flower offload
 support for inner VLAN
Thread-Topic: [EXT] Re: [net-next PATCH] octeontx2-af: Tc flower offload
 support for inner VLAN
Thread-Index: AQHZvuOn06J9A5HNiEW7gGsIBeeYZq/L8HEAgAEhCjA=
Date:   Thu, 27 Jul 2023 05:03:56 +0000
Message-ID: <SJ0PR18MB521633C59700B7C8DE352B76DB01A@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20230725103442.2749183-1-sumang@marvell.com>
 <20230726114836.GU11388@unreal>
In-Reply-To: <20230726114836.GU11388@unreal>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vH1LV6Lr79Gq1aYN6I8zdjVfN6mmwiF3IFkh3shFItXh5vhUYrkruTT0j63a?=
 =?us-ascii?Q?91r77SCopVVHB2tD/abek6OjN8ON73Nf1WXAfbf8M4XqWWnQs49ZNegx94wN?=
 =?us-ascii?Q?aUBenaq5dy5sWFMp3NTMbGl3IpMtLNejIJT+ldHtCB2Fgx/jhs63WKUZ1Ify?=
 =?us-ascii?Q?03Sody/Ral2dyvNMcXF4jv9/WGDStoS4EylSSj4xK27mYRMawg1ccCXKNwV2?=
 =?us-ascii?Q?NXHbcWpiJxAZ+naQfzKNpBYMSBj0Oj1r6lxZhDreKAVDK6MN8zyEeRJzFZp8?=
 =?us-ascii?Q?yTMioOTfekVBiWDnctbe8LD7GcMPFD/v/EWE9owLE5cHVID9pI0k6J3kopBP?=
 =?us-ascii?Q?TiCUPouLewj8lAV38EQ0TlL1wbrNhzEYLnj0RrmAmkmObQshAJaT0lMcwx0o?=
 =?us-ascii?Q?HhGQ9rbgLrFWaJb9QEdc/LObum6Kl7SNB9B/hc6SWmEGC6RsApZ6rBHZmVLu?=
 =?us-ascii?Q?zZqakCXmYjQJBNR7/KUKLZbakuw4KTvuP/hY4tFQFVrRj6G6MzN/X3SH8k0g?=
 =?us-ascii?Q?gmm5tL/Om4MhhqEuBDNHSPtx8idP0ybwleg8sA1bCXTS/SMJKcZZXA4WZrwo?=
 =?us-ascii?Q?bmXWwX76XloUvEmKX5yu6HkqRph8etzWFaGedt821/tOis9Goh8tLnfAcXwl?=
 =?us-ascii?Q?yQSIGVcavIZJK3OyMIwQRAgM2uUkhBVtzLBBQ3wJxPaoHUXKsnkD38w+ML5y?=
 =?us-ascii?Q?o5BupDB/YdgG9gPCFdriMJSStmQStVHcI2NbImS/UX08GA/0XW85fv2biATV?=
 =?us-ascii?Q?Uu5WZpn+j9p2IsSYzJ3/j5aA8g/EORoVURo6NTuASTK2X3vI4pyJ6ARl1+jf?=
 =?us-ascii?Q?CDZVG3rtK8xWT8qxMJ/n2v8g+0XVBQKNrNQg+x4p7DWYbsnI8rmR/HXPCBe0?=
 =?us-ascii?Q?R80D3aULjGGswFGJVfiH2HGiolz3u4BgLZsl4xPfuN1E5LBkg9NCWMqGat9L?=
 =?us-ascii?Q?JK/GUzpzJTvFocor2RSMJL4M+CikNxw76q3ShuaH1WC/MWjo6n1EW4gUCeOn?=
 =?us-ascii?Q?QOPgj3j5huCJrv2rmW0l0Od6iJ6+grl89Xp+/uDXA1z+HeW48E1heqizB8Bc?=
 =?us-ascii?Q?i2X/VAIGpYJJq92RDxluL4tmReqYD08wSE0ZXtdcASZuk1cpHmo5Ee+yCa62?=
 =?us-ascii?Q?4gi4MGXIbLpfQAYk16s3kBCEXY9OuP+89hIUGwJ6ADmiaHLwSVHV8UFHYsnd?=
 =?us-ascii?Q?4y/PQ6xVgNrra7e8VSFCyNDRbIGCgTgkNKVnzhki0DCJPBFk6Tnzx3X8p/BH?=
 =?us-ascii?Q?S2ISvVBx/zrADAAA78Vl3CUa8zmlvu9IJdFzfnpNqbcLA5BrVnr6JSAezyEp?=
 =?us-ascii?Q?7HpiWOuUYDc8T3Y9mVrQzoilzEbP4wZlbQwmzoysfAMu7eG4LRELb439KljJ?=
 =?us-ascii?Q?i+dw2AXuqGuvx6WiVVClXzmgrXCN2x27FkuRVO9dS067tsVMKVOxwZRPTCwa?=
 =?us-ascii?Q?EVMhWiEb2uUC/7RRQpw341XeZGasBOfRfdsbOUTpveGMiFi4ceGLL+WdaXcu?=
 =?us-ascii?Q?jYWM10/4PGkwA96g3RCWuBm+wYkLG7AUibNeWh8p7oG2OLFnI8JiG7lh0nU0?=
 =?us-ascii?Q?domRJRUy+Qmy6J6EWyk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd1c3ca-924d-40fb-9ba1-08db8e5ee1a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2023 05:03:56.6688
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oFgGFH6/FCFaPv7/EwVUoU5rwMM3XSrC7AttbUUQ50JjZkvS0XB9OJ9Tv5j2pb5bhgcVtWYKTtjOsSb+6jvU7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR18MB5160
X-Proofpoint-ORIG-GUID: t4vTZ8moAzvwvDdzXwe88pAg4kwKfjjo
X-Proofpoint-GUID: t4vTZ8moAzvwvDdzXwe88pAg4kwKfjjo
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-26_08,2023-07-26_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> This patch extends current TC flower offload support to allow filters
>> involving inner VLAN matching, to be offloaded to HW.
>>
>> Example command:
>> tc filter add dev eth2 protocol 802.1AD parent ffff: flower vlan_id 10
>> vlan_ethtype 802.1Q cvlan_id 20 skip_sw action drop
>>
>> Signed-off-by: Suman Ghosh <sumang@marvell.com>
>> ---
>>  .../net/ethernet/marvell/octeontx2/af/mbox.h  |   1 +
>>  .../net/ethernet/marvell/octeontx2/af/npc.h   |   3 +
>>  .../marvell/octeontx2/af/rvu_debugfs.c        |   5 +
>>  .../marvell/octeontx2/af/rvu_npc_fs.c         |  13 +++
>>  .../ethernet/marvell/octeontx2/nic/otx2_tc.c  | 106
>> +++++++++++-------
>>  5 files changed, 90 insertions(+), 38 deletions(-)
>
><...>
>
>> +	if (!is_inner)
>> +		flow_rule_match_vlan(rule, &match);
>> +	else
>> +		flow_rule_match_cvlan(rule, &match);
>
><...>
>
>> +		if (!is_inner) {
>> +			flow_spec->vlan_tci =3D htons(vlan_tci);
>> +			flow_mask->vlan_tci =3D htons(vlan_tci_mask);
>> +			req->features |=3D BIT_ULL(NPC_OUTER_VID);
>> +		} else {
>> +			flow_spec->vlan_itci =3D htons(vlan_tci);
>> +			flow_mask->vlan_itci =3D htons(vlan_tci_mask);
>> +			req->features |=3D BIT_ULL(NPC_INNER_VID);
>> +		}
>
>Slightly better approach will be to reverse these checks from "if
>(!is_inner)" to be "f (is_inner)".
>
>Other than that,
[Suman] Sure Leon. Will push a v2 addressing the same.
>Reviewed-by: Leon Romanovsky <leonro@nvidia.com>