Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1921356rwb; Wed, 26 Jul 2023 22:31:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlF6gMekzwNz37c4wbieNct/ZDssL5P3ZL3vMlotgv4SpgK1S5IpHcHhPTRyI4NgRpQT9Rdq X-Received: by 2002:a17:906:d7:b0:99b:cecf:dc4 with SMTP id 23-20020a17090600d700b0099bcecf0dc4mr970635eji.48.1690435900530; Wed, 26 Jul 2023 22:31:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690435900; cv=none; d=google.com; s=arc-20160816; b=Y6tpVXz0xceJDVPpbjPXwMe2E7m88meNA82e6Nl+9p8kQciqdTE7f8izjGTchfE9H8 ilgsppo3CkLkdDeTL8IuDT3mwSUkTbXlIPIEXfmLRNGa9IUjszT0jm8KV+PEj/FrN9B4 Opzcz/xqxvr+tfr05GnnDIDn6jd4FBSTAtoFaaliLpIe3EXrFfgpAfiQQEDVSVqAQVir lJA4nmCIUFd/NWLUqDrv1ZmbaEb/A7OtIBgDizUHLTOAmH93RKQ+KwWsCfJ8DvPH/wEB 0KFxMoidHZafetiTTIRwmLCGe6yJdz1TlFfBJh9oPK8PNpZLM3HTq3reOCgYP8XIP58p FQ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=QCoq1iZagjrVnFKwt9gXCpthClwRkxUfN+QdFDpCeME=; fh=6693vUqjLnUXEi/49d2Lqv3/teyuSmRlsbQyEyDmj/s=; b=rUVWv6EbL0hKIzGPSV8+9ALs3mmdqdhbZrsB1Foq5x2mGY8DOXiCRAqEqldNIuMsGE QTsI6wVQ38jISXH6aDxOVlP2wo5ysrN6/5pJvFuMgtGGEXTyVGnecw2djJSctppdnKqw RgWQTFFIMrPxMWQm7beaNwZylBFO3YvqbLW/nAuOh6CwHY40rb32r0r5ra6e3/l2cRVI YSXLwJkPIM/KC0xARTQF6V//xORV53x+iums+39jZqNywKUPGcNE3Epx4tSUWXgX215m MbGtPEG0ExgNCooZRZkhpoUbPbVxP5BSgX712dvmomMlayWyWClB4p3oWTyMIqERD6QT HZDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aT76/NS7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id va16-20020a17090711d000b0099b6becb10fsi470008ejb.449.2023.07.26.22.31.16; Wed, 26 Jul 2023 22:31:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="aT76/NS7"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbjG0FKZ (ORCPT + 99 others); Thu, 27 Jul 2023 01:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbjG0FKX (ORCPT ); Thu, 27 Jul 2023 01:10:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A2261985 for ; Wed, 26 Jul 2023 22:10:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBBDC61D41 for ; Thu, 27 Jul 2023 05:10:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 25F21C433C8; Thu, 27 Jul 2023 05:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690434621; bh=BE1Xq1IRKwkqNNFUXpjvkjz1bngrVlNgq7E+8RUPC14=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=aT76/NS7jhAUJXxa66Ab+w+JqyN95LpT+3VOCNC+Hhvi69XRUb0INtERhVVZcWcJ7 IFpPN2kYb9yuiNZopzshJz5DyrNkutxyLUKbTQGCvBVQAO3PIFSJEd8TKV9tD4aPSw 0LltPyn6efHqlETDxj8/tr6UO2aX9+pINer31B/kpijXEXPoYLMRGdzLQs5pDxaTf+ lE08j9V6GQwpfAeV5Lhrm+1w0+KJmp9DDkvWAo3p1QlG5OVarVIPc2HZiLfI12VEDT kSEWTaQhkDMC5GlrIRyS4Pq/VujFYraju1v8v+J/Szz5g9p0qCqCJIWMf9cGMiwjhd tNuNxaxRYnp3g== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0CDEBC59A4C; Thu, 27 Jul 2023 05:10:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v3] net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64 From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169043462104.30073.7457238060155028542.git-patchwork-notify@kernel.org> Date: Thu, 27 Jul 2023 05:10:21 +0000 References: <20230725024227.426561-1-linma@zju.edu.cn> In-Reply-To: <20230725024227.426561-1-linma@zju.edu.cn> To: Lin Ma Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, amritha.nambiar@intel.com, jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 25 Jul 2023 10:42:27 +0800 you wrote: > The nla_for_each_nested parsing in function mqprio_parse_nlattr() does > not check the length of the nested attribute. This can lead to an > out-of-attribute read and allow a malformed nlattr (e.g., length 0) to > be viewed as 8 byte integer and passed to priv->max_rate/min_rate. > > This patch adds the check based on nla_len() when check the nla_type(), > which ensures that the length of these two attribute must equals > sizeof(u64). > > [...] Here is the summary with links: - [v3] net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64 https://git.kernel.org/netdev/net/c/6c58c8816abb You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html