Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aadee30c-8965-a3c3-c90c-bcdfa6ad143c@tuxon.dev>
Date:   Thu, 27 Jul 2023 08:40:46 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 12/61] mmc: sdhci-of-at91: Convert to platform remove
 callback returning void
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Eugen Hristev <eugen.hristev@collabora.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>
Cc:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230726040041.26267-1-frank.li@vivo.com>
 <20230726040041.26267-12-frank.li@vivo.com>
From:   claudiu beznea <claudiu.beznea@tuxon.dev>
In-Reply-To: <20230726040041.26267-12-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 26.07.2023 06:59, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

> ---
>   drivers/mmc/host/sdhci-of-at91.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index cd0134580a90..af5bc0caf29b 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -443,7 +443,7 @@ static int sdhci_at91_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int sdhci_at91_remove(struct platform_device *pdev)
> +static void sdhci_at91_remove(struct platform_device *pdev)
>   {
>   	struct sdhci_host	*host = platform_get_drvdata(pdev);
>   	struct sdhci_pltfm_host	*pltfm_host = sdhci_priv(host);
> @@ -461,8 +461,6 @@ static int sdhci_at91_remove(struct platform_device *pdev)
>   	clk_disable_unprepare(gck);
>   	clk_disable_unprepare(hclock);
>   	clk_disable_unprepare(mainck);
> -
> -	return 0;
>   }
>   
>   static struct platform_driver sdhci_at91_driver = {
> @@ -473,7 +471,7 @@ static struct platform_driver sdhci_at91_driver = {
>   		.pm	= &sdhci_at91_dev_pm_ops,
>   	},
>   	.probe		= sdhci_at91_probe,
> -	.remove		= sdhci_at91_remove,
> +	.remove_new	= sdhci_at91_remove,
>   };
>   
>   module_platform_driver(sdhci_at91_driver);