Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5ba4efe1-9328-5edc-889b-6e253152cb88@amd.com>
Date:   Thu, 27 Jul 2023 08:25:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v2 26/61] mmc: sdhci-of-arasan: Convert to platform remove
 callback returning void
Content-Language: en-US
To:     Yangtao Li <frank.li@vivo.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
Cc:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230726040041.26267-1-frank.li@vivo.com>
 <20230726040041.26267-26-frank.li@vivo.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230726040041.26267-26-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y01lSUdqdGZIaXhNK1JCVTlFSXNoRjl2eGVvTllwbXB3aG0vbWxJeis3M3p2?=
 =?utf-8?B?YVE5TlJ2dFRPZGhINGhQK1ZjbHFKSXl6eXF6VUREa3lmb3pobmt5aVVJcFVu?=
 =?utf-8?B?NXQ0NVdZWEtmRGo5Y3dlaXp6MUZTT0ZpOERwTXRhR3RhaU1QNW8zbTYvUGpJ?=
 =?utf-8?B?M1puOVNHZVVBL29rL3BjS2hvV3NWVUV6WWVYR2VPS3JJWHB1VWJJNXBCVUUv?=
 =?utf-8?B?ajg5N3hxTWp6UllCR08rT3dWUUZUNHo0UUtSNktSaElXa0FGajFxT0lhSmov?=
 =?utf-8?B?YTNCbFdOWkp1dllWVFlmdHNiRk9JZjNYSDhxUDFFcWwzTjF3SXkyZ1oyL3l5?=
 =?utf-8?B?SllnNlFYL3djdytBb0tHcVAxa01XL2hsbjZPam5XSWVPR0xEemROeSsrcEgz?=
 =?utf-8?B?OGNLNG9iZGhvZ3FUQmZTVndhbnBORjVSZVNaS1NQZStRM2pVcThqYS9qVkxk?=
 =?utf-8?B?dko4NTk4anBsM2dhc0Z3cFBtVTdkQkJxK0F2ayt2MHpYVTVtOWc1Z3RScUpu?=
 =?utf-8?B?Y0NvVVMrZFgxc216a1hXMXYzbFZuRkhqa1FQWkNTbGpnUWo5bk1uQ2NXOGY5?=
 =?utf-8?B?YmVLV1AxbEFNalNFTzFMQmVYWUFNczVOanJXdTF0NHVlUUxkckg4MmdLNHp2?=
 =?utf-8?B?RWEySW44aWxtczlKV0h4Wk1mUkZ0Ry9xOWpnR3Q0ZEkzS2tkY1dmWXRHVjZh?=
 =?utf-8?B?MTZUZnNwdFpWZ2dyM3U2Wm8xVXF6eDFRWG9nUTVTU3U0N0wybndERFN5NXBU?=
 =?utf-8?B?czNodUxIM3lpS1B2YkVreitTYTVoVGlsdEErZGI5WWpOOWdGdE1tRFN1ZUxZ?=
 =?utf-8?B?STU0MFZpWUM5bzBkSVVNSVZXU0YwN3NET21tNkE5WjlmTVA5Rnl2a2psSkhl?=
 =?utf-8?B?ZzBoaUxyZHlOYndESkx6elRuWk0rdS9oTUh5RDYzbVZHUWRJSzFtdStyRXB0?=
 =?utf-8?B?c2YrUEYyWU1MQnB2Yk1weUpyZ2JlTjNBcE5OMCt2bDZyeFRZQXVFaEVWNzdG?=
 =?utf-8?B?UWZheFAzVGxweXRZWXNJUU8vM3ZNNkFGNE9SWnIvSXhMVWtISXlhQVF3VEh4?=
 =?utf-8?B?Y2M2VFROVG9acU5qeDh4WlErUTNXc1pHQWljZzgwVmUyRy9tRm8wTmQ4QXR6?=
 =?utf-8?B?b29TTW5zSURVd1poSG9qR0lsdGxhWEpDb21jcjFRU2xsK1hrSThUaURsL3Zt?=
 =?utf-8?B?RFFEbW9vWC9rN2pCZWpuUkJpejBPRDBmaWJxNzZJNWJTaXk1ZFlJbE45bm9R?=
 =?utf-8?B?Q3Z5TTh2RFZVZU50TWhEMEMrNHBadWk5YjNSQUVFL3I1KzF4WGwvQnJkS0Nj?=
 =?utf-8?B?OXF5elFzVlZNVEwyVU4xQjI3NUtUQ1JSc0UwVzd4MVJUR20wY2FPYjlialNZ?=
 =?utf-8?B?dzNZRlVmV3crbnR5Yzhhd3g5akRCMmRVNkZmeXFKY0tOczFwZkFkR3NEVkpL?=
 =?utf-8?B?cVcvZy9QUk5kZlpqV2Q2ZDNzWDcwREFjUmFXOEh6UHZ3MkdBYUQySXBEUU1O?=
 =?utf-8?B?UXRtRysweldad3I0MUdiZ2ptM3EzM2V6bUNCdTRSTzdNVHBzbW5LVVhiNFFB?=
 =?utf-8?B?VEl3MDhobkVkeU1EUlFXbXE5TUl3cFpaZERoemFPbWhWNTdqY05qR29JMjFG?=
 =?utf-8?B?NkVVVkRlNmxEYTRPQmNBbTJRV1NWZldkcnhMTXhWSTBsaUFScFpOVlJ2VldG?=
 =?utf-8?B?SVk4WUxUdEZocXhtNmhUamNwQWlUd0ZudHFrYXdBdFFRU21jTnZVdnduT0g3?=
 =?utf-8?B?dE1abVNsaFBtRHc1Z0lYUmFUUGRVUGxESUZPTjg4MmwrUTVxMllCeklSRmd0?=
 =?utf-8?B?T3h6RHI1TDZIdFNoRlZVUUpYLzZORDhsSGdiRkFESDBMMUg5Z2tXNmcyY1N1?=
 =?utf-8?B?RFBsWWFpQ0VFMzZtMkszdENURjhDYW1zVDg5S1VOS1RuK0ZmN3lWTXRteUM2?=
 =?utf-8?B?Q2U3Qm16NGVVS2FoVnRMMkZZZGFtWU50dzdXWkpTN2c1c3J0cnNLZkUxYTdG?=
 =?utf-8?B?NEt6RWs1aklzVHZNdnN1L3FEbHczQ0NsUmhNa0Q0UHNtSmJ6cFE5TmFmQjdQ?=
 =?utf-8?B?OGMzb0VYY3NQVE5Fc2ZsR3psUGcvU3A5UnRSVkpKNG5vcjNzWjhEcHMzVFZx?=
 =?utf-8?Q?nV19iCSw63gac2vF85ByXaEOM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b9fd13f-f066-4a10-b21e-08db8e6a56e2
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 06:25:58.0808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +t78qe6XE5jii/293Xgmv6BaU41RsoojWeyLcVm1eVMwdEVL3J2QD9CbKpOWKJPX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5378
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/26/23 06:00, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   drivers/mmc/host/sdhci-of-arasan.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 294dd605fd2b..160bab0c437c 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -2016,7 +2016,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int sdhci_arasan_remove(struct platform_device *pdev)
> +static void sdhci_arasan_remove(struct platform_device *pdev)
>   {
>   	struct sdhci_host *host = platform_get_drvdata(pdev);
>   	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> @@ -2034,8 +2034,6 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
>   	sdhci_pltfm_unregister(pdev);
>   
>   	clk_disable_unprepare(clk_ahb);
> -
> -	return 0;
>   }
>   
>   static struct platform_driver sdhci_arasan_driver = {
> @@ -2046,7 +2044,7 @@ static struct platform_driver sdhci_arasan_driver = {
>   		.pm = &sdhci_arasan_dev_pm_ops,
>   	},
>   	.probe = sdhci_arasan_probe,
> -	.remove = sdhci_arasan_remove,
> +	.remove_new = sdhci_arasan_remove,
>   };
>   
>   module_platform_driver(sdhci_arasan_driver);

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal