Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3 35/62] mmc: sdhci-sprd: Convert to platform remove callback returning void
Date:   Thu, 27 Jul 2023 15:00:24 +0800
Message-Id: <20230727070051.17778-35-frank.li@vivo.com>
In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com>
References: <20230727070051.17778-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWJVRXN0SzNnME0wM3UzVlpNRSswUi9tWUx4NW13aDlieFZlQWNyYm5BSHpp?=
 =?utf-8?B?Y1dmY0IzSlkvT0RQVWs1a1VwQzBWQlV0N0N0RmdGTU5vL2w4d0kxeXY4N204?=
 =?utf-8?B?NzlEQTZTWC8vMEE3a1pBOVRuSFZ5UCtJZjlMUGFUYXl4dkdEMStWY3BBb2hj?=
 =?utf-8?B?UTA4enVrdXhvWXhmRlptK2xHc05DTzJnaGFac1M4cHNFVlp4WkxMaFhkTVlu?=
 =?utf-8?B?OER5TDQxRk5WVUhhVm5kNWhMRkVUZnd0UTZwaHdJUWEycjA0Wi9FMmJaQUFO?=
 =?utf-8?B?M2ZNWWtqM2Z2OFYyNk51cTExTDNIME42MTVQNUpTNFFnb0pyRmhhaUUrbEtC?=
 =?utf-8?B?OEQyTncyYXVoczM4YzJFTHRScFN6dkZKRWNLSkwyR1AzWXhWTm1tSjUzVno2?=
 =?utf-8?B?bWtMTFAyOTVERkpYRGt4d0VXUkRNeGxjbUcxYnRYNndVZ1l6OENEUkJQUTJE?=
 =?utf-8?B?dm52UFZ0ckhmTml6ZEdIdy9ia0hrZlVJeTAwZlp4Zko2cXlFbXV3S0VyRCtD?=
 =?utf-8?B?bklEc2lWb1krd3JjdXdUWkk0WUl1MXZmdjlIWDNRS1FZaFViMHk1elV6cHpT?=
 =?utf-8?B?UHhWMjJUMXRaaGV4K2lrRW4ySGxHTmk3M1VlOGV6NzVoR2lsNDFuYmxTNnNT?=
 =?utf-8?B?VS9CL3NJS1Q1eENjYytVdUNxQlM3UWV6NCt4VEtFczkyc2FnbHJQSzlpVFRM?=
 =?utf-8?B?RVl6d0Vmc2phaUF6ZmJsSzl3OS9EeHlkWUNNYUlmOE4yblUxNnkvTGtYZWRF?=
 =?utf-8?B?bWcwYXZraUpzeW1obm5JUzlDbWNkYVRYQm9pVWRZV3lWZFhNQTlZRFozdy9W?=
 =?utf-8?B?V3R6dzZYWEgwRnNvV3dzYVBZS3FEMjV4a011ZzNIR3BoOWVPTC90cm9FWE1Z?=
 =?utf-8?B?WStWREJKb0N5cElzeWpqeWJzK0xPUDJDNlpCY0F6bVdkRjBGSGFPSFhnRlV6?=
 =?utf-8?B?dTNpQXR2eE1pd0hNdXJPMkNhZ29OckdhRFVXcHYxZlhrNVlJK1lld2RRMklD?=
 =?utf-8?B?ZWVhR1N6a3hhMkQvYUt4MHVyOW1PajBOZFB1RjBTbzdRTVQxU2xRbVNxZ0pS?=
 =?utf-8?B?Vm9rQ1pEOXhLSnluUHMyN3V0bnRyK2RnSWNsR210OVdQeFdMWVo5Um9OdUo2?=
 =?utf-8?B?Vk9oOERpbXpZR1BsVkpRVThZZjhkTUV2d2k5VWI0cVU4RTRibzB6Q3BTZUUw?=
 =?utf-8?B?L0dxK01oSzRmdlZ5eWNqQUZ6bjZxZlo3dERTMTdHWlFyUVcvOTZMWHI0SlRY?=
 =?utf-8?B?WUlHRDVPOTJwUHluUFE0VVlYK2dWM0FrVVVKTGNtZzBDcXZjcHFvc2Z0ZXNO?=
 =?utf-8?B?S1ZnWE40UjVndnVDRW5DemlTc3pycW50VlpkbU92S0ltdkhDMFVGS3BlUGth?=
 =?utf-8?B?L2dBQm1teCtsb2lXSTZ4ajBGdXBOV0k1M0R2NVZWVDRGMDNHbklKSjhWT0Z0?=
 =?utf-8?B?MWpKa3J1ZC85YzlkOUJZUlBsZEt6RUppWllYKys4dktoZ0J6ZWpibVNuc2Fl?=
 =?utf-8?B?Tmtzc0FkNk9IalU4TStscHlKclNRYVhOOEgyWGczZmI3TlhtMDJ6Z1dCSFk3?=
 =?utf-8?B?ZVBMUnBrUzlpc0swYkJLTmdvaDJ5NEE2RVc1MC9KSVg3VUgzUlAzWEczUHJK?=
 =?utf-8?B?U0djYkpIVXVYdm9Wa3RLcDZwMVNLM0tTdk5nZE1Sb2VLZUNEa1lLbFltOE5L?=
 =?utf-8?B?VnkzVEx6QnF4UlpISzV5NnBOUzZaT2Q4OHdiaS9CREpSOUxTd29NS1VvcFEz?=
 =?utf-8?B?U2k3YlRVWnVoc2VjQWRQOWtST05ESGhrODRjZDVDczZpVmFUZ09tbnhwcXZM?=
 =?utf-8?B?N0krZnBISXNidyt2N1c3cEVNL2hiOWZBOVZLZS9tNWIveHV3QXJTTTgxeVZP?=
 =?utf-8?B?eDRicjNyclZTU28xU01KQTdPR1pLWFhRcXhwWkwzNjNkQXllNmRBQytVUXNw?=
 =?utf-8?B?d1gvWXJmNUUrNzdaTVlFYjN5aWFtT0tTQWE4LytZWm4rZ21OVWg5cjArd1hB?=
 =?utf-8?B?VktSQTd1czF3RVNWeHNrblBWU3FKWUFSaFpWS09RSjU0L01DWFlWcUpnTGZ4?=
 =?utf-8?B?UGViK2ZITTlqeTU0MDNxM0FHaG1EbGpNMXg5MXpaSmVBSnMxTDBnKzNzd21U?=
 =?utf-8?Q?yBH57JlyHwabVFruRcGAXKxk8?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 871047a0-c260-4daf-211a-08db8e6f6037
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:01.1150
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OBEGAPt8I4uNL20YaK2TfZNDPiFCmCC0yASEpV5MxDsQL1q5nU+01XTZpNk9lxIQ9Ppkm0Qzzwh5ipJr8DQpYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
---
 drivers/mmc/host/sdhci-sprd.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
index 7f4ee2e12735..379cb3892757 100644
--- a/drivers/mmc/host/sdhci-sprd.c
+++ b/drivers/mmc/host/sdhci-sprd.c
@@ -720,7 +720,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int sdhci_sprd_remove(struct platform_device *pdev)
+static void sdhci_sprd_remove(struct platform_device *pdev)
 {
 	struct sdhci_host *host = platform_get_drvdata(pdev);
 	struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host);
@@ -732,8 +732,6 @@ static int sdhci_sprd_remove(struct platform_device *pdev)
 	clk_disable_unprepare(sprd_host->clk_2x_enable);
 
 	sdhci_pltfm_free(pdev);
-
-	return 0;
 }
 
 static const struct of_device_id sdhci_sprd_of_match[] = {
@@ -800,7 +798,7 @@ static const struct dev_pm_ops sdhci_sprd_pm_ops = {
 
 static struct platform_driver sdhci_sprd_driver = {
 	.probe = sdhci_sprd_probe,
-	.remove = sdhci_sprd_remove,
+	.remove_new = sdhci_sprd_remove,
 	.driver = {
 		.name = "sdhci_sprd_r11",
 		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
-- 
2.39.0