Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3 16/62] mmc: rtsx_pci: Drop if block with always false condition
Date:   Thu, 27 Jul 2023 15:00:05 +0800
Message-Id: <20230727070051.17778-16-frank.li@vivo.com>
In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com>
References: <20230727070051.17778-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGRYU1dvYUR6bFlKL2dXdHI4VWwvcFBxSGNUWGxQTTNFYTA5amNpVUs2dzdo?=
 =?utf-8?B?MEljK0JtQkRhQ050Z3R4YXFKM1pzR2NMWWE2enVoY1BNaXkzZjVWRXZXUW0w?=
 =?utf-8?B?b0JlVFNZM3doWnQydEZaZ2ZFOFgvUUtUZjJ4YUVHRFd6MHZLQmR6ck1QVDh3?=
 =?utf-8?B?VEQxNjc4Yno2WDFCUUF6RW1Ma1ZYdEJEcityRWc1Y0JUaEdlTEtOaTl0Z3N5?=
 =?utf-8?B?ejU0a3E5ODE3UXBkSDZMb2ZFN3hzaVArMWJuOFg1cE5jRWQxYm5aWkd6NXdY?=
 =?utf-8?B?WEZCcmFSaVdBSXVxbTg3NzRwWFFFVG95ZGtXVUhjSEF1MzBING8ram9veEM4?=
 =?utf-8?B?VEhzSEJ0TFhKNUVvdEF5cDNWNGFTWGdLYTNFdlNtQllYNitINGRicE9hODRG?=
 =?utf-8?B?TlVRVlZHbWowV0x0dTZUSE5YaTlmTlFlRmV0ZElMRHpabld5cW9xM216MjJy?=
 =?utf-8?B?czRQeTEySXVBQkxIU0wwK2lOdmQ2eGpaYUhBcE9UeGRTN3U3bTc0eXZway9r?=
 =?utf-8?B?QkNwd1A1eHQreFZSZnVpUjhZQVpQSjZIUVZHTUh3ZzBrMmM5YjI5b1pTajcy?=
 =?utf-8?B?Qm1DQUNVMDRRNHYzY1FDcVFtV1lUR1ZBa0FpSDByNVZhTGlRTVhlaSt0RmNO?=
 =?utf-8?B?UnJ3ODM0U05hcW5vbHN2NzQrSnJUOHZjRXNMSnpXSXErVnF0dWk4M3ZLR2wz?=
 =?utf-8?B?dUw3K0VBSXQyL3VlazJTc0JjVFR0cyswckpUK1JoTXo4Si9PNmV3NlFtUFdO?=
 =?utf-8?B?Z2VGT1d3bnRycUhTNWNFNmNGaExaMFV3OXdOUWJNMFZIUG9KSUF5Yk9WYXcv?=
 =?utf-8?B?VDJSWW92dlVnekJPeUtrR0J0ZkpPbk9RT2xGQStuWkk1Q3VUdnJTajd6NWhY?=
 =?utf-8?B?anNMeDVMcFpXcWcyOXN3UGJzVEpRRy9RVlZkRGJBU2l4SEVTdEVkQ0pzYnps?=
 =?utf-8?B?aHp3MlhWVTVDbHpOOGorRS9ycmlmSmIxSmcxMlR5WklxbnlENG5La2tmVlZH?=
 =?utf-8?B?cm5rWklBdStBemVDWjVnYjVKNkMvRVVLMkdkbTBueTdReU9lTDRORU9xQlJp?=
 =?utf-8?B?Q20yRXU0VHBvYVl1ekZoc0U5NDFjSWc5OEloUmQ3aUZvb0M1VU0zeVZhTnhI?=
 =?utf-8?B?cVEzMUNRaTJqcmlvMXkyMzg1UzBvdTQ3ZlE4NW5YNUJDYy9Cd0lJN1lKazZL?=
 =?utf-8?B?WXBTTnlUNHRpNUlNaGVlQ3JWdnBWWkQ2MGFseEI5dU0xS25zY0xsYzNYcGtE?=
 =?utf-8?B?RUx6aHJDVDYrM2lUZFBsMGlCNktKNm5PbGRHSUJzcmtOTGQ1V285dThPVXBT?=
 =?utf-8?B?Ull4cDlmUGd1eUllci9URVZZa0xwVTVDRHMvZUNGcS9INHYrcE1nV29SdHc2?=
 =?utf-8?B?ZHlxL3dPamU1VnROMEpoVlVyWW04ZmxBMnlhNzcrcXY3Wm43a3JQdmhBZkZr?=
 =?utf-8?B?dlBTVzBieTRIdDJRUjQ0cUtxaVdwQlczVm5FUkNPRUhnOTdpY0hhTlowNW1W?=
 =?utf-8?B?Tm00Y3F6RDRFdmpuTjdFRE4zdG1OYWI3SkNvaTNJbGY2MXhVVytjd3lRWWVK?=
 =?utf-8?B?VFdlU1VleFBkUnlxazJkZDlxSTZyRjdGM3E4T09qMGVJYWNrK2xCMzFmVVpX?=
 =?utf-8?B?MmtDUTI0VGFpUmJvU05YNEhNQ0dMZTVzTzBEdFhzejhlU0dxK1pXdW92NHdQ?=
 =?utf-8?B?Vk1MTWRiWUZpRDl3RWpiN2hRdE1XWXloMWoxYVJpK3Bld1lQYktkWlFsN0dJ?=
 =?utf-8?B?UkE1Ykw1eHRnU1B2Z01oUmxPelpJSUtkTHJ1Rmk0OXNDL2JuUkwrT3lCeWNQ?=
 =?utf-8?B?VU1wWjgraHYyTkFiZVdhM1VzeFZYa1FZcGRZbndyTFNPd1ZLeTd4WkRpclpm?=
 =?utf-8?B?ZXMyZDBMN05RSmRyM1JCZmFqZWJkNTJYRlUrdnNMNUNkZEJGN0dXNE5GbEwz?=
 =?utf-8?B?S09mdHBCOW5wL0NaSHFnK1I1cXc5UFVPWVZqRTZmc0poUEdVR1grSXNzSXVu?=
 =?utf-8?B?Umd5cTBsOUJjVFlMenFNYTI2TmJrSmVmK3NmTll1T0pZOGY5QWRYd2s4c2gz?=
 =?utf-8?B?eHpBQWpxR2VhdHg4c2JSQkdpQ2ppZEkwYXRxdnk4L25ma2VzS1d2Y0hRV29r?=
 =?utf-8?Q?xGZ/ZAT95UKra7qxU94CP5RC5?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7259d54-83dd-4c10-6941-08db8e6f4ccf
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:28.6381
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KKfHT+FjtTmjdswbMF4cXnEKhzoOYhaIqZdJM2OnpBjq3wTQ9e8bnEu0SDP+Pw/zVeRw4LtzQd6dBX61hhbFqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

rtsx_pci_sdmmc_drv_remove() is only called for a device after
rtsx_pci_sdmmc_drv_probe() returned 0. In that case platform_set_drvdata()
was called with a non-NULL value and so platform_get_drvdata()
won't return NULL.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/mmc/host/rtsx_pci_sdmmc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
index 8098726dcc0b..062d07c2ae5e 100644
--- a/drivers/mmc/host/rtsx_pci_sdmmc.c
+++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
@@ -1529,9 +1529,6 @@ static int rtsx_pci_sdmmc_drv_remove(struct platform_device *pdev)
 	struct rtsx_pcr *pcr;
 	struct mmc_host *mmc;
 
-	if (!host)
-		return 0;
-
 	pcr = host->pcr;
 	pcr->slots[RTSX_SD_CARD].p_dev = NULL;
 	pcr->slots[RTSX_SD_CARD].card_event = NULL;
-- 
2.39.0