Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc:     Yangtao Li <frank.li@vivo.com>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3 62/62] mmc: f-sdh30: fix order of function calls in sdhci_f_sdh30_remove
Date:   Thu, 27 Jul 2023 15:00:51 +0800
Message-Id: <20230727070051.17778-62-frank.li@vivo.com>
In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com>
References: <20230727070051.17778-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dENRUStTeTFSRGl4YUljM250VkF0am11eDJ0T09YZkZKc01Yclc4UDZxWWJ1?=
 =?utf-8?B?QzJaQ0Q2dGhaMGFXQUlhdmpSY2NaVnd4WEJLcTArM3FuVGx4dDFndS9GYW5S?=
 =?utf-8?B?VVJrYUI3TzBScm5MdnFoWm12bEdpbHpYOThPSGlSZnl3a3VsQXJzQUd6VGJn?=
 =?utf-8?B?SkRVU3FVd2NyK1J3VjVIUTRhTWVCNVQ5QUdYckNwYUN5V3FQMk9iVE1jcDAv?=
 =?utf-8?B?ZHBqOGtWalBsRktlNk0vYnU0R2ZiU2oxL1lmdWU0Mk1nMzQvc0hmVnp0UzRo?=
 =?utf-8?B?VkRrZ2dkWGI2SEhaQ25UbkR6N0tHSUlUSk9tU2pKNm9ySGlKenUvcFgxVXB1?=
 =?utf-8?B?Ni9zYk1wK3g3NjdqTmF6TjAvWWNXclB5VHBYeFl0UUc4d1FuN1ZnMGl1MzFa?=
 =?utf-8?B?cGtYWkZNR0ttMWtlODBENGxyQlBGTi9MdFlueFJCNnFwODR6empLU0hNdkFn?=
 =?utf-8?B?RElkY1dLYzIrOWFsUUdPVlB3cjVxOHlRNmZMdklvU3BUZnd2UEZHNkdDOXdT?=
 =?utf-8?B?T0pJSVorck9BTkl5T1NYMW01QmY0RHJJR08wWFlZbmtJaEpzTkhubzY3VnZV?=
 =?utf-8?B?enMrSzJDaWNnLzR1Qk1zYVBaL2RudTRXTGNWTGlacjRPMFp4MjRMMVh3NWJI?=
 =?utf-8?B?ekRIZHZRbEhZKzA2UFFRMVFTZzZ0dVIrWUl1SjR2bHFaR0ZzQ1hJL0pzRWNV?=
 =?utf-8?B?eDVPU0pucS8wUWxRakd2eGUvWlFvb3o5MkRDaktSeFFjREM3ZWIyeVlzUGt0?=
 =?utf-8?B?dWZaV1Fmb2RkaFdJVHJyVENxN1BsYWd5QmlmVkRUNVQ3d0pVbUpLNGg5Tm1h?=
 =?utf-8?B?L1RTY3UwbThlMlJuM1M3VDRKM0JPbkJKQmpsSmVaSWVIUExmU3VIWmY5WGVI?=
 =?utf-8?B?SENQcXNhMitYRUI4eW9pdXhGQVRudHBJQ3pUTjk0WjIrcExlQW4rZHdCZWVw?=
 =?utf-8?B?ZGJOWXlYNy9hNzlhOHlDd1JMQkYvMmlmTWV6eWEzSnE1WUNtNXJUam15YmxG?=
 =?utf-8?B?NXJINnNIMlR3NS9BelJueHc0TnoyUDB1Z0haa21OQ3JDR1RwanNkSmRTZVg1?=
 =?utf-8?B?dTFZaWZESTNPR1Y5UG52bzJEaWw5Rkt0NDdpRjh6RUtQMmVsbnRTNUJBU0FU?=
 =?utf-8?B?TnBmajFoRVcrSkZBcGtFWm9sZDdUMWJXbnNCWThGRUJtVXRQSktvUm5vbStk?=
 =?utf-8?B?YnF5MWlzZ01hR3FKRVd6SnZYTjN1Rk50UUNyc2dsYlI4djVwa05DeG9CSlVv?=
 =?utf-8?B?OG9Sam0yMmExRkE0am9GWDNHVnBWb1k4dDFTdnhkQzNkMjhydHRrdHhjSW9W?=
 =?utf-8?B?NEhlTCtHTU5CUHh2TXUvWDNCM2s1OE4xbEtOdTdheCtESVhOR3RSbGhiY0E4?=
 =?utf-8?B?YVcwMHcyTndxVCt5eDM3QzJhRFRpVTI4ZkF3dkovY21qRFZTR0dSL2lIRWNH?=
 =?utf-8?B?cE11MDA1ZUpEM2FoQzcrWXR6TDNmSlN4RllVait2SERRS1FCVitXYVBqbUFJ?=
 =?utf-8?B?YkNRVUJuTHJhK3ZDVksrdW9WVmR3ZEIrOTFLSkNmbDh4Tit6OTZScHhhMldU?=
 =?utf-8?B?Y2JySGRXck9WZENoZ0ZFdlQ1R0l6Z0Y4bzVLalEzZGxLUmdIVVFyK3Nkb0ZU?=
 =?utf-8?B?Uy9sN081SkNpTGV4ZmpDVFZ2bzVQT002a2pOY0UzS2YwUmRIamZMUytuUnp0?=
 =?utf-8?B?M3BTMFprSGtwcThuM1JDQkFYZUtqNzJZL3pYN25LdjA1VWZOOGhXMkwwOU5E?=
 =?utf-8?B?b2dwbHI3aGR5UUY2M0dHUmJOR3FWV2xTc2FZcm9LcVNuNVBYZ3pCcGpFTGh4?=
 =?utf-8?B?ZjY0bXlMc01BQlJ5NEhYWS94Wk1WbElJOGV6cjVHMTRoVU5WbWZpZVp4a0pj?=
 =?utf-8?B?bFRKVUpkb3JYZUpFbWpDMmlXR2RySVd0K1V5dkJlTzJ6WVRQZnhzd2ZWZE1i?=
 =?utf-8?B?Q24xM0FxdjE4RTJZRmxKcWYyMWx6SEIzYjVlUWtVZGdDWmhCMGw2QWt0elFP?=
 =?utf-8?B?SVA4SElMM3VBUnh4STVlbDNSQ2tyWFgxZGFZZCt0bGlWdHBiTHJjOGovV2Qx?=
 =?utf-8?B?YlpxMXRMUFNSSC94UDdQeTRzTVBsbURJcXBMcG1rY21VZXNlLzRWaU5obEFp?=
 =?utf-8?Q?ujqyfrHdRVHUAQwk7XTKBULpy?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81d192c5-ce8a-4ac0-694c-08db8e6f7c58
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:48.4011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VWLAaOhm8nGABZ0wbkrbPqU21xQYZYZXWw/NbE1KScX8sl3XAHbBRpGaYyax5J0SJ6btho9y01iOzWnhHqbwEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4152
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The order of function calls in sdhci_f_sdh30_remove is wrong,
let's call sdhci_pltfm_unregister first.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 5def5c1c15bf ("mmc: sdhci-f-sdh30: Replace with sdhci_pltfm")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/mmc/host/sdhci_f_sdh30.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c
index 840084ee72e6..964fa18a61a4 100644
--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -211,11 +211,11 @@ static void sdhci_f_sdh30_remove(struct platform_device *pdev)
 	struct sdhci_host *host = platform_get_drvdata(pdev);
 	struct f_sdhost_priv *priv = sdhci_f_sdhost_priv(host);
 
+	sdhci_pltfm_unregister(pdev);
+
 	reset_control_assert(priv->rst);
 	clk_disable_unprepare(priv->clk);
 	clk_disable_unprepare(priv->clk_iface);
-
-	sdhci_pltfm_unregister(pdev);
 }
 
 #ifdef CONFIG_OF
-- 
2.39.0