Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <faf8d723-afb8-ac4e-7861-4004bb78c5a9@arm.com>
Date:   Thu, 27 Jul 2023 08:26:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH v3 2/3] mm: Implement folio_remove_rmap_range()
To:     Matthew Wilcox <willy@infradead.org>,
        "Huang, Ying" <ying.huang@intel.com>
Cc:     Yu Zhao <yuzhao@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yin Fengwei <fengwei.yin@intel.com>,
        David Hildenbrand <david@redhat.com>,
        Yang Shi <shy828301@gmail.com>, Zi Yan <ziy@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20230720112955.643283-1-ryan.roberts@arm.com>
 <20230720112955.643283-3-ryan.roberts@arm.com>
 <CAOUHufamqn0b8tN1DppfPi7FRnENzYwcSOVcAKNxkj=CYa+OwQ@mail.gmail.com>
 <ZMFNgmlT1JpI0z5+@casper.infradead.org>
 <87r0ouw39n.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZMHX+O0wmjuPXdTi@casper.infradead.org>
From:   Ryan Roberts <ryan.roberts@arm.com>
In-Reply-To: <ZMHX+O0wmjuPXdTi@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/07/2023 03:35, Matthew Wilcox wrote:
> On Thu, Jul 27, 2023 at 09:29:24AM +0800, Huang, Ying wrote:
>> Matthew Wilcox <willy@infradead.org> writes:
>>> I think that can make sense.  Because we limit to a single page table,
>>> specifying 'nr = 1 << PMD_ORDER' is the same as 'compound = true'.
>>> Just make it folio, page, nr, vma.  I'd actually prefer it as (vma,
>>> folio, page, nr), but that isn't the convention we've had in rmap up
>>> until now.
>>
>> IIUC, even if 'nr = 1 << PMD_ORDER', we may remove one PMD 'compound'
>> mapping, or 'nr' PTE mapping.  So, we will still need 'compound' (or
>> some better name) as parameter.
> 
> Oh, this is removing ... so you're concerned with the case where we've
> split the PMD into PTEs, but all the PTEs are still present in a single
> page table?  OK, I don't have a good answer to that.  Maybe that torpedoes
> the whole idea; I'll think about it.

This is exactly why I think the approach I've already taken is the correct one;
a 'range' makes no sense when you are dealing with 'compound' pages because you
are accounting the entire folio. So surely its better to reflect that by only
accounting small pages in the range version of the API.