Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230727101128.2752153-1-ruanjinjie@huawei.com>
In-Reply-To: <20230727101128.2752153-1-ruanjinjie@huawei.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Thu, 27 Jul 2023 09:33:26 +0200
Message-ID: <CAMuHMdXhBx5e=EH731NxcKWajFniDHtCATpjZzM-UvOrKfJwQg@mail.gmail.com>
Subject: Re: [PATCH -next] media: rcar_jpu: Remove redundant dev_err()
To:     Ruan Jinjie <ruanjinjie@huawei.com>
Cc:     mikhail.ulyanov@cogentembedded.com, mchehab@kernel.org,
        linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Jul 27, 2023 at 4:37 AM Ruan Jinjie <ruanjinjie@huawei.com> wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds