Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Somisetty, Pranavi" <pranavi.somisetty@amd.com>
To:     Rob Herring <robh@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "Simek, Michal" <michal.simek@amd.com>,
        "Katakam, Harini" <harini.katakam@amd.com>,
        "git (AMD-Xilinx)" <git@amd.com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert to json
 schema
Thread-Topic: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert to json
 schema
Thread-Index: AQHZugjScH8iKU5N9kWTSvwBM7ERX6/BZ8YAgAd/OlCABGBVUA==
Date:   Thu, 27 Jul 2023 07:51:09 +0000
Message-ID: <BN8PR12MB285265974F825587DFAD1748F701A@BN8PR12MB2852.namprd12.prod.outlook.com>
References: <20230719061808.30967-1-pranavi.somisetty@amd.com>
 <20230719182206.GA537052-robh@kernel.org>
 <BN8PR12MB2852E09191C6AB6DBF7EF33AF702A@BN8PR12MB2852.namprd12.prod.outlook.com>
In-Reply-To: <BN8PR12MB2852E09191C6AB6DBF7EF33AF702A@BN8PR12MB2852.namprd12.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bXfliAjmzDwYMNLAP1k+9LDp5Ac3xYiFYUloYE/WiXTlET0Zb30U/m5IAAht?=
 =?us-ascii?Q?I/6uYcWyUzadSQwfjEOtu0nMu8P5IAxXLH+9YzbpNYB4KMiFedkI8F5hvPUC?=
 =?us-ascii?Q?QH7gXnC3jbU5gYGnW2cZc3Pq0YBDfcbf2YLOWvx6y93Sg7ojBHoX/g9a/FBE?=
 =?us-ascii?Q?zFVLuI5WlXpb8Gp0LVCX2fJI2xF7FzU3bj8ROvcCycjglN+1aAvKE7kSIa3I?=
 =?us-ascii?Q?A6d6sSqnsZFolO3aEARdD2XSH4FjLiijehSs/L0R6fdGZB+/IXzW/Pu1bk+I?=
 =?us-ascii?Q?X7a4An02JAaURCULeE2aA/9vIMNNdrh5B8T31x61mQefA6fUHlzNeG0vDOI3?=
 =?us-ascii?Q?0U4edbHe6UyhTi9MzMQlLWch4KnKp9AA0EvN563qk915Mp6yMks7qbbSvwjk?=
 =?us-ascii?Q?25aF5e8iOS0PDpF3NoXM9PeJOnzxMG9jSLzPTXTdl6LbN7Ap9AcA9Aw5cm4f?=
 =?us-ascii?Q?sXnCotQ79+/oMG8w98f9pGt9eM7sfU7s/8hEnZ4vZC2b8be0SeelI7B9AiuG?=
 =?us-ascii?Q?VFddqavUPaIWvw/0eCtlbMoP4uuwiai0wy7SiXKvHw5c6NXzdYzdOJKuMogx?=
 =?us-ascii?Q?8J3MqnEDGXslj4xJdyP6T6Y2gmuLT4JjSylboKRyT4r90txWBinT/tULVhi/?=
 =?us-ascii?Q?gbydmu3qBkmSXf3Oqr+vM4xFaDLGcBRLUat/9sE9EG8ZKVrXlJ0CrRAtO1b3?=
 =?us-ascii?Q?z/aAiRv+M9L0tZpkh5JoTJFr4Eyd1gsR0qjlmQ/FRI0KIvM/3f9Hv14BeIio?=
 =?us-ascii?Q?h8o9RlmWUvBzHCFy6Siq51tQRrZn9Aiv9HgEndwC0X2bWk7pqUEZM5VCsaI2?=
 =?us-ascii?Q?xbrgBTN5VQlwj+j3Y3iebRP+HUsQXj/S4BYO2gJB/553oteaZtLCQhtkUqYl?=
 =?us-ascii?Q?QNy0pfmGQW5MGbc1gn3WAW3vhtF1btfDWhbOAZI3U2X+91wPMEHJPfxgeEDJ?=
 =?us-ascii?Q?axfvJ8G4d0BIjzlnzCf3eo+ShD+8WM8Ckicc9hUmq0iwVYTZetLPe9MPIo0W?=
 =?us-ascii?Q?ReSl8FNBkWNFvfONlM153wY1IApVPU66E1G6CovLNClyAp/oSwMRhsXbZKjH?=
 =?us-ascii?Q?NfpJBKPFw7Wh7xCgZv8C1cw5XLwSY9hXrVfP35mONh4qNN/1sO1oUPrFwrvv?=
 =?us-ascii?Q?vLWXJtyww+CRo6feuhOfzx5sFhfC3SmSnpUPx2bcYe3cZAUyMtOgK/WW7G4F?=
 =?us-ascii?Q?FwcTuIpkbgBysdFJYt1xqoOtVs/VKBFBdG2QcdhJjOzh/BWVQP2Z3ZPLRSu9?=
 =?us-ascii?Q?d5xJqlnVvFGgsjJtZMkVg9GHJ4gxKwFUzIWNY62KzXwNR32waF90pXdMq6Fh?=
 =?us-ascii?Q?6CGtCXXBSoSfGeksY4ahkYsykq/3QCtGtOFFcXCZK0y8KPiqncpMuJXaoz3Z?=
 =?us-ascii?Q?/d6eB1Pucuo7LzfJpCFYHvxf2uLPadLQGPnUmPVg7LU9LxbPxNgxgRH/lfqe?=
 =?us-ascii?Q?R3xNSeTK0CTatP8rKTPLb6+mlQVxDbez81Bxk2h2CUGRi6J/u+dxwMPz0zwm?=
 =?us-ascii?Q?KCk74KEqvCzgWHAfoDG4e2EXaUuL3bE4itWUGsHsANuxzK0ib8nRAqCP5ac0?=
 =?us-ascii?Q?L8fUTTX4+s7DkKOOZ4I=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2852.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b85615cd-ba07-4528-be0d-08db8e763de4
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2023 07:51:09.8376
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mGI2KnQxkEodLXT3OL6S1D4j1qAYK03B+gUWFi7WWLLKxBwzAGlzsHbKLXDDHdz1/3WG3xjqWaT8yLGyWXY9zQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9232
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Somisetty, Pranavi <pranavi.somisetty@amd.com>
> Sent: Monday, July 24, 2023 6:47 PM
> To: Rob Herring <robh@kernel.org>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; Simek, Michal
> <michal.simek@amd.com>; Katakam, Harini <harini.katakam@amd.com>;
> git (AMD-Xilinx) <git@amd.com>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@amd.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: RE: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert to j=
son
> schema
>=20
>=20
>=20
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Wednesday, July 19, 2023 11:52 PM
> > To: Somisetty, Pranavi <pranavi.somisetty@amd.com>
> > Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> > krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; Simek, Michal
> > <michal.simek@amd.com>; Katakam, Harini <harini.katakam@amd.com>;
> git
> > (AMD-Xilinx) <git@amd.com>; Pandey, Radhey Shyam
> > <radhey.shyam.pandey@amd.com>; netdev@vger.kernel.org; linux-
> > kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org
> > Subject: Re: [PATCH v2] dt-bindings: net: xilinx_gmii2rgmii: Convert
> > to json schema
> >
<snip>

> > > +
> > > +  phy-handle:
> > > +    $ref: ethernet-controller.yaml#/properties/phy-handle
> >
> > Don't reference individual properties like this. Instead add a $ref at
> > the top level to just "ethernet-controller.yaml#". Since this is the
> > only property you want from there, put a 'phy-handle: true' here and
> > use additionalProperties instead of unevaluatedProperties below.
> >
>=20
> Adding a top level $ref to ethernet-controller, implies, DT for gmii2rgmi=
i,
> follows the schema in ethernet-controller.yaml. This is incorrect since
> gmii2rgmii IP isn't an ethernet controller.
> I'm not sure how to reference ethernet-controller.yaml from this schema.
> Would it be okay to add a description to the phy-handle property instead =
of
> referencing the description in ethernet-controller.yaml?
>=20
> Regards
> Pranavi

Just FYI, when I add a $ref pointing to ethernet-controller.yaml, this is t=
he error I'm seeing: Documentation/devicetree/bindings/net/xlnx,gmii-to-rgm=
ii.example.dtb: gmiitorgmii@8: $nodename:0: 'gmiitorgmii@8' does not match =
'^ethernet(@.*)?$'

Regards,
Pranavi
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - phy-handle
> > > +
> > > +unevaluatedProperties: false
> > > +
> > > +examples:
> > > +  - |
> > > +    mdio {
> > > +        #address-cells =3D <1>;
> > > +        #size-cells =3D <0>;
> > > +        phy: ethernet-phy@0 {
> > > +            reg =3D <0>;
> > > +        };
> > > +        gmiitorgmii@8 {
> > > +            compatible =3D "xlnx,gmii-to-rgmii-1.0";
> > > +            reg =3D <8>;
> > > +            phy-handle =3D <&phy>;
> > > +        };
> > > +    };
> > > --
> > > 2.36.1
> > >