Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp2066757rwb; Thu, 27 Jul 2023 01:13:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAiGq3WJMynTA/WheMxDbIsHssyIclu3IHLJxVsKjm4cbcxGKOf1DSMJMx4CgfsWza63mZ X-Received: by 2002:aa7:d394:0:b0:51e:22dd:5e90 with SMTP id x20-20020aa7d394000000b0051e22dd5e90mr1039461edq.4.1690445585015; Thu, 27 Jul 2023 01:13:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690445585; cv=none; d=google.com; s=arc-20160816; b=imAQnMVqLS5Oz3ObHy5jeQsNGFYb7iJ7jGQ5WgsitiTHLZrtysDjJZjGXwK8Gyb6T3 Ir2SzC8APinqFtlHocMYFclJHhlFPunkMI4oPYjG3IacRwZSjlmGYm10l2kRuLBosdkp Q0us5zcOxXnO/FfOREk4sxqztxcLPQwDt/rszdVD69FKhfUW6b4+bYy9pmGo5ptOVkn6 84DyjBJ46oaN/s1UWvmYCIMcvSR8pnA4AYOaxIwPuNLrRmFSPgJfHoqldIQIBcZ184or LVnGTHnETDQ9RndIYKE8hcA5SHt2B1pVAp4BX5tZ0xbFFfmSPZ/iUnm23+MyMZRRtC5Z 1dgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=hNwF16CFI9yuaqMJoqAx4qFyUTBglaoquzgZTpg4vP8=; fh=wQvn2OcmPKyVJbSvqs+mjezfqYiGwvYgn0UJExQdOq4=; b=JmWJTegzb+V05eALobmBy0GSwUYqC6am+rxQ0Q6hSaJjmwczWUoyHbvi+3bXtZe8Mx ymYpUFznBkDltfCxCSbeC+RrRsvC/vAW+E18avbJhwn0pBdJY9FM6biSjJGY/A02iS6V wphGQabpO9ycpDcyOg+lhkZDutdxfDVti7RQZRX+U7dE4N7ZRLx1VCjFq01dzszaNMl9 l6bfEaM03JZiXT8TfGj+yVkYR08z+SxGlx8qM6T7V1XV8wNzrXF+/cb2be+YUlpihVvV Cw543BUZzjW3b4mJHW7iYWWU9h8fWwPtUrUDben81Ll/sxPVcBcnc669h33n//vV/yl2 ezPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020aa7c647000000b0051e2295e54csi603273edr.392.2023.07.27.01.12.40; Thu, 27 Jul 2023 01:13:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231320AbjG0HoO (ORCPT + 99 others); Thu, 27 Jul 2023 03:44:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233476AbjG0HnA (ORCPT ); Thu, 27 Jul 2023 03:43:00 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B75883D0 for ; Thu, 27 Jul 2023 00:36:55 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOvYB-0002P7-JL; Thu, 27 Jul 2023 09:36:43 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qOvYA-002QP2-2r; Thu, 27 Jul 2023 09:36:42 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qOvY9-0088t7-6v; Thu, 27 Jul 2023 09:36:41 +0200 Date: Thu, 27 Jul 2023 09:36:41 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Yangtao Li Cc: Adrian Hunter , Ulf Hansson , Kunihiko Hayashi , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 62/62] mmc: f-sdh30: fix order of function calls in sdhci_f_sdh30_remove Message-ID: <20230727073641.kpwnnu3aywa56ip2@pengutronix.de> References: <20230727070051.17778-1-frank.li@vivo.com> <20230727070051.17778-62-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5xi4w3mp2vov7xmn" Content-Disposition: inline In-Reply-To: <20230727070051.17778-62-frank.li@vivo.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5xi4w3mp2vov7xmn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 27, 2023 at 03:00:51PM +0800, Yangtao Li wrote: > The order of function calls in sdhci_f_sdh30_remove is wrong, > let's call sdhci_pltfm_unregister first. >=20 > Cc: Uwe Kleine-K=F6nig > Fixes: 5def5c1c15bf ("mmc: sdhci-f-sdh30: Replace with sdhci_pltfm") > Signed-off-by: Yangtao Li Reported-by: Uwe Kleine-K=F6nig Acked-by: Uwe Kleine-K=F6nig A cover letter summarizing the changes in this v3 compared to v2 would be nice. Also mentioning the base for this patch set would simplify things a bit. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --5xi4w3mp2vov7xmn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmTCHogACgkQj4D7WH0S /k6usQf/da0MA8MgxgnuViEoBuKE39/GsKojI3lJ+Ma0SACqFBkpui9mNslWTo2f sSdE0JljcQlsCq3GTLC6CLeZwP9Cjl52FLeK/gCVhsh/Is1ZU/y9a/Mqf2mxCV04 +jCoBwBmwIn92Gtm5AvaR3vNU+a2TLbIJjneuFnnXmdMv9QD8U+zBL9afb3j2KID k76c9Lhuhg4erg1rQUV1K6MD7vXhLeqaADMOtEn+4GTKZMX8lxR0s+iftzJranL5 o5i/nFUbg2b9Tt4GDUFTBfOO70urhvVAmr0goV/DkUi7SR1Ke5H72ibTTT2F6Gr9 8XlW8UgbS2NMjRcs6f+xx3Ft5z4eww== =qZfn -----END PGP SIGNATURE----- --5xi4w3mp2vov7xmn--