Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <46d43a2c-387c-c037-7952-d20cd6e1f325@intel.com>
Date:   Thu, 27 Jul 2023 15:26:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 17/20] KVM:x86: Enable CET virtualization for VMX and
 advertise to userspace
Content-Language: en-US
To:     Chao Gao <chao.gao@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>,
        <binbin.wu@linux.intel.com>
References: <20230721030352.72414-1-weijiang.yang@intel.com>
 <20230721030352.72414-18-weijiang.yang@intel.com>
 <ZMIPeAHn5aN2HVS4@chao-email>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZMIPeAHn5aN2HVS4@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFRTSzh6SHFaUmt5ZURJK3grOUQ4TzhmZm1tait6dXkrVzhjSURaUDBLeHMx?=
 =?utf-8?B?dWxvbnBRaEx0emF5WXplNUhZZXZsOE8wbW5YVW1EMGZibDdhYWUzRElrY3dx?=
 =?utf-8?B?VjNoNFdrSmRIakdEOGxHcmlzTWtvOUI4aHlQK1NxSzkyUVo4VUx0TlRrdjZ3?=
 =?utf-8?B?T3lpUzdkMlNYQ1VPSDNza2hSUHB2UWZUTGhCa0ZaUWZVVXhQY2tCSW96R1Y5?=
 =?utf-8?B?eW5HWmdzbXphOUpZajdpSVM5TVNsMUNWQkhuczM5QUNRWW53S0FBQTlXdGY4?=
 =?utf-8?B?aG1zeDRrcHQvMEFXTzZ0b2dLTzNJVnlSaVliMVRpVjM0SjdnS2wyMktuK2cv?=
 =?utf-8?B?STcrNlZKQ1pzekRkUjFoK2Exa1dXYzkzaEQwSGd6eXJKaWNGbE5LemkzbDVi?=
 =?utf-8?B?THJPVU1FRlF2YVp2ZzJqdUZBNjdBdk5DaFVvVWh6QzlJc242WjdRNDVkS2E4?=
 =?utf-8?B?YlZ0ejRDVXMyTW9IZzVXQUwwOXVQT1k4Y1g5Y0dnaHR2K3F0T3ZIL0l1VGdn?=
 =?utf-8?B?N2RCbHdKcGxkaHI0RmtON2pJY0wyajVtYmd3NTRUTEZSMC9XQnE2bjZ3OGV3?=
 =?utf-8?B?T09wUitKTG1iOThsSzlCOHBRaXBRMnBDQ3pxT0VvSjRNK3BZZFdzaFI4SDFu?=
 =?utf-8?B?RVI4b1JQd3JFMzJYRjZCL1VvZVhmNWVnSDJ0K2t6Nk1GN1E1ZDZuQng4Nk5T?=
 =?utf-8?B?M2RiMDFLTGorNm1URVcxeXlGZktsVXl1RXBrRW41VFZGMDhBZnhOcWhhRFMy?=
 =?utf-8?B?UHNiQU5XSWFnaXc2S3ZZcDQrdmtvelFQeDg0MWFXRlc3aEdKWGFvMmd4VFlJ?=
 =?utf-8?B?VG1ERG9LcVdzNlZhb3VCeFRIdmo5N1h2ZFBCazhJTEVkL2QweE5maW5FaFBu?=
 =?utf-8?B?NUMvTC9NUFFaZmlHdS9DOVFJaTlsSERKYUtzMlhPRXZ6d1dVQmZDYnJ5MmVi?=
 =?utf-8?B?QUJ2Q0lUV000RlNKMzl0Q2E5cUkxdVU2T0FLalErMDFGSzQzMTQ5eWVUamFI?=
 =?utf-8?B?Z0JTYkRYVzZtWXh4cTl2dGREeitWcUpMRnpyTFJ0TWZhTkk1bExuSTQ5V2Zo?=
 =?utf-8?B?Q3l6Y0dlRFRJemVENjFKeEM1NWFQNG5iZWtRYkwzWjd1ejZXcENsbHhGZ2Ex?=
 =?utf-8?B?OVBaTjVXWE1hRWoxdC8yZEh4c29SczlUUGNoWnB6NnZwR01TMlhOdlR5ZGdL?=
 =?utf-8?B?SXRIekdDbTh2c0hUQStreWtjWWxtTGcrNzJPUVVlR0JBNDZ0TldaSUhoSi8z?=
 =?utf-8?B?bURaMVQycFlnYU1hazNkWlc1cnhBNUJiRjNXV2VzYThpcnlzNUtEamtLSVpz?=
 =?utf-8?B?akQ0ZUU2N3RHRW12SjBxbklkT0tmVHU5U2wxN0NNTlAyN2VkTU9YUG1ZdTRp?=
 =?utf-8?B?UWVGQ0oyMVlOLzlFbDYrOWp5M3RFa1d6cWZoOFlwSiswcEpJcjE0SEErRklq?=
 =?utf-8?B?bDIxb2JrRWlzY1ppNVNPMU0zblV0M3BnQ0FIVmYrN2t2bWcwQ2hFakZhcE1u?=
 =?utf-8?B?M0NrcFMwZGdFMm9KTXlqbmg1RmZGdUwzSUVDRHplcUlRR3ZsZFpRWDN5NjBr?=
 =?utf-8?B?S1hRRnR2ejJmdWxoemVoZ2lGeDQzRExQY3k2U0U3SE5qdjV3WHRuRWZjd0F4?=
 =?utf-8?B?UmIyYzBhVHNEcUdkaFBDYVM0SzhZVzNKd095NWFnZzJwWFBucXNkZmdlYlAv?=
 =?utf-8?B?ek1XQXhZcjhCdThYZ3hDem0ySmZEenE3Mkh5c0ZESFF1Qk1DaDVhSnNMWGEz?=
 =?utf-8?B?bUIvdWdYMFQ2bG1nbk90Z0lQU1RZcm5WQTZjOGdoMFFjY0tyTjlZWGM2T25n?=
 =?utf-8?B?YVJobTZCYmxkMFZ0R0FZeXBqZGY5UXBNalZDT0U5eTk2Z1BuVHFhZGlzYnFL?=
 =?utf-8?B?YkR6YjVpZEsxekk4VnVUaGtFYnJGY1RaeEE5cTVqaGZSQkxUTkJwNk11dnNQ?=
 =?utf-8?B?RFdhY2Jrc3RBZXhkYjNESFBQT1llVnNyOWdNbnhVaHZUR3RzMjBKVnNjUkFZ?=
 =?utf-8?B?VFplYVlDTkFkOTdJZU1IdXFyaFRXTWNlSEJEWWVzRk41SkJQeHoxTEZoQ2FM?=
 =?utf-8?B?dUtlb3AzTWIwSDRGcEN2T21Jdm5LL2VzSU1rTlNYc2lwMzEwREdBc3Q2c3J2?=
 =?utf-8?B?eE9DZ09MRWsrV2RkMGMrSzVKMk5KN3hseWd3SWp3RGxZQjBjVDhKeFpMdWdr?=
 =?utf-8?B?TXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9955019d-b355-4616-7f2c-08db8e72c5bd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:26:20.1394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4nBXWHsowlA9yIVHRS8bU7yQPghF5wUqdNg9aaX5AN9noeq5niPSj5TtW+OzPtSld28lygoAFsVfkJ7/HIrkeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4950
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RDNS_NONE,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/27/2023 2:32 PM, Chao Gao wrote:
> On Thu, Jul 20, 2023 at 11:03:49PM -0400, Yang Weijiang wrote:
>> 	vmcs_conf->size = vmx_msr_high & 0x1fff;
>> -	vmcs_conf->basic_cap = vmx_msr_high & ~0x1fff;
>> +	vmcs_conf->basic_cap = vmx_msr_high & ~0x7fff;
> why bit 13 and 14 are masked here?

Oops, this is typo! Thanks!