Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6d4ab42-49b3-5704-0c2b-e3b2a607d835@intel.com>
Date:   Thu, 27 Jul 2023 15:13:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v4 12/20] KVM:VMX: Introduce CET VMCS fields and control
 bits
Content-Language: en-US
To:     Chao Gao <chao.gao@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <peterz@infradead.org>,
        <john.allen@amd.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <rick.p.edgecombe@intel.com>,
        <binbin.wu@linux.intel.com>,
        Zhang Yi Z <yi.z.zhang@linux.intel.com>
References: <20230721030352.72414-1-weijiang.yang@intel.com>
 <20230721030352.72414-13-weijiang.yang@intel.com>
 <ZMIAF40pG0WCgPNK@chao-email>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZMIAF40pG0WCgPNK@chao-email>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUUzM1RYMDZEeUwvRmxQaXpjckZhbEhPamNMUXYrTmF0VUplSnBmY1FqS2Vp?=
 =?utf-8?B?VVpnQ0k3MW1rb2w1NnQwTVlDa3Z0L2FsQWkzb2ltVnk1WlJlc2hvR3J5NVJs?=
 =?utf-8?B?b083ZlFUdHdKcE15a04vbm92Q1NkRHREeDhRRWFFZmpESVlLMTkraUswRDRH?=
 =?utf-8?B?RkEyRWNKSXpWSDZVRVVlcG16MGNicTdFSzd2TGVibUpJVEsxc2xndXZWRVA2?=
 =?utf-8?B?RDQxZXJ4QmN0MXJOcmY3UldIUHZVTFJpL0hsREIyb3ZiY0J3TDZFNjAvekpW?=
 =?utf-8?B?b0lZcUhhTGtSUituNUd4UEJWSDMzNzhRcFlSZVZtY0NYQzJYaWlpSy9peWVJ?=
 =?utf-8?B?K1h5OTh4dWgycEFMR2hvQjA2MVE0VVNjbkZIalFjL3ZLWDRpQlhoWFF6dWh2?=
 =?utf-8?B?cks0ZHhENVF3RXFYYVF0QlpnMW9OTFlnNW5kS25FZTVDQWVHNnlkTi9ETzc1?=
 =?utf-8?B?T2RoUGVxUmdPRmtHM3REd0NnNUxCcDd1MDA0NzlFNGU5aEs1RDdxOWFwY204?=
 =?utf-8?B?S3R0YW15cjhsZ1U0N1Npd2xHazVPWTcyRWJGNGxGdzc2VGU1U3FVU1ZvWWlE?=
 =?utf-8?B?QWZXa3dncWtLZjFhbUN1ZkVSRDdmUW04SlU4VWhMMWZBV3gyYjVHVHBvVjFm?=
 =?utf-8?B?Tk1PUzB6azZZZnV3UC9ZdHFvdE81aGVEVHljamdnb2tpckMvM2tkV2hZa3BX?=
 =?utf-8?B?TmVFekY5b1FsYVovVHhQd3lEMGhGY0JlRDVGdEh4TnNrbnVrdGVsempFL1RU?=
 =?utf-8?B?eHd4Qmk0cUR6bmNBWFlxQ1hDSEVpQ3hueFNaMzFmM0ZOL2REVXBrR01pbzBp?=
 =?utf-8?B?T1daK05QTHRBK2dDRVBhVFEvTmlkclhJbCtmSlV1eU5UeDFmWHhjTkNNaGJp?=
 =?utf-8?B?REFtRHdWRjJFZTVOOVRkSTZuUE9jMVNIK2U4ZG5WQmhYd2VmQzdlelZybHY5?=
 =?utf-8?B?cWc3MDR3b1A4ME5Cd3d1ZmRKYS9leE44QU9UZjYzcGZ2eUF4T29SWTVJMUVl?=
 =?utf-8?B?YmZMK21xNVMvd0pPbitDTkxNWGJ5S0lSQmI0WEFSUmNGdno1OUFGMERuZTFL?=
 =?utf-8?B?eTR2OHhhdytLRDdNK090ODJwMEM1b01RVHprTlgyakR1byswdytRMzVuOENi?=
 =?utf-8?B?VHRKdXBGZ2p3YkdoVXRaeUNZQ2xKa3d1RmdxSHJyK3MvT2FUVU5HeG8zTldE?=
 =?utf-8?B?VklQS1orSmszOXNlZjJkMktQZ0R1cytpY0dieFFNRjJxZU1jUkloUjREWk53?=
 =?utf-8?B?bXZNTW1HMVV4cFVlTU9LdTJHZG1nRzRGTk0wOHdtVzNGcVpoYnF0dnQ5bWZG?=
 =?utf-8?B?c2hkbk9qQ0RXZit0TVM2TE1NNEIxRnBiU2pLWnlOdVdFMExvVGVHbkpTVDdY?=
 =?utf-8?B?VE95MnJveFdHbmF6VTIxTmlCU0EzMVZIMERKdEZwSEk0cUMreWE5NUdhRkNq?=
 =?utf-8?B?cExRS2J0bU1QQzdDWGdKelB5OElxR093eGJTWmdlWU9mWGMzQ1g0VjRaQ3A5?=
 =?utf-8?B?NGRMaC94dE8zcVd1ZU80WWhKcFJhNXZiL3QrZHZJZUJibWF5c25Rcm51SjV6?=
 =?utf-8?B?b29iMVB0bHg3cldxTXlxN3o2VjZqaW43b1pITk5GK3dITXpCdjRnbi80LzU3?=
 =?utf-8?B?ZmpYY1ZiWGlTRlZHdWM3Zys5Q090d1hGUFhZdENtdWwwZ3prTGhpZm5yMjZZ?=
 =?utf-8?B?eDMrT2d5bktGM0JoRUVIVHZCckVSbzVlS1VBVjNnMm9SbU11djJkWnMwcU5R?=
 =?utf-8?B?b1pXK1ZWbG9NVUl1Rldoc0FUU29zVWExNW5pRnZCQVdYVEVEOXV5YkFjQWxE?=
 =?utf-8?B?bzJlaTI5TDhvaFRxUVArVFN5aVVrK1Y2bTRHcWZzV3pRdG9MYkZKeGpsTUFT?=
 =?utf-8?B?bjZQdXFrRGZpWXJMS3FtblJUYU52SjdOd21UczJ4MzhKTmd3WUFrOHk5M1A2?=
 =?utf-8?B?T3JxdUgrR3RiK3VVNTd3MHBTTEtCSUsxREIvM1JlVWxTQW04d0RMclBPQ21r?=
 =?utf-8?B?UzBhZlNpZVZqTkFvZVVwTnV5YVI0aTRHKzZhSHpMdGJuU2EzMk1aTnFDQzUw?=
 =?utf-8?B?bHhWT01xVFpPaWY5SzBSMDVJZWFhT29SVnFNUldCUmpRRmtrcHd0Y2ppT0ZJ?=
 =?utf-8?B?cmp0RmViRncvOGFlUTZzWDB5Ry9RYTNpZUVtbXNGWm1MblBUK1U5aWkxeU9Z?=
 =?utf-8?B?NXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b7193a5e-f0be-4f81-2ff4-08db8e70f092
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:13:12.9614
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KpCY4Klm/Q2Mrg1+DikKJlrcGZW/U3An2VHnmisZZ3ZLedR6En7RNYDFceWUzTV5CoCHuyEetJsAggqYQo/bVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8025
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/27/2023 1:26 PM, Chao Gao wrote:
> On Thu, Jul 20, 2023 at 11:03:44PM -0400, Yang Weijiang wrote:
>> Two XSAVES state bits are introduced for CET:
>>   IA32_XSS:[bit 11]: Control saving/restoring user mode CET states
>>   IA32_XSS:[bit 12]: Control saving/restoring supervisor mode CET states.
>>
>> Six VMCS fields are introduced for CET:
>>   {HOST,GUEST}_S_CET: Stores CET settings for kernel mode.
>>   {HOST,GUEST}_SSP: Stores shadow stack pointer of current active task/thread.
>>   {HOST,GUEST}_INTR_SSP_TABLE: Stores current active MSR_IA32_INT_SSP_TAB.
>>
>> On Intel platforms, two additional bits are defined in VM_EXIT and VM_ENTRY
>> control fields:
>> If VM_EXIT_LOAD_HOST_CET_STATE = 1, the host CET states are restored from
> Nit: s/VM_EXIT_LOAD_HOST_CET_STATE/VM_EXIT_LOAD_CET_STATE
>
> to align with the name you are actually using.
>
>> the following VMCS fields at VM-Exit:
>>   HOST_S_CET
>>   HOST_SSP
>>   HOST_INTR_SSP_TABLE
>>
>> If VM_ENTRY_LOAD_GUEST_CET_STATE = 1, the guest CET states are loaded from
> Nit: s/VM_ENTRY_LOAD_GUEST_CET_STATE/VM_ENTRY_LOAD_CET_STATE

Sure, will change it, thanks a lot!

>
>> the following VMCS fields at VM-Entry:
>>   GUEST_S_CET
>>   GUEST_SSP
>>   GUEST_INTR_SSP_TABLE
>>
>> Co-developed-by: Zhang Yi Z <yi.z.zhang@linux.intel.com>
>> Signed-off-by: Zhang Yi Z <yi.z.zhang@linux.intel.com>
>> Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
> Reviewed-by: Chao Gao <chao.gao@intel.com>
>
>> [...]