Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Xiangyu Chen <xiangyu.chen@eng.windriver.com>
To:     bpf@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
Subject: [PATCH] libbpf: fix warnings "'pad_type' 'pad_bits' 'new_off' may be used uninitialized"
Date:   Thu, 27 Jul 2023 16:25:36 +0800
Message-Id: <20230727082536.1974154-1-xiangyu.chen@eng.windriver.com>
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GWVWqqhk7qhEboSEva2W7BASdB919jftOJdhoZoZPtiiZS/g7ZrX38BnJ+uA?=
 =?us-ascii?Q?vXRZkcU85AS30d80kAv+wEC18hKpm2kbXg0U5J/n9XA7G+KxVrveX8i4HzRW?=
 =?us-ascii?Q?7ZBuP+JZmeFrinTNqUXa5jVKiCBBoanIFNmxpxnDBsqd11uvjVrbGJoUedA0?=
 =?us-ascii?Q?6IZ6whkmsEhf4IsHuL7x/hPNvc38Xgr5J0o2CJtFhItRLIObMABPMEIC3MrK?=
 =?us-ascii?Q?sKCsTn9osIklj0pXV4VhIPON7f+JCSurCREfG1KoGNTJuf8HGv/w/vU76DZx?=
 =?us-ascii?Q?YJo4yQSFSj3hoaLeacSL43+Lcon3WGBolkJnsNIRd0+FBxwYSIYbtFN9fr33?=
 =?us-ascii?Q?pd4jYH0B6PNrfXHVJLUAk4LNW6AUjljNJNWqHEvSx0tB0IG9O1OdQu5GGr8H?=
 =?us-ascii?Q?yco+al52BhsJi0VRPjlVwSRbDxXY2HtuIyRGbxkPrBGQi9zIi1ilIayr4ATU?=
 =?us-ascii?Q?bYtOGR8sfGIK7mjxfa4II+uDMX01fBIKG4v6uNlbfaKt7gSPdz6GoGnQrO2J?=
 =?us-ascii?Q?xyf/RNplozkyOy1uzIPWlPjd1vJ/hDXDKqoQX8UGJ1hS/3lBNGdB3uptgH8o?=
 =?us-ascii?Q?WilopTJAPI6zy5lK1t6in66NSxr0k8Sl6hKXyv1YQHa3i7EJSzZA0H09/wu1?=
 =?us-ascii?Q?qktNxd+hL0B7IvBh3XMT9egWyXQmfmzu25adlP+ys7Ix1qKsydSzvyX+9TWA?=
 =?us-ascii?Q?S8/UPK6VDgG5f8HUx00rOMrXnuz+TJLksRjFM9s+MVh1PzAqibJgmfVk58Hv?=
 =?us-ascii?Q?Mn6kl8FPDGAAqiQrUiNhQVb2a9kizybMV7oX4z4nmVL5rF6hLaJQ3aAo8wv+?=
 =?us-ascii?Q?DJ+tsnmxOE2ttXQBSitqLvrYspKFuiQBJiVVDo2aWeh8iMwXYhK9nr/6QAfp?=
 =?us-ascii?Q?E8hkFJ32GXa1W/U79cRSJhfhhXV6SGGcLiEOplij5qLAUP33qtzkNuHW4n7G?=
 =?us-ascii?Q?Z4z/C/roqFqkpefnJwprZd6xIZHzcW2KWMEuEhWgPCGieX7C+x9k4gW/Q7fJ?=
 =?us-ascii?Q?FQDyPJyFwyxj9ifaV/zrW/CI2RdytNjaJOnTkokK/oWZ3XHcFhR4s09La8lR?=
 =?us-ascii?Q?YvrTOP0tScWPPwP8RVcUDTRN+F5/IqogOYgnSaxBeNZb2oL4PLOylpV+GkV5?=
 =?us-ascii?Q?14Qe+ftnysgivZiR/knSzC4CvUvrN8JF0EETZQariQQaNn9jEUqOBiwfqQHD?=
 =?us-ascii?Q?2Q/yEgc2lvVJPzKgKPGfU62rNhc/cA1aNKXr7axL7G8FA3ds8XEA6wTmInEH?=
 =?us-ascii?Q?vXXFR5vZyZlqEgV2Igt5iMeu7sI0pE7JDHk7AisCXDkFORqD8xFu1RUNNDfG?=
 =?us-ascii?Q?tzm8x7Dq3Gv2KJdY3JOIUDNLPDwCUkxRcYg1d3ujID74hcrsQFAVReMDPy3w?=
 =?us-ascii?Q?iZh1girnemEsYhgvIGQJ3RUoKSYZNl+rO48mMrcbRsxHZTia7VQRmgy9cx/y?=
 =?us-ascii?Q?fnuA3LgMQ1OZ8PtmCB5S0qto1Q3mINXCaRlTpL7ZqPW1yjmyymNNiK/of5NF?=
 =?us-ascii?Q?irjPfpI4FUpiSyIRediqm0/aVMCtsF5meA3US06ZzraRvAlKfcPU6Zip3AuX?=
 =?us-ascii?Q?sKexzgonZ3pCZ3jJ5HXKEBraslZ/oCFT4BETg0iJhgq7kZYbRq4XS6ax5GA1?=
 =?us-ascii?Q?6w=3D=3D?=
X-OriginatorOrg: eng.windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18436092-6c89-4884-3c49-08db8e7b186d
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5824.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 08:25:54.6455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HbxhHihK53INeKku+MFKoCicTisnonlSEpMhNLWUptNo27m+091mvpk9cRKfwWtmTdm71P6KUAsghNnhy6r7eepxWo5e+SVPo7886qbRAXQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5230
X-Proofpoint-GUID: SLN7q00wkMd_aEcb_NOBzAvGfUtPARJy
X-Proofpoint-ORIG-GUID: SLN7q00wkMd_aEcb_NOBzAvGfUtPARJy
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-26_08,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 bulkscore=0
 impostorscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2306200000 definitions=main-2307270074
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H3,
        RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Xiangyu Chen <xiangyu.chen@windriver.com>

When turn on the yocto DEBUG_BUILD flag, the build options for gcc would enable maybe-uninitialized,
and following warnings would be reported as below:

| btf_dump.c: In function 'btf_dump_emit_bit_padding':
| btf_dump.c:916:4: error: 'pad_type' may be used uninitialized in this function [-Werror=maybe-uninitialized]
|   916 |    btf_dump_printf(d, "\n%s%s: %d;", pfx(lvl), pad_type,
|       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|   917 |      in_bitfield ? new_off - cur_off : 0);
|       |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| btf_dump.c:929:6: error: 'pad_bits' may be used uninitialized in this function [-Werror=maybe-uninitialized]
|   929 |   if (bits == pad_bits) {
|       |      ^
| btf_dump.c:913:28: error: 'new_off' may be used uninitialized in this function [-Werror=maybe-uninitialized]
|   913 |       (new_off == next_off && roundup(cur_off, next_align * 8) != new_off) ||
|       |       ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|   HOSTLD  scripts/mod/modpost

Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
---
 tools/lib/bpf/btf_dump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c
index 4d9f30bf7f01..79923c3b8777 100644
--- a/tools/lib/bpf/btf_dump.c
+++ b/tools/lib/bpf/btf_dump.c
@@ -867,8 +867,8 @@ static void btf_dump_emit_bit_padding(const struct btf_dump *d,
 	} pads[] = {
 		{"long", d->ptr_sz * 8}, {"int", 32}, {"short", 16}, {"char", 8}
 	};
-	int new_off, pad_bits, bits, i;
-	const char *pad_type;
+	int new_off = 0, pad_bits = 0, bits, i;
+	const char *pad_type = NULL;
 
 	if (cur_off >= next_off)
 		return; /* no gap */
-- 
2.34.1