Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sahin, Okan" <Okan.Sahin@analog.com>
To:     Nathan Chancellor <nathan@kernel.org>
CC:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "zzzzTilki, zzzzIbrahim" <Ibrahim.Tilki@analog.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: RE: [PATCH v3 2/2] regulator: max77857: Add ADI MAX77857/59/MAX77831
 Regulator Support
Thread-Topic: [PATCH v3 2/2] regulator: max77857: Add ADI MAX77857/59/MAX77831
 Regulator Support
Thread-Index: AQHZuGy8mN9TLCcuJkyLQ19F8fkBDa+/r5IAgAyW/YCAARHLsA==
Date:   Thu, 27 Jul 2023 08:34:44 +0000
Message-ID: <PH7PR03MB739122A373964651D995EA5AE701A@PH7PR03MB7391.namprd03.prod.outlook.com>
References: <20230717050736.10075-1-okan.sahin@analog.com>
 <20230717050736.10075-3-okan.sahin@analog.com>
 <20230718155502.GA3542993@dev-arch.thelio-3990X>
 <20230726161033.GA1102409@dev-arch.thelio-3990X>
In-Reply-To: <20230726161033.GA1102409@dev-arch.thelio-3990X>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iMdTO0okfz4oP0FiAQkm/GTWaVElkUpg4er5OuOcPjP4aGd7/xAl06qLNf1T?=
 =?us-ascii?Q?0tv8xS8DTmvcMztUbInot8QcbYxzgp9/26xyyfSkkn5tkmbpIpPKeSNFXks3?=
 =?us-ascii?Q?3sFcxUMcEbB+3nIYhSuMnSjxFJygSWBY1jlyaYt5kS1RJSGn5fi/G4+PFnet?=
 =?us-ascii?Q?JhguSYVa0YEgbEkTfy/I52nABiZN6uDPI5LoHNf7TarxGA5DcsvOIT3ppMyO?=
 =?us-ascii?Q?taSYEsp2iMRYIg2s88hgYjTYxrY1L9EGOV+v4vB6Zyx99yjcCP1mZy8t15Tb?=
 =?us-ascii?Q?zbphzJablTJdmSD7piPJj3DCIysFpth17wraOSqnifr8mdtz+O4otFtwqY5c?=
 =?us-ascii?Q?1H3nPp8kGUbuy9EM4WG3/Nc8O88gjT8cWW/BIYI9BksRYrrNAltcJvm27cEx?=
 =?us-ascii?Q?xhxPfdrS9sn6zEeILFq9okvaVFmz9deRtNhY1TheVzDX7PrLbAXOiBcCGpNt?=
 =?us-ascii?Q?PY88hJCTuhOdH4YoMvdDRB4E2SE7Wgwlv63MzeNBFSxYUFXV2+mGGH6zBSKa?=
 =?us-ascii?Q?ZJt28ktGfJD6hprTybJd7G6i43ZxzQQuTXYeynbAkvoWa8qKFlWpI8KIMMUl?=
 =?us-ascii?Q?z5zwEZv/I7tousoKaKEsNkr/9b+o3gt8tSnPM+1IF1b/GjFNsHWAHdeX6AB+?=
 =?us-ascii?Q?ICBdYu7f7VbOA7RJC3yTAk73LRAN79/U2j4My0AtITj5V3FQZg7I8AS37pbG?=
 =?us-ascii?Q?3o6CDF/UvtX5lbC53tTBIw5zFkaYIWnotlhzHrjKV9oUPC4Pcq4dQRSBdJTd?=
 =?us-ascii?Q?Xsya8lqmDUzKYex+qlll8Lfun8yooza/eEMf467QjqXnprT+GPr2+Sa2YIC/?=
 =?us-ascii?Q?FTeKyYs255GGy/c6lFOAn0V8G5gnI0SOw5UzDvM4GJCTx9T3sMMRwKD4ZgvN?=
 =?us-ascii?Q?/eOjSRa69pq6PI6vjOO1gETLpZsVR5vh9h+HzJb9SvQDwLht3m8+mLBcbJB6?=
 =?us-ascii?Q?OqOakD2y0q+7mrNC7MPeIIhWgoRktDbFeP8XIR8TcEm8WhXyIzBNgwKHrgYd?=
 =?us-ascii?Q?Dq2IwFmXuhZJQPvQfEErRJGXwfcvpOGf8pjDBCqcaYjh8TXFUfNhrQ69wNYW?=
 =?us-ascii?Q?storYFp/nlb9XEYCY+RhV/eVQ2HJ1MrckmgE2X0359BT0eA699qMDtm+SIp4?=
 =?us-ascii?Q?DxBs9deSa6JVUEx8PrMe8+qvgjs6D4i4h2uyWq5555Zdt79BOicWQ6b6B0hf?=
 =?us-ascii?Q?QDHLAOYuNE+GsdlUZUU4unVbpJt7rcylaY4Wm8UqG7sn8Vx6jQaSJ3mZU4/Y?=
 =?us-ascii?Q?1EwqzKmR08l6jFYFIXfRFSVVuPEiYGu6GAy6u9I+TQEOfuD2imK/7Eqrte/M?=
 =?us-ascii?Q?XvJgF0Q+pqE+LB2mIT9tQWfnUZM8rwO3cDrDSx++xR3aQNdlqYXzplL1AomD?=
 =?us-ascii?Q?QDCsYP1g2/sXwm0GhQgHvYGlAviAn1/8QxI6gbJv4ta4TsHMkWLtZ+YkrxO2?=
 =?us-ascii?Q?aOqeEoRquGW9nNxyP+Z7E/IiifW2PQb8VTXu12Nkr2KItD7bHsfL8PqSdD5e?=
 =?us-ascii?Q?LAOw6zxZ6QDbb4wFKHxUeBHbSDeB2zu0HppXYCbd3utrNHrqZBnUweGTqI4R?=
 =?us-ascii?Q?ytMsKb+BqeI3c2knwwP6G5SVLlgbHmpDRRPebqII?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR03MB7391.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7b368e0-0664-4254-60bd-08db8e7c5474
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2023 08:34:44.6827
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E1BGtpTk3sJBL45rpC6FJlUFQoNeoiw2149txFGXd3XCZtgMKxB6RmEhZORdTK3WvxtuhPgwrE5wmsa8EvUDhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6359
X-Proofpoint-GUID: cBQ6cRJdl21C5PWPDogxo2DnVT4BYcxR
X-Proofpoint-ORIG-GUID: cBQ6cRJdl21C5PWPDogxo2DnVT4BYcxR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-26_08,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0 bulkscore=0
 mlxlogscore=999 clxscore=1011 spamscore=0 impostorscore=0 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307270075
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Nathan Chancellor <nathan@kernel.org>
>Sent: Wednesday, July 26, 2023 7:11 PM
>To: Sahin, Okan <Okan.Sahin@analog.com>
>Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
>Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
>zzzzTilki, zzzzIbrahim <Ibrahim.Tilki@analog.com>; linux-kernel@vger.kerne=
l.org;
>devicetree@vger.kernel.org; llvm@lists.linux.dev
>Subject: Re: [PATCH v3 2/2] regulator: max77857: Add ADI MAX77857/59/MAX77=
831
>Regulator Support
>
>[External]
>
>Hi Okan,
>
>On Tue, Jul 18, 2023 at 08:55:02AM -0700, Nathan Chancellor wrote:
>
><snip>
>
>> > +static struct regulator_desc max77857_regulator_desc =3D {
>> > +	.ops =3D &max77857_regulator_ops,
>> > +	.name =3D "max77857",
>> > +	.linear_ranges =3D max77857_lin_ranges,
>> > +	.n_linear_ranges =3D ARRAY_SIZE(max77857_lin_ranges),
>> > +	.vsel_mask =3D 0xFF,
>> > +	.vsel_reg =3D MAX77857_REG_CONT2,
>> > +	.ramp_delay_table =3D max77857_ramp_table[0],
>> > +	.n_ramp_values =3D ARRAY_SIZE(max77857_ramp_table[0]),
>> > +	.ramp_reg =3D MAX77857_REG_CONT3,
>> > +	.ramp_mask =3D GENMASK(1, 0),
>> > +	.ramp_delay =3D max77857_ramp_table[0][0],
>>
>> This breaks the build with GCC 5.x through 7.x:
>>
>>   drivers/regulator/max77857-regulator.c:312:16: error: initializer elem=
ent is not
>constant
>>     .ramp_delay =3D max77857_ramp_table[0][0],
>>                   ^~~~~~~~~~~~~~~~~~~
>>   drivers/regulator/max77857-regulator.c:312:16: note: (near initializat=
ion for
>'max77857_regulator_desc.ramp_delay')
>>
>> and clang:
>>
>>   drivers/regulator/max77857-regulator.c:312:16: error: initializer elem=
ent is not a
>compile-time constant
>>     312 |         .ramp_delay =3D max77857_ramp_table[0][0],
>>         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>>   1 error generated.
>>
>> This relies on a GCC 8.x+ change that accepts more things as
>> compile-time constants, which is being worked on in clang
>>
>(https://urldefense.com/v3/__https://reviews.llvm.org/D76096__;!!A3Ni8CS0y=
2Y!7B
>eWxuzHgLzOprQA_madbvdR7hd0ZgmS73lUlDbgoxWUFWdDSIRXLnhyqLeRhu3uTaqpS
>kzZKwc5pHA$ ). Since the kernel supports older
>> compilers, this will have to be worked around somehow. Perhaps a define
>> that can be used in both places?
>
>Was there any update on this? I do not mind sending a patch for this
>myself if I have some sort of guidance on how you would prefer for this
>to be fixed, should you be too busy to look into it.
>
>Cheers,
>Nathan

Hi Nathan,

I thought that I should fix this issue after merging main branch that's why=
 I did not send patch.
I sent patch v3 so should I send new patch as v4?

Regards,
Okan Sahin