Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec964562-6ebb-e145-e850-0417a88077c2@linaro.org>
Date:   Thu, 27 Jul 2023 11:26:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] Documentation: bindings: adi,axi-tdd.yaml: Add new
 TDD engine driver
Content-Language: en-US
To:     "Balas, Eliza" <Eliza.Balas@analog.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Derek Kiernan <derek.kiernan@amd.com>,
        Dragan Cvetic <dragan.cvetic@amd.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
References: <20230726071103.12172-1-eliza.balas@analog.com>
 <61fce1da-c8dd-f911-e4bb-b2198612e7c6@linaro.org>
 <BN7PR03MB4545E574AB9886290115E5C89701A@BN7PR03MB4545.namprd03.prod.outlook.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <BN7PR03MB4545E574AB9886290115E5C89701A@BN7PR03MB4545.namprd03.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/07/2023 11:05, Balas, Eliza wrote:
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Wednesday, July 26, 2023 21:35
>> To: Balas, Eliza <Eliza.Balas@analog.com>
>> Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
>> <conor+dt@kernel.org>; Derek Kiernan <derek.kiernan@amd.com>; Dragan Cvetic <dragan.cvetic@amd.com>; Arnd Bergmann
>> <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org
>> Subject: Re: [PATCH 1/2] Documentation: bindings: adi,axi-tdd.yaml: Add new TDD engine driver
>>
>> [External]
>>
>> On 26/07/2023 09:11, Eliza Balas wrote:
>>> Add device tree documentation for the AXI TDD Core.
>>> The generic TDD controller is in essence a waveform generator capable
>>> of addressing RF applications which require Time Division Duplexing,
>>> as well as controlling other modules of general applications through
>>> its dedicated 32 channel outputs.
>>>
>>> The reason of creating the generic TDD controller was to reduce the
>>> naming confusion around the existing repurposed TDD core built for
>>> AD9361, as well as expanding its number of output channels for systems
>>> which require more than six controlling signals.
>>
>> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on
>> the directory your patch is touching.
>>
>> Subject: drop driver. Bindings are for hardware, not drivers... unless driver is here a hardware term?
> 
> It is not a hardware term in this case, I will make the changes.
> 
>>>
>>> Signed-off-by: Eliza Balas <eliza.balas@analog.com>
>>> ---
>>>  .../devicetree/bindings/misc/adi,axi-tdd.yaml | 51 +++++++++++++++++++
>>>  MAINTAINERS                                   |  7 +++
>>>  2 files changed, 58 insertions(+)
>>>  create mode 100644
>>> Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml
>>> b/Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml
>>> new file mode 100644
>>> index 000000000000..1894c1c34d4f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml
>>
>> Why is this in misc? No suitable directory?
> 
> I chose misc because I don't know where it should fit, I did not find a suitable
> subsystem to include this driver because this is a driver for an FPGA IP core.
> Do you have an idea where I should put it?

Directory based on what this device does. Whether some device is
implemented as FPGA core or dedicated circuitry, it does not matter. Few
Time Division Multiplexing devices are related to audio, so they are in
sound. I don't know if TDD is something else than TDM. If nothing fits,
can be misc, but again - just because device does no fit, not the drivers.

Best regards,
Krzysztof