Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Jul 2023 13:09:19 +0300
From:   Andy Shevchenko <andy@kernel.org>
To:     Romain Perier <romain.perier@gmail.com>
Cc:     Andrei Coardos <aboutphysycs@gmail.com>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, brgl@bgdev.pl,
        linus.walleij@linaro.org, daniel@thingy.jp,
        Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: msc313: remove unnecessary call to
 platform_set_drvdata()
Message-ID: <ZMJCT0jtCzUuSnQP@smile.fi.intel.com>
References: <20230721131157.26640-1-aboutphysycs@gmail.com>
 <ZLqu56eHfpc0TnMw@smile.fi.intel.com>
 <ZL/L1tiKjLDP5bet@smile.fi.intel.com>
 <CABgxDoL4ftygpXKKuRoAKJ41KRTLQZr-YOiWLC5pM96-qe_=eQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CABgxDoL4ftygpXKKuRoAKJ41KRTLQZr-YOiWLC5pM96-qe_=eQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Jul 27, 2023 at 09:00:36AM +0200, Romain Perier wrote:

First of all, please do not top-post!

> The private data is "struct msc313_gpio *gpio". This private data is
> "binded" to the gpio_chip via devm_gpiochip_add_data, right ?

No.

> Then it is retrieved via gpiochip_get_data(chip), right ?

No.

The driver data is used in PM callbacks. See below.

> Le mar. 25 juil. 2023 ? 15:22, Andy Shevchenko <andy@kernel.org> a ?crit :
> >
> > On Fri, Jul 21, 2023 at 07:14:31PM +0300, Andy Shevchenko wrote:
> > > On Fri, Jul 21, 2023 at 04:11:57PM +0300, Andrei Coardos wrote:
> > > > This function call was found to be unnecessary as there is no equivalent
> > > > platform_get_drvdata() call to access the private data of the driver.
> >
> > Not true.

^^^^

> > > > Also, the private data is defined in this driver, so there is no risk of
> > > > it being accessed outside of this driver file.
> > >
> > > Reviewed-by: Andy Shevchenko <andy@kernel.org>
> >
> > I have to withdraw this, the patch is wrong.
> > NAK.
> >
> > Sorry for the confusion (I have looked for the wrong pattern).

-- 
With Best Regards,
Andy Shevchenko