Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <acab57a7-3aab-11bc-6102-bc2e93cf9ecd@opensynergy.com>
Date:   Thu, 27 Jul 2023 12:21:38 +0200
From:   Peter Hilber <peter.hilber@opensynergy.com>
To:     John Stultz <jstultz@google.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>,
        "Christopher S. Hall" <christopher.s.hall@intel.com>
References: <20230630171052.985577-1-peter.hilber@opensynergy.com>
 <20230630171052.985577-2-peter.hilber@opensynergy.com>
 <CANDhNCpaoRRKGz0XxV3zjA-ux66gU-dT_bGQ_OqDh4ty=VdXLQ@mail.gmail.com>
Content-Language: en-US
Subject: Re: [RFC PATCH 1/7] timekeeping: Fix cross-timestamp interpolation on
 counter wrap
In-Reply-To: <CANDhNCpaoRRKGz0XxV3zjA-ux66gU-dT_bGQ_OqDh4ty=VdXLQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3FMWXVFcFJva2Z2TmdvbHBZRnkzTS9FeEViQ3dCUURkM2xySXJKMG0yS3o3?=
 =?utf-8?B?ZS9Bd2Z0V3VkZnZrT05NUnFJSHR1UmhpeHlMY3hUcTREMkhRUlJEZk5GNFYz?=
 =?utf-8?B?alZCNzFndHNUZFJQcUJEQ1FiTExKYXhUaTdjUitLbXQzTERqbm9BMDJ0Zlc3?=
 =?utf-8?B?VWFiWDROMUwwZGVWeXJDRU85V2JyN2U5Z3JsRmZFUGdlem9jYXlTcURHQWRC?=
 =?utf-8?B?N0F6VzJmQXZ1VzZ2Ty80eEdMdngyaENxR0hhdWM3RVJDaGJkREZKdGU2Mk5j?=
 =?utf-8?B?U1diN1JTQUR5VENOVTQ1QVZBbjJiK1J2VnBGR0dUazlSWjlScVpEYmRKZ3V4?=
 =?utf-8?B?S1UzTVlzeWR3QWk1OHhQSm5rSzVpSWI5NTdVQ2I3ZzdWRXNuS1NhSG0vTjhT?=
 =?utf-8?B?eHdxUVlWNjhiSVpiZUJ0N1hDeUIzOEx1d0ZZcXhFOUNhWjJDRGI3UVl0dG53?=
 =?utf-8?B?bHFUM3ZVU1JoS255SlBUckxIWjNkZytReGNPa05wVEFnZ1plMDU0T0JTR1dy?=
 =?utf-8?B?NzFORk14Ujc2Y2hSNU9LTWw1eFo4bmYyYUtHRitwYmpSOWdrRFdlaFA0SFh6?=
 =?utf-8?B?ZDYveHZNd1pCaFdHdjFTS3JWbkwzUzdQK3BsWE1PaEZLSTBLeDNsalNhVlow?=
 =?utf-8?B?ZjFweDNiNmczVjQ2S29rMFpGamlrd0FFTXVnNy8wWXQ5R3Y1UVVrRk0vT0xr?=
 =?utf-8?B?TmZVTTNrVitMck56ZnBJSUZPZHpSSWp3MEIweUh5emJDS3piWWJuSXlLV1Z6?=
 =?utf-8?B?VjVZZXhtV085TUMyS2llVDltQk1hNUIzMHJRTkJwTnlTYzlycWM0MDY2cWE2?=
 =?utf-8?B?Tkh1YU9kUkZ3ZldIYWJ6NUthOFZrVkZ3ZHBCVE1kckVxWGh4bm54RUM3SFFY?=
 =?utf-8?B?Uk9LYTdEdjl6d3QrQjdvTENHb1RtaHkvU1RrYkE2SFQ4TEVmYnAwajcwYUhS?=
 =?utf-8?B?cDU1Y0k5TXpMT3N0bWpSaW56Q0taTVpJMTQrRHpGcE5LKzFHOUJSOURYN0lV?=
 =?utf-8?B?QjF0YnNCYjdPbGwwRDFCLzFNR2hmQUJiU3MyTGp5TVAwV3hia3hRWVdhZS9r?=
 =?utf-8?B?VHpIeG16bFpGcTZ1M3lBdWY4dXZKY2txWTlIYlZUd0FBbVplZmhTU1EvMzcy?=
 =?utf-8?B?Mk1QWmFsY1VvM3NRTUdWYnZ1dXNVWHBKMDJnY0tWRlRNMktCMlN4VzRTYjJ5?=
 =?utf-8?B?dlNRd2V3QjlrdE1BU1V1SjhtY2YrREdJc2hvU2k2QVAxaWZSdHRUbkhzSWdl?=
 =?utf-8?B?N2tLcm9ZU1p3TTY2U2JSWkNFUGtRaWxwY0VEUXA2VzdiU0l5ZnRTazRPV3R0?=
 =?utf-8?B?WU5IYnZNZ0Zsd3dJT042bENQYm9pYnR4UW5zMDlaKzgzZ2dZUnB5MXZFRmZE?=
 =?utf-8?B?VUUvakNObVlJdnJtMnZweWNEbEkxODZjeXlUZHp4WW50TTlBY0pyZUQ2Mi9w?=
 =?utf-8?B?TlBYVzZFK3p4cU84RlZCcFJpcnI3ajNsRnFoMjZjNkU5YStidnBod0VsbkJN?=
 =?utf-8?B?a2ZwTTlZbmEzMktUVGczUnJOUWIrcEo1STV5ZGNSU0xXc0UvSi80MVhLTkdU?=
 =?utf-8?B?dmxyT1cyOFk0R2Zha0lhTzJwMEdiaDRkMi9wNG1CaVUzZ1prcy9ra3Z2UU5j?=
 =?utf-8?B?U09VTmpMcjNIdEEvcG1KMnQ0N09SNUpYem1RVW9YaGo5cGozdStDOWlIeVdt?=
 =?utf-8?B?WlVPMGMxWFh6Vlk4YWlKQnhZQzR5OUg4WVZUc1UzdHhnZ0UrWFlmdTRYYkV3?=
 =?utf-8?B?NTBUTUJlVGNMTVBnSExQWVBuUzdneXRCN1o0M2ZudW01Uy9rYUszenlneTNI?=
 =?utf-8?B?Sjdyd0dVMHlVQjhOQ1lHYjNnMHRKaUh1NkpLTnUrN1I3ZnMvYm84RzEzZXli?=
 =?utf-8?B?N3VjNENnVG5JaURETkRERmFVbHpRYzNzVWZnWjZxQjNaNVlESGQ4TlFGVFFC?=
 =?utf-8?B?dFFpdkk2WWQvTmFQVGMzeElIQndWYml1KzBybVJPMU9JWittRlhWTC9FVisx?=
 =?utf-8?B?dkQyUFpOWiszdFlic0xRZm42dzJKVWdxbFpxZmltM1JHcXVlMWgyNVJlMmc5?=
 =?utf-8?B?RC9tcThuMXo5NnNjaEI0VmliTXk0cGNWazV2ZEZPNUhkVkc2RkNsQkJJRVNy?=
 =?utf-8?B?R3RsV0dPeVQzWUNTMmR1ZjlkVlh2UkV1WkhwVGJHOHNCYzdQUitHMlVkWjZT?=
 =?utf-8?Q?J28hFbeyn2ba1qt8eHIrvwQynZJuiw5YcHoUdlckWlVr?=
X-OriginatorOrg: opensynergy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6419eabb-9792-472f-94ca-08db8e8b43a5
X-MS-Exchange-CrossTenant-AuthSource: BEZP281MB3267.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 10:21:39.0483
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aIFRpn3P5EsmR5Xd2kEaOOcL2cFxgqTqWmaL716LICD+whDSVj72P9i3OiqwuTLsjXaaBTc4ONiffT5JDB46Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR0P281MB1483
X-TM-AS-ERS: 104.47.7.177-0.0.0.0
X-TMASE-Version: StarCloud-1.3-9.1.1011-27776.006
X-TMASE-Result: 10--8.889600-4.000000
X-TMASE-MatchedRID: scwq2vQP8OFRw37hysZWBgw4DIWv1jSVbU+XbFYs1xK3UJJ8+n/4RZV4
        6ChsSKJzeLbIdIgehmz4KMoVcGm4TWVKzi1vZiAN9uL5hOvaG1KVmuhG06IIbTji23k3pyJLKLe
        iMOXj8x0HZRiBZseHrIiu7wRb1ji7rddi2w4fb9BFg2HO5lmNEPhwJOI9xff0D++CmrqtFoD8wt
        ZXDSbfrL0UfeDlmgKJ6xA0Ava73nAPm15xyht8lST5U3lJ4T8KVpPkdwltPhTCWXLd4w2EwN/up
        PexrMg466PwQJF2tNThh+3i1Bd2p9lWEqyA1TWbIxoY6jRls5ndfsxLJyDdyA==
X-TMASE-XGENCLOUD: 778ee2c8-e7a2-45d9-901f-0b4f9eb4cf0e-0-0-200-0
X-TM-Deliver-Signature: A956273B454162CFCAD01A06AAB72FD1
X-TM-Addin-Auth: Ne+BI4Ey/mMAuDh4Bmf1lHYqscYiXurihyAFn04jJGKSJU64p40hqpCrSx1
        ernWv5AtbjavCqjualUtLAkQiRpy4vYDXPrrQx/ATNCJLGVe7esk2SKpa4kjcRSQkpe95k4KsIg
        Cu/14krMwY6wX8RaeBPjsGHEZQliCEissBjnZYEh/5aNh0UVVT/WHI8jJElAcGWbuKI/9T1IpgH
        9r32Tvv2PwFbZvUZ1zJnfmeERuinNqaDmqJMi/Jnr3wgX4WCyxnz7mjeKZTXxUt1jRbNa7BCBZB
        YUuY5STw6hX1EyI=.OTq6fIBR25FcaUyEiY+e140ZPzX3izwoQfas822qZ2HIdWpdt56bQ1eALy
        9iluvRKqu0h52l8H2BqNQuWi6vkYlul/b5SUj6PgHV8I4WkLuB3ZM9CkI7BYj8SeqiXkVY4FTTr
        CqbYgiHyWc04QzL+sAbe1p9Ky2MVG36ZnfverIDOtE19jU5Rlf2IIcOEVyBLr85H5mVRiOTcRNA
        jDoZJZpOlvu/MYcVMsgvqgIKJV/D0Y57Y5dEKD+Z3fgtBmP06L6QOxIjPvRXdTvlV8dU16B+7aO
        BkTx3enZ4/lFikenZVty88AL21KIy5NonfmEc8izCctx45VnPBRfKxEl49g==
X-TM-Addin-ProductCode: EMS
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=opensynergy.com;
        s=TM-DKIM-20210503141657; t=1690453301;
        bh=aGRlESebHQpO66t9+gVRqnAJ0jRBelYTvwt9PX68ep4=; l=1454;
        h=Date:From:To;
        b=l1skd23RrdTLaXuZOcxbKXRnnbDBrSsW8535NqAfDEM1RiaipX/MV6nJ+nVtvRu98
         E9vBziLxuiY4ya/juHK+ZPbhLPxoJs2TFecdzWfnLvDd/FCLw9fVLtRXWyYQDP7MYV
         LTLVrcSlFsJEXABRudnx87HRkcfzAf4mirz3SxQ3jLPdVdaArl2uv9fVIcelCAVUL8
         cnfFi2iwnANj/7Ks6us2W/wR8LPipMVtWFpp/PiTVtVW3GU2EShjMe6TnXE0+5dmsz
         Ttmhwi+70QsLnI+gi+JEzS6hGTpz+u/jVSEiACn5hc64GxITzebubzcZlJhvWmRK4A
         GZ/gDWya404Hg==
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08.07.23 00:51, John Stultz wrote:
> On Fri, Jun 30, 2023 at 10:12 AM Peter Hilber
> <peter.hilber@opensynergy.com> wrote:
>>
>> cycle_between() decides whether get_device_system_crosststamp() will
>> interpolate for older counter readings.
>>
>> cycle_between() yields wrong results for a counter wrap-around where after
>> < before < test, and for the case after < test < before.
>>
>> Fix the comparison logic.
>>
>> Fixes: 2c756feb18d9 ("time: Add history to cross timestamp interface supporting slower devices")
>> Signed-off-by: Peter Hilber <peter.hilber@opensynergy.com>
>> ---
>>  kernel/time/timekeeping.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
>> index 266d02809dbb..8f35455b6250 100644
>> --- a/kernel/time/timekeeping.c
>> +++ b/kernel/time/timekeeping.c
>> @@ -1186,7 +1186,7 @@ static bool cycle_between(u64 before, u64 test, u64 after)
>>  {
>>         if (test > before && test < after)
>>                 return true;
>> -       if (test < before && before > after)
>> +       if (before > after && (test > before || test < after))
>>                 return true;
>>         return false;
>>  }
> 
> Thanks for catching this and sending it in.
> Looks good to me. Curious: Did you actually hit such a wrap around with u64s?

No, I just saw this when fixing the bug in the next patch.

Thanks,

Peter