Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75da106c-3f00-7be9-d4d5-c83f1e1664bb@redhat.com>
Date:   Thu, 27 Jul 2023 11:52:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] ACPI: scan: Create platform device for CS35L56
Content-Language: en-US, nl
To:     Richard Fitzgerald <rf@opensource.cirrus.com>, rafael@kernel.org,
        lenb@kernel.org, markgross@kernel.org
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, patches@opensource.cirrus.com,
        Simon Trimmer <simont@opensource.cirrus.com>
References: <20230726112759.18814-1-rf@opensource.cirrus.com>
 <33cdbf63-8fe4-da7e-5d36-6e63fe303b24@redhat.com>
 <42399566-2d25-e888-7226-05a86767b644@opensource.cirrus.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <42399566-2d25-e888-7226-05a86767b644@opensource.cirrus.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 7/27/23 11:48, Richard Fitzgerald wrote:
> On 26/7/23 15:13, Hans de Goede wrote:
>> Hi Richard,
>>
>> On 7/26/23 13:27, Richard Fitzgerald wrote:
>>> From: Simon Trimmer <simont@opensource.cirrus.com>
>>>
>>> The ACPI device CSC3556 is a Cirrus Logic CS35L56 mono amplifier which
>>> is used in multiples, and can be connected either to I2C or SPI.
>>>
>>> There will be multiple instances under the same Device() node. Add it
>>> to ignore_serial_bus_ids and handle it in the serial-multi-instantiate
>>> driver.
>>>
>>> Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
>>> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
>>
>> Thanks, patch looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>>
>> I have 1 other serial-multi-instantiate.c patches in my fixes branch (see below) and since this just adds new hw-ids I think this can go upstream through my fixes branch too.
>>
>> Rafael, do you agree with me taking this upstream as a 6.5 fix? And if yes may I have your ack for that ?
>>
>> About that 1 patch, that adds a new IRQ type: IRQ_RESOURCE_AUTO and I wonder if this patch should not use that same new type right from the start:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/agit/pdx86/platform-drivers-x86.git/commit/?h=fixes&id=676b7c5ecab36274442887ceadd6dee8248a244f
>>
> 
> Link doesn't work, but I think you mean:
> https://lore.kernel.org/platform-driver-x86/b9f81a5b-0511-9950-5a20-9e6cbd92d085@redhat.com/T/#t

Right an "a" (probably from ctrl + a) snuk in there, correct link:

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?h=fixes&id=676b7c5ecab36274442887ceadd6dee8248a244f

Which is indeed the same patch as you linked.

> I'll send a V2 of this CS35L56 patch to use the new IRQ_RESOURCE_AUTO.

Thanks.

Regards,

Hans