Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp2204067rwb; Thu, 27 Jul 2023 03:56:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlGkt0FLK6ZFv8y4Bax6FYObAVGV2WHi8KmN38ha40E6EeKD9R+pjblZ7GxksoQRialk/kuK X-Received: by 2002:a05:6a20:3ca8:b0:12f:6aee:7e43 with SMTP id b40-20020a056a203ca800b0012f6aee7e43mr5989217pzj.57.1690455418403; Thu, 27 Jul 2023 03:56:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690455418; cv=none; d=google.com; s=arc-20160816; b=sML2Bw2R71qLnyWvi45rkyOpk9uKjzvzwRKKy+hMuDthE7svSblhjZFMJ+SfeS7q9n 5442ain7tJqFpKZDe25HCreLOIIUTPAhKmr7huxj1xkWDOQSgVdqWx0CIO4Cley6099Q mdiuU4BhzzzxBRTO0DoBJjEZOGlIfpo6K6t+bW9FyHc1LEWbMIoaUyuIdfoO29rSjNgF TIMXmyUy5+ocNl3lwojXLHeTpFFvexxJ5DAu1oQHWd1gvDNkkVe0TRq9qZcty2D1PQH9 BO8JLg38KtnFWdlHUv0ldtNSuJSkFp/9AcEJrDYW9fOY1DR5YQ05GoWG1x5BkTPSMdZw w6DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=4cq5jiYLMIV/4qUWT+rsQM4JCtmx/nDzC/W3X2qAVKQ=; fh=MHMZDc6DtESGy8KljL1RisFeuF6ell/vXmd9XLmefV4=; b=DhY1/gDut1zEwCnc2m2uUAlL1oW20bgiZR6I7fm7alGyoCQ/E5+Jcs6oliu2DUbgUZ L6DWMPjXzHliGFzuO2ED2mNqhuqCCsoPu/V6Rl7zjnZaM+WILTbWAwkioe9L+pgTRCfR x8AbYXlxpiqbeHSbaTCS65vQJefBzOXyd6d/PRArBjxLMKK4z+wfVylRQLCU2efZBqVv m6yBl717dYLHgXO8/9xYgrSv62tCi71ZGKddAtqEcJHgXzwT2qznA+8hLrrOFdJd52Hw CxoxzBf/TOUpRzYGEBkAUwmKy2Pu9IvPcR7fLhGnasyw6PtN/vfEUjItIA7W1+s137AP 1jxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="XAmD/75A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k10-20020a056a00168a00b00686ea63779bsi1208899pfc.397.2023.07.27.03.56.46; Thu, 27 Jul 2023 03:56:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="XAmD/75A"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233111AbjG0KKY (ORCPT + 99 others); Thu, 27 Jul 2023 06:10:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjG0KKX (ORCPT ); Thu, 27 Jul 2023 06:10:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9E897 for ; Thu, 27 Jul 2023 03:10:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0294E61E0E for ; Thu, 27 Jul 2023 10:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4E620C433C9; Thu, 27 Jul 2023 10:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690452621; bh=V8cRhjjMjy0S96MMHGyJjXFao2r6oszoTlft5F/lo94=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=XAmD/75Akb6sePqlWJX10dhM6Y0Bw3xikdxF2TFxaWS7lvQQaroZudPo7y6p4KS8L 9ilRLPBmRIV8X0BM8ou/GAKTb3p8WVX6WU8vt08hXHjmjUDxR2s/BwnKWwFkWj6bM0 obF5xXe/Tg8fBQ6co2e1Ws/Ke9HlFK/KcrOPXLqotsFWA+U01ZRP/LxiNb4MopzKer PiHK1JoTMI/Mdxb0V9iD7eNYmMa7fng0OlP8pPxrSImldse/Gw91W6s6z9E3TWc52z OSgbUoFk3OZffrCMWwibOszCGpaGY9ytT40wTDiYRh+AjC5JlMhu6wxWYLKg9JMtyb yeqmIFpGzvA8g== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 347B2C595D0; Thu, 27 Jul 2023 10:10:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] tipc: stop tipc crypto on failure in tipc_node_create From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169045262121.6409.17871887881657519923.git-patchwork-notify@kernel.org> Date: Thu, 27 Jul 2023 10:10:21 +0000 References: <20230725214628.25246-1-pchelkin@ispras.ru> In-Reply-To: <20230725214628.25246-1-pchelkin@ispras.ru> To: Fedor Pchelkin Cc: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lucien.xin@gmail.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, khoroshilov@ispras.ru, lvc-project@linuxtesting.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Wed, 26 Jul 2023 00:46:25 +0300 you wrote: > If tipc_link_bc_create() fails inside tipc_node_create() for a newly > allocated tipc node then we should stop its tipc crypto and free the > resources allocated with a call to tipc_crypto_start(). > > As the node ref is initialized to one to that point, just put the ref on > tipc_link_bc_create() error case that would lead to tipc_node_free() be > eventually executed and properly clean the node and its crypto resources. > > [...] Here is the summary with links: - [v2] tipc: stop tipc crypto on failure in tipc_node_create https://git.kernel.org/netdev/net/c/de52e17326c3 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html