Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <064951c6-2ddb-1488-1d4a-694e927e3215@linaro.org>
Date:   Thu, 27 Jul 2023 12:20:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: mcp3911: add support for the
 whole MCP39xx family
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Marcus Folkesson <marcus.folkesson@gmail.com>,
        Kent Gustavsson <kent@minoris.se>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
Cc:     linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230727101318.2764379-1-marcus.folkesson@gmail.com>
 <3c69b206-a9f0-c8f3-70a1-3994e056140b@linaro.org>
In-Reply-To: <3c69b206-a9f0-c8f3-70a1-3994e056140b@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/07/2023 12:18, Krzysztof Kozlowski wrote:
> On 27/07/2023 12:13, Marcus Folkesson wrote:
>> Microchip does have many similar chips, add those to the compatible
>> string as the driver support is extended.
>>
>> The new supported chips are:
>>   - microchip,mcp3910
>>   - microchip,mcp3912
>>   - microchip,mcp3913
>>   - microchip,mcp3914
>>   - microchip,mcp3918
>>   - microchip,mcp3919
>>
>> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> ---
>>  .../devicetree/bindings/iio/adc/microchip,mcp3911.yaml      | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> index f7b3fde4115a..06951ec5f5da 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml
>> @@ -18,7 +18,13 @@ description: |
>>  properties:
>>    compatible:
>>      enum:
>> +      - microchip,mcp3910
>>        - microchip,mcp3911
>> +      - microchip,mcp3912
>> +      - microchip,mcp3913
>> +      - microchip,mcp3914
>> +      - microchip,mcp3918
>> +      - microchip,mcp3919
> 
> Your driver suggests that they are all compatible, so maybe just use one
> as fallback?

Oh, wait, you did put match data, just not in OF, but SPI. It's fine then:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof