Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Jul 2023 11:43:20 +0100
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Antoniu Miclaus <antoniu.miclaus@analog.com>, <jic23@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <linux-iio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings:iio:frequency:admv1013: add vcc regs
Message-ID: <20230727114320.00000021@Huawei.com>
In-Reply-To: <96a82a51-6e26-cee2-c095-98fac749393f@linaro.org>
References: <20230727102309.92479-1-antoniu.miclaus@analog.com>
        <96a82a51-6e26-cee2-c095-98fac749393f@linaro.org>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 27 Jul 2023 12:37:47 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 27/07/2023 12:23, Antoniu Miclaus wrote:
> > Add bindings for the VCC regulators of the ADMV1013 microware
> > upconverter.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>  
> 
> Subject: missing spaces between prefix parts.
> 
> > ---
> >  .../bindings/iio/frequency/adi,admv1013.yaml  | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > index fc813bcb6532..6660299ac1ad 100644
> > --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml
> > @@ -39,6 +39,46 @@ properties:
> >      description:
> >        Analog voltage regulator.
> >  
> > +  vcc-drv-supply:
> > +    description:
> > +      RF Driver voltage regulator.
> > +
> > +  vcc2-drv-supply:
> > +    description:
> > +      RF predriver voltage regulator.
> > +
> > +  vcc-vva-supply:
> > +    description:
> > +      VVA Control Circuit voltage regulator.
> > +
> > +  vcc-amp1-supply:
> > +    description:
> > +      RF Amplifier 1 voltage regulator.
> > +
> > +  vcc-amp2-supply:
> > +    description:
> > +      RF Amplifier 2 voltage regulator.
> > +
> > +  vcc-env-supply:
> > +    description:
> > +      Envelope Detector voltage regulator.
> > +
> > +  vcc-bg-supply:
> > +    description:
> > +      Mixer Chip Band Gap Circuit voltage regulator.
> > +
> > +  vcc-bg2-supply:
> > +    description:
> > +      VGA Chip Band Gap Circuit voltage regulator.
> > +
> > +  vcc-mixer-supply:
> > +    description:
> > +      Mixer voltage regulator.
> > +
> > +  vcc-quad-supply:
> > +    description:
> > +      Quadruppler voltage regulator.
> > +  
> 
> You made them required in the driver, so they should be required here as
> well. They should be required anyway, because AFAIU they have to be
> provided.
> 
> OTOH, this will break the ABI, so your driver might need to take them as
> optional.

In many cases will get stub regulators if they aren't explicitly provided,
so no breakage and no need to make them optional.

Jonathan
> 
> Best regards,
> Krzysztof
>