Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Jul 2023 13:18:52 +0100
From:   Will Deacon <will@kernel.org>
To:     Josh Poimboeuf <jpoimboe@kernel.org>
Cc:     linux-kernel@vger.kernel.org, kernel-team@android.com,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        John Stultz <jstultz@google.com>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scripts/faddr2line: Constrain readelf output to
 symbols from System.map
Message-ID: <20230727121851.GA19653@willie-the-truck>
References: <20230725211157.17031-1-will@kernel.org>
 <20230725211157.17031-3-will@kernel.org>
 <20230725213805.g6osfswz5o6cxusy@treble>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230725213805.g6osfswz5o6cxusy@treble>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jul 25, 2023 at 02:38:05PM -0700, Josh Poimboeuf wrote:
> On Tue, Jul 25, 2023 at 10:11:57PM +0100, Will Deacon wrote:
> > @@ -185,7 +186,7 @@ __faddr2line() {
> >  				found=2
> >  				break
> >  			fi
> > -		done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2)
> > +		done < <(${READELF} --symbols --wide $objfile | sed -f ${IGNORED_SYMS} -e 's/\[.*\]//' | ${AWK} -v sec=$sym_sec '$7 == sec' | sort --key=2)
> >  
> >  		if [[ $found = 0 ]]; then
> >  			warn "can't find symbol: sym_name: $sym_name sym_sec: $sym_sec sym_addr: $sym_addr sym_elf_size: $sym_elf_size"
> 
> Looks good, though the outer loop has another readelf incantation:
> 
> 	done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v fn=$sym_name '$4 == "FUNC" && $8 == fn')
> 
> It should probably have the same sed options?

Hmm, I don't think it's needed there, is it? The awk expression has a
strict match on $sym_name, which is going to be something extracted from
a kernel log and therefore exists in kallsyms.

> Also it looks like it's wrongly checking for FUNC.

Yes, I agree that should be dropped for the reasons you gave before.

So I can spin a v3, with an extra patch to avoid checking against FUNC.

Will