Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7dbaabf9-c7c6-478b-0d07-b4ce0d7c116c@oracle.com>
Date:   Thu, 27 Jul 2023 12:43:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [RFC PATCH 0/5] mm: Select victim memcg using BPF_OOM_POLICY
Content-Language: en-GB
To:     Chuyi Zhou <zhouchuyi@bytedance.com>, hannes@cmpxchg.org,
        mhocko@kernel.org, roman.gushchin@linux.dev, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        wuyun.abel@bytedance.com, robin.lu@bytedance.com
References: <20230727073632.44983-1-zhouchuyi@bytedance.com>
From:   Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <20230727073632.44983-1-zhouchuyi@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWJXaHFuczVJNC9OeTdGeCt3dUJkOVZncnhNNnhaRWYrVmJNd05UTFQ5Ymll?=
 =?utf-8?B?bHNFWGhjMHh3dDZsRml6TUJpZGVrT2pWb0ZSbHhvbWlIS2cwRmVHbmhzbVlK?=
 =?utf-8?B?UkV6RnJ0bGpLZ1paYjdNVnh5QzNXa2NTZEJMbGxOVnhDUjk2SHFLbkR5eXh4?=
 =?utf-8?B?NGhrTE5ubXRmYUx3UnpUbG1ZZGlwVmtvcVZldzdrNmtuQnJvYXE0Q1I4SGY5?=
 =?utf-8?B?U1pZb1had0p1S3I3eTdJYW5KSzdKTGVxTTlkdi9NazBvYnJ5TkpBbWhJbzlY?=
 =?utf-8?B?VTNCSFdub0Y0ckVGcmE5elYvYVJSL04waVE5M3B4OUluS2NVODJZN0lYWGV6?=
 =?utf-8?B?ZlIwb29mUFloOVRkRUk2dm1rN05SODdiUkltcDB0Ry9UcU1BckZkaXgvejBx?=
 =?utf-8?B?eHNzeER3KzdSVEdLa1liQmk2SlhmM2hHWUtRdnBVTEEwOFhGbFpaeTIrMWo2?=
 =?utf-8?B?RUFhbGdja1pucmFwajJWQUgycDN4Q0ZqUGRnMnNrc0FwMkNub1B0N2xqanpp?=
 =?utf-8?B?bWplUS83bHJuRjE3SkcwblFsNHZDRjIzYnlyQTQrRnJzSEFTQkkyRElhb0Vx?=
 =?utf-8?B?OEtvTk5WT0pMVmx3bTNtRXNkMUIwWjFWRkk4emtBVzU4ckhreXd6c1JjdExr?=
 =?utf-8?B?eFJIVTBPVkpnSWRnWDVRYXpiS1FtZnNsU1RGTmptdlF6Q3NvY28xeE9GRHdW?=
 =?utf-8?B?Zk5ORW5CZUlqM1REcWRGTjBoVDN0ZmVpMW8rbFA4QWpuRFpiQ0pCNmVUT0gw?=
 =?utf-8?B?TmxEWXpwSytyWVhSOTVZTCt5SkpqeUJNZmZReDMrOEtSQlFaR3ZEQ3U1eVFE?=
 =?utf-8?B?LzBhRENQa3lBSVo5NDRQUXVoTE5nbjBhcm85ZDhDZkI3cXVFQlRmdEl1ZjlU?=
 =?utf-8?B?ZWxRck1jZ0MxYjFzclI4RGZ1b01tNUJWcUxEaklqV0pZYjBSNFpSZ2V5bmJy?=
 =?utf-8?B?d0NBVEFESDdrT1RCZGJRQTRKZldyRXhCVENkRHNPRlpMdEphZ1pOaTRoRjdv?=
 =?utf-8?B?bmxxUTlldGRzWkI3aUlQZHJJRFNLT1FGaW1GdHI3YmdudElNb29GQ0dQaEs4?=
 =?utf-8?B?YWRsZHNqMVltcFMxTGxlVWRMWHM2MkJUUWpBZ3BubnBFQ3JtZkNtY2QwSXhs?=
 =?utf-8?B?L0lSM1o4ZzZUUFZTSHVyT2JsZS9qWm9DaW92LzFlL3JaNnVPc0tsS0tSeGkz?=
 =?utf-8?B?cUpXeGRVSlhBSkhTVkFsek9Xcm9lNWJUK0I1bjBsN3RCUVI3RmE0RE83OGxk?=
 =?utf-8?B?ODBxOC96NkpSZGwvekFCTTFnUzAxMUdWMGVKaWFtQ1lMamNQaHQ3VHp3VlBO?=
 =?utf-8?B?VVNwSzNkVHhqa291NjdHZDFUUDFHeWVmMHhEdzdaSitHNFRjYUgvSFpLbDZP?=
 =?utf-8?B?cEJsd0Y3aEFhRHNEM0xMRkhwODlOQmNtYmhsU0ljNG16Yzk0Qnl2VkM1a1Rp?=
 =?utf-8?B?YlNSTGNMOGRSYXVGWk9JY0tMbkovUG5aTEFiQXh4QmtuckJCYzN3eE5mL3hh?=
 =?utf-8?B?cVBIRGJaSlU5QzNCbTdJZFY1SkNRS0IzbXpUeUgxQTEvbUdXYkE4Q2FON2tV?=
 =?utf-8?B?YnYyb2RDL05RWXg4bU1mTGl1bDNvMTE4REhMZ1hWdnBjUjI3LzdnblpRdXdm?=
 =?utf-8?B?aUw1MXhmM01jbXF1OUc0MmVMbkdwWHJPbDU3ZEFRZi9qNlA0a0RrdmtoYzJ3?=
 =?utf-8?B?VGE2K2t1MEp5YW5xY0lLMzRQV2F5NUlhRDJPVUUwY2QwSjdVemh1QXdZcERR?=
 =?utf-8?B?MGpteHh4K2ZlbWtKTzNaMks5Mk5pZk94QS9Yd1QxbEpNK3h1dlhHMTlZOUtm?=
 =?utf-8?B?VFAySUVzcVhERVVuUDNjS3hjeXp2U2MxK3dVcFVZanVJRnFueVpNS2EzVHFw?=
 =?utf-8?B?anRRTmxhYXZHQ09zZEpZaGdrNjlIZ1dPa1NmRFU2cTJ4NnJRRnAzbWMxS0ZG?=
 =?utf-8?B?NnF0NDFBVnRwVjhqejkzbERzQVY0OENTQnZUNzVkTmFQblZkVk51Q1FpWW8y?=
 =?utf-8?B?OXcyNUVaKzlnK3JyN0RETjlNWm5RVzhRcUZpdmpPVjBmdVB6VTRlM3VBL2xJ?=
 =?utf-8?B?dENoSGFJck5LRjd4dW16bjFucy9EZXArVS9ySTRJMXpISjJUOVlnN0JHR0ww?=
 =?utf-8?B?eXFHS2oyV0hkWno4bk03TGxwVGV1cnQ5RnlUOVlKb0lHc2tHcU1FM29JMFN2?=
 =?utf-8?Q?f0QCmjVsRbyRxZvbMHnnSVI=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: f1JE03ILNMkF74uKVkAmm7bNXGHwarEj1fwuPpC84cvt4Mqj8fp4onAXWsej4T54X3HjHyRYN1habJiUoxl8U4ZblyhraQCmzhaRdHWcD0WepCLzxOQOXEPKmeCjtM4nqdKmuzeSyn8Kwp07ySB3vXRkFJPGmhDaz4FJMvlAVdoLsQBex4yt174hB7WUeKh7/PGmr656A+xK0NXm4D4aAxyaM+tEJ9VXoVyJnr86NFHocB7KcO/8LWs5ex/ts7eYs5uGRsn9SKpvc0sprcIifvydkO+tLEnESOjaXrFzGjy+nYnnIeH1cyLEhVqZru95JF6xA8agcY5QVcBDKzoa2iCASLLhRZpqNkySlmZurXTkxVHFhY77gc22jvkqN/36Wnreyccga4ZzKFLSRKcMI8hYxFOv4ptnMdH19YzIOzGwGndmSAe0K7eoUhw+pmOkJK629fHN28n08RaMkm9kLRjHCvwQ3wQBhjpyp84jAwqg8d09WXDR9Qatg7yNx3Si7d7XNMH5ib1b2tCG0bYn4piua4Nk+9MP1gBqUHFcFt/LvM2sY42Ur506c6lZUvrb83Tuh0A18mgeTDoKSSgloO+Gwdf7TMPM0Be4Q0D6hGhX1KHGAW7L3C3B1aQDk1OoXrBlCHOn7/eKkRFUDZ8zW7D/l0jP8MgG8xSXdGwudxWUSaZrin17vvJqKHAU1Xu5RWvgXKM/m6z9JrbdFkS1Rf3ikRDfu7XtpM/rR1Ns9mZd4W5G953wcrkm5YmfzE/S6Xym3lbuuAJ9IpzbJh/hxHFKbJr8prykrPe8lsqfSg2YfgMAkeonThy0UNaV6d0H269P2lcbbWGYi6I4383BLkuJqHPfPyZ3dlC/KpUqbpGvJDjXoYOJA2xcWQoBloWw32TCHtuaOLbkRCtN5hFXc3OG4ElCfvpjqL5ASXyH/VM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed57cbe0-6817-43a0-9016-08db8e96c683
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 11:44:03.2060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f6Q3apCmfMh0YALYpCD3R18WktYsu2KJjugklTiXT5DLQ1XfKxIKA2J7OdQMn24DXY9/hA6M2P2FjC7cjEP6Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7654
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_06,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307270105
X-Proofpoint-GUID: 1o2IzdSE7MBijBucTshVFhNgnWoQOyKC
X-Proofpoint-ORIG-GUID: 1o2IzdSE7MBijBucTshVFhNgnWoQOyKC
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27/07/2023 08:36, Chuyi Zhou wrote:
> This patchset tries to add a new bpf prog type and use it to select
> a victim memcg when global OOM is invoked. The mainly motivation is
> the need to customizable OOM victim selection functionality so that
> we can protect more important app from OOM killer.
>

It's a nice use case, but at a high level, the approach pursued here
is, as I understand it, discouraged for new BPF program development.
Specifically, adding a new BPF program type with semantics like this
is not preferred. Instead, can you look at using something like

- using "fmod_ret" instead of a new program type
- use BPF kfuncs instead of helpers.
- add selftests in tools/testing/selftests/bpf not samples.

There's some examples of how solutions have evolved from the traditional
approach (adding a new program type, helpers etc) to using kfuncs etc on
this list - for example HID-BPF and the BPF scheduler series - which
should help orient you. There are presentations from Linux Plumbers 2022
that walk through some of this too.

Judging by the sample program example, all you should need here is a way
to override the return value of bpf_oom_set_policy() - a noinline
function that by default returns a no-op. It can then be overridden by
an "fmod_ret" BPF program.

One thing you lose is cgroup specificity at BPF attach time, but you can
always add predicates based on the cgroup to your BPF program if needed.

Alan

> Chuyi Zhou (5):
>   bpf: Introduce BPF_PROG_TYPE_OOM_POLICY
>   mm: Select victim memcg using bpf prog
>   libbpf, bpftool: Support BPF_PROG_TYPE_OOM_POLICY
>   bpf: Add a new bpf helper to get cgroup ino
>   bpf: Sample BPF program to set oom policy
> 
>  include/linux/bpf_oom.h        |  22 ++++
>  include/linux/bpf_types.h      |   2 +
>  include/linux/memcontrol.h     |   6 ++
>  include/uapi/linux/bpf.h       |  21 ++++
>  kernel/bpf/core.c              |   1 +
>  kernel/bpf/helpers.c           |  17 +++
>  kernel/bpf/syscall.c           |  10 ++
>  mm/memcontrol.c                |  50 +++++++++
>  mm/oom_kill.c                  | 185 +++++++++++++++++++++++++++++++++
>  samples/bpf/Makefile           |   3 +
>  samples/bpf/oom_kern.c         |  42 ++++++++
>  samples/bpf/oom_user.c         | 128 +++++++++++++++++++++++
>  tools/bpf/bpftool/common.c     |   1 +
>  tools/include/uapi/linux/bpf.h |  21 ++++
>  tools/lib/bpf/libbpf.c         |   3 +
>  tools/lib/bpf/libbpf_probes.c  |   2 +
>  16 files changed, 514 insertions(+)
>  create mode 100644 include/linux/bpf_oom.h
>  create mode 100644 samples/bpf/oom_kern.c
>  create mode 100644 samples/bpf/oom_user.c
>