Received: by 2002:ac8:45c5:0:b0:405:464a:c27a with SMTP id e5csp1248720qto; Thu, 27 Jul 2023 08:53:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJ01v6n61nSv5aRTyemXTY9QxeFzkaWsD/PIO8xUBqyK43rsmE4UD5KbzRd2mKdgSF7vLz X-Received: by 2002:a17:90a:e38f:b0:268:60d9:92cc with SMTP id b15-20020a17090ae38f00b0026860d992ccmr3379399pjz.43.1690473211958; Thu, 27 Jul 2023 08:53:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690473211; cv=none; d=google.com; s=arc-20160816; b=lExZ1NtVQU4KsuHsH+YC0xcR2iv5B+AZ70FDXLFgJQ8S7dEj4a6bdeM5+vJ+P5eJWl gse7cusNSf5MLQEsQ8wJ1UY0UsK3XwNALPTovytbWynhmDUT2c25wRnWf2Sgsf5UFEKT w74RJbnauUYnpNw5ObGUkYdu1upV55bY33koCDbGRkAu2nptzKSxfl2jL45bf4YEAqcb EeKOnLCzx72nlCEgPAyz3h5WZYM1h3ypkqrxOm9mNHzWhalbZXdOTvq0KlLFq/vbKjPg 6p68zGGlM6eVFjOn3eZTKlgpE7Vs40sS2SwgMRw9yFpcFNsuNrISu9drFevK+z43MUal h0BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kR0+QLUNwP8z6pQp2dnhrAY+jylUhPO8RtfeAOnPMuY=; fh=tjlI116YNnoKvVnJ5DkKjyXA9MWSUPbbvSzxtrOCmC0=; b=t/1gJikwS4fXWF4jOFXVVBAYCqC1ZfB3MKU2Uf2u1S8r1ZeJgD+WBMVWmxx9BLA2BJ 0cmGo7ZoXbEBUV8ZHDzi4xiq/Zw+HFK79HvYQAKlqwQscwDJc+wM98khP66Csa7NCC47 UsskFHYP0K6GCiZR9uIMdJ0gXM5kr0SlYtZh4vpgKSBJwPuwVwUdYMeXaS27F5i30f3D 062kEqSiQu6lzx4mofpGevMNOG4g//DvJx2Oq8T1Ybn+UYAWf3S7bn5DBsjBZ5ZOSUUo BCMEmsiJxO5cBfE7xLuKITLb6ioFUdrxqcazAYZ4qzyYUghbj+xY42l+A1WPOUqTbC7C wqDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zy8GVxtn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o2-20020a17090ad24200b002683b77e224si1525017pjw.164.2023.07.27.08.53.18; Thu, 27 Jul 2023 08:53:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zy8GVxtn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234317AbjG0PFX (ORCPT + 99 others); Thu, 27 Jul 2023 11:05:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234305AbjG0PFS (ORCPT ); Thu, 27 Jul 2023 11:05:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83AAA106 for ; Thu, 27 Jul 2023 08:05:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2125961EAD for ; Thu, 27 Jul 2023 15:05:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BD27C433C8; Thu, 27 Jul 2023 15:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690470307; bh=S4gMs7l9BbfVoMDxJHoDIv85l19923iR5lO0JZs5P2Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zy8GVxtna31kMtQX2zBoFrOOx5bpfLu2qmX9iy4hnBpGqO0AKtrOmp9CzoUDA2Sw4 6KSJjETRNILOuMsLmoe7Sl2YRnFHIQp+QLdrjARDsUEb0EwZyM832OPnlclBRGbEWp 1NnDqTl6aPoeCaOfEeARpHH0uFSupNdAtNVZEAB0= Date: Thu, 27 Jul 2023 17:05:03 +0200 From: Greg KH To: Alexon Oliveira Cc: martyn@welchs.me.uk, manohar.vanga@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH] staging: vme_user: fix check alignment should match open parenthesis Message-ID: <2023072741-mankind-ethics-b95b@gregkh> References: <2023072729-sensitive-spyglass-ec96@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 27, 2023 at 11:47:23AM -0300, Alexon Oliveira wrote: > On Thu, Jul 27, 2023 at 10:03:19AM +0200, Greg KH wrote: > > On Sat, Jul 08, 2023 at 12:55:11AM -0300, Alexon Oliveira wrote: > > > Adhere to Linux kernel coding style. > > > > > > Reported by checkpatch: > > > > > > CHECK: Alignment should match open parenthesis > > > > > > #132: FILE: drivers/staging/vme_user/vme_bridge.h:132 > > > #135: FILE: drivers/staging/vme_user/vme_bridge.h:135 > > > #139: FILE: drivers/staging/vme_user/vme_bridge.h:139 > > > #142: FILE: drivers/staging/vme_user/vme_bridge.h:142 > > > #144: FILE: drivers/staging/vme_user/vme_bridge.h:144 > > > #146: FILE: drivers/staging/vme_user/vme_bridge.h:146 > > > #148: FILE: drivers/staging/vme_user/vme_bridge.h:148 > > > #152: FILE: drivers/staging/vme_user/vme_bridge.h:152 > > > #163: FILE: drivers/staging/vme_user/vme_bridge.h:163 > > > #173: FILE: drivers/staging/vme_user/vme_bridge.h:173 > > > #175: FILE: drivers/staging/vme_user/vme_bridge.h:175 > > > > We don't need all of these lines. > > Hi Greg, I hope you're good and these messages find you well. > > ACK. I thought it would be good to explain what I changed. > > > > > > Signed-off-by: Alexon Oliveira > > > > Please don't indent your signed-off-by line, that should be to the left. > > > > ACK. I didn't indent. This was the output of "git format-patch" I copied and pasted. Next time I'll remove the indentation manually. > > > > > > > diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h > > > index 11df0a5e7f7b..a0d7a8db239d 100644 > > > --- a/drivers/staging/vme_user/vme_bridge.h > > > +++ b/drivers/staging/vme_user/vme_bridge.h > > > @@ -128,28 +128,21 @@ struct vme_bridge { > > > struct mutex irq_mtx; > > > > > > /* Slave Functions */ > > > - int (*slave_get)(struct vme_slave_resource *, int *, > > > - unsigned long long *, unsigned long long *, dma_addr_t *, > > > - u32 *, u32 *); > > > - int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, > > > - unsigned long long, dma_addr_t, u32, u32); > > > + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *, > > > + unsigned long long *, dma_addr_t *, u32 *, u32 *); > > > + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32); > > > > Did you run your patch through checkpatch.pl after making this change? > > Yes, I did it. No more checks about "Alignment should match open parenthesis". > > > I think you just added more warnings... > > I only focused to solve the checks related to the message above. Nevertheless, there are still other warnings and checks reported by checkpath.pl non-related to this patch (i.e. not caused by this patch) that need to be fixed, but I intend to help to fix them afterwards in a different patch, so I don't send patches with too many changes at once. You resolved one warning by replacing it with a different one, that's not good :( thanks, greg k-h