Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Jul 2023 18:36:11 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Alexander Usyskin <alexander.usyskin@intel.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        Tomas Winkler <tomas.winkler@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>,
        Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Subject: Re: [PATCH] mtd: fix use-after-free in mtd release
Message-ID: <20230727183611.37d01f51@xps-13>
In-Reply-To: <ZMKUJbl7kFOfgKGg@smile.fi.intel.com>
References: <20230727145758.3880967-1-alexander.usyskin@intel.com>
        <ZMKJRNDoQV8p0DH4@smile.fi.intel.com>
        <20230727172013.7c85c05d@xps-13>
        <ZMKUJbl7kFOfgKGg@smile.fi.intel.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Thu, 27 Jul 2023 18:58:29
+0300:

> On Thu, Jul 27, 2023 at 05:20:13PM +0200, Miquel Raynal wrote:
> > andriy.shevchenko@linux.intel.com wrote on Thu, 27 Jul 2023 18:12:04
> > +0300: =20
> > > On Thu, Jul 27, 2023 at 05:57:58PM +0300, Alexander Usyskin wrote: =20
>=20
> ...
>=20
> > > > Fixes: 19bfa9ebebb5 ("mtd: use refcount to prevent corruption") =20
> > >=20
> > > Closes: ? =20
> >=20
> > Did I miss a recent update on the use of Fixes? =20
>=20
> They are orthogonal to each other. Actually Closes goes closer with
> Reported-by.
>=20
> I believe both of them needs to be added (by I might miss something).
>=20
> > I thought Closes was
> > supposed to point at a bug report while Fixes would point to the faulty
> > commit. =20
>=20
> Correct.
>=20
> > Right now I feel like Fixes is the right tag, =20
>=20
> Nobody objects that (see above).
>=20
> > but if you have a source explaining why we should not longer do it like
> > I am used to, I would appreciate a link. =20
>=20
> Since you know about Closes already, I think there is nothing to add.

Ah sorry I misunderstood your first e-mail. I thought you were
suggesting to replace Fixes by Closes. Sorry for the misunderstanding :)

Thanks,
Miqu=C3=A8l