Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 27 Jul 2023 19:52:56 +0300
From:   Svyatoslav Ryhel <clamor95@gmail.com>
To:     Thierry Reding <thierry.reding@gmail.com>
CC:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node
User-Agent: K-9 Mail for Android
In-Reply-To: <ZMKgW6eYpJVqeZJM@orome>
References: <20230618085046.10081-1-clamor95@gmail.com> <20230618085046.10081-3-clamor95@gmail.com> <ZMKJE1G87-jWeg2_@orome> <5A2447D3-DB49-4788-AA05-182AF0F04ED2@gmail.com> <ZMKgW6eYpJVqeZJM@orome>
Message-ID: <D38329D2-D6EC-4DEA-A47A-B4FAEA6DB399@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


27 =D0=BB=D0=B8=D0=BF=D0=BD=D1=8F 2023 =D1=80=2E 19:50:35 GMT+03:00, Thier=
ry Reding <thierry=2Ereding@gmail=2Ecom> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=
=B0=D0=B2(-=D0=BB=D0=B0):
>On Thu, Jul 27, 2023 at 07:26:28PM +0300, Svyatoslav Ryhel wrote:
>>=20
>>=20
>> 27 =D0=BB=D0=B8=D0=BF=D0=BD=D1=8F 2023 =D1=80=2E 18:11:15 GMT+03:00, Th=
ierry Reding <thierry=2Ereding@gmail=2Ecom> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=
=D0=B0=D0=B2(-=D0=BB=D0=B0):
>> >On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote:
>> >> All ASUS Transformers have micro-HDMI connector directly available=
=2E
>> >> After Tegra HDMI got bridge/connector support, we should use connect=
or
>> >> framework for proper HW description=2E
>> >>=20
>> >> Tested-by: Andreas Westman Dorcsak <hedmoo@yahoo=2Ecom> # ASUS TF T3=
0
>> >> Tested-by: Robert Eckelmann <longnoserob@gmail=2Ecom> # ASUS TF101 T=
20
>> >> Tested-by: Svyatoslav Ryhel <clamor95@gmail=2Ecom> # ASUS TF201 T30
>> >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail=2Ecom>
>> >> ---
>> >>  arch/arm/boot/dts/tegra20-asus-tf101=2Edts      | 22 ++++++++++++++=
++---
>> >>  =2E=2E=2E/dts/tegra30-asus-transformer-common=2Edtsi  | 21 ++++++++=
++++++++--
>> >>  2 files changed, 38 insertions(+), 5 deletions(-)
>> >>=20
>> >> diff --git a/arch/arm/boot/dts/tegra20-asus-tf101=2Edts b/arch/arm/b=
oot/dts/tegra20-asus-tf101=2Edts
>> >> index c2a9c3fb5b33=2E=2E97350f566539 100644
>> >> --- a/arch/arm/boot/dts/tegra20-asus-tf101=2Edts
>> >> +++ b/arch/arm/boot/dts/tegra20-asus-tf101=2Edts
>> >> @@ -82,9 +82,11 @@ hdmi@54280000 {
>> >>  			pll-supply =3D <&hdmi_pll_reg>;
>> >>  			hdmi-supply =3D <&vdd_hdmi_en>;
>> >> =20
>> >> -			nvidia,ddc-i2c-bus =3D <&hdmi_ddc>;
>> >> -			nvidia,hpd-gpio =3D <&gpio TEGRA_GPIO(N, 7)
>> >> -				GPIO_ACTIVE_HIGH>;
>> >> +			port@0 {
>> >> +				hdmi_out: endpoint {
>> >> +					remote-endpoint =3D <&connector_in>;
>> >> +				};
>> >> +			};
>> >
>> >Does this need a bindings change? nvidia,tegra20-hdmi currently doesn'=
t
>> >support OF graphs, so this would probably fail to validate if we merge
>> >it without a corresponding DT bindings update=2E
>>=20
>> drm/tegra patch is backwards compatible and connector node is optional=
=2E
>
>We still need to document the connector node, otherwise the DT
>validation will complain about port@0 being used here, won't it?

Honestly? I have no idea, linux dt yamls are my nightmare and a reason why=
 most of my patches still are hanging in the void of mailing lists=2E

>Thierry