Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp143698rwb; Thu, 27 Jul 2023 10:30:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlE5qVxmOfe6DsAP7H1RB7QYYXlokbaojtwJC/Bl/slnBC+wtDvV/ErXERc3SFd/2u1IyUur X-Received: by 2002:a17:907:3e0b:b0:994:fec:e1b7 with SMTP id hp11-20020a1709073e0b00b009940fece1b7mr4033148ejc.0.1690478999856; Thu, 27 Jul 2023 10:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690478999; cv=none; d=google.com; s=arc-20160816; b=e0FHO/85mSYPDc3G6xaVkH6HMsgGlJ/aQWeDXWVhgnVG91tBBSlsbOL0nsZKflsZ0t Y/H2XDepSFPledcRZTwj1iZ+Xf75kTysaVW4upvFqAZfxTvZlHi12tZZOh2orQ7gurrn yTpCikCrEKPkH/rscwKRgQDWKN6Zfm+JTehK4NX14IGJT0ecJGwUUe1jN9zEdK3hGap6 EY8IYOayrbaICpQDUjPISt3p23yzA0OiOWiDb7Cu0VyYa8R+pVZho9qNVlbwlNvmGj4Y j0QP54GOLc7X1c+yiOdLgZTcr0R/3/3gb7gsSdD3c2LH6ZL6sVMQMa1e4lNKHhW9A1og tf9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from; bh=3j6hmEpfVNtYkK45OBLJizVfK2HFXJbwV/8MzW95YrU=; fh=EkCKNgDK2UCoEJsDMeWX9fc0x9wMohkGvO+FowAf08E=; b=MpcNwXiW1O/DZAE14w7j28HJwJ5x3OSdfziQrvI0ldm6d/JQ4+Ik2qtl0i/f6GG2++ mLGr6ZYj4x58X9ZQJiO9J3swfQRv41XvpwMFY6bpO+UKR12aBIu0qF/feIFdaD2Ufapx fWXxHi2Ql/6aZlICEn6h1gXbOExnC+0RGU9ULhlmhAynL8F/JWy7J3n+Sh3ri7qq5vES Vr9t/SuccaB7AxbV+/9TmQ2/DO8sT1NBMUbH0bUGbkixySgr01NhLmu1CEmJwB71LXm8 F82kYclMjZms2ktDqY5eoz9oTKiEQVfnZk+iFVAA0C2iFEBYh+l/aJquBqiblNIWraq/ FU+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p26-20020a170906839a00b00992e90ca00dsi1325533ejx.16.2023.07.27.10.29.35; Thu, 27 Jul 2023 10:29:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233439AbjG0QiN (ORCPT + 99 others); Thu, 27 Jul 2023 12:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233085AbjG0QiL (ORCPT ); Thu, 27 Jul 2023 12:38:11 -0400 X-Greylist: delayed 552 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 27 Jul 2023 09:38:10 PDT Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 055BA198A; Thu, 27 Jul 2023 09:38:09 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4RBbn36YnGz1sClr; Thu, 27 Jul 2023 18:28:55 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4RBbn3498Bz1qqlc; Thu, 27 Jul 2023 18:28:55 +0200 (CEST) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id L2BxAh51PvpU; Thu, 27 Jul 2023 18:28:54 +0200 (CEST) X-Auth-Info: /OdUztXMee0ZSkATtsTdHv9aXOABzOIhAtGtPnP68TjAEOXj7HyRSJPLBm2Ue4rD Received: from igel.home (aftr-62-216-205-232.dynamic.mnet-online.de [62.216.205.232]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 27 Jul 2023 18:28:54 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 19B4B2C1309; Thu, 27 Jul 2023 18:28:54 +0200 (CEST) From: Andreas Schwab To: David Laight Cc: 'Aleksa Sarai' , Alexey Gladkov , LKML , Arnd Bergmann , "linux-api@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "James.Bottomley@hansenpartnership.com" , "acme@kernel.org" , "alexander.shishkin@linux.intel.com" , "axboe@kernel.dk" , "benh@kernel.crashing.org" , "borntraeger@de.ibm.com" , "bp@alien8.de" , "catalin.marinas@arm.com" , "christian@brauner.io" , "dalias@libc.org" , "davem@davemloft.net" , "deepa.kernel@gmail.com" , "deller@gmx.de" , "dhowells@redhat.com" , "fenghua.yu@intel.com" , "fweimer@redhat.com" , "geert@linux-m68k.org" , "glebfm@altlinux.org" , "gor@linux.ibm.com" , "hare@suse.com" , "hpa@zytor.com" , "ink@jurassic.park.msu.ru" , "jhogan@kernel.org" , "kim.phillips@arm.com" , "ldv@altlinux.org" , "linux-alpha@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-s390@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux@armlinux.org.uk" , "linuxppc-dev@lists.ozlabs.org" , "luto@kernel.org" , "mattst88@gmail.com" , "mingo@redhat.com" , "monstr@monstr.eu" , "mpe@ellerman.id.au" , "namhyung@kernel.org" , "paulus@samba.org" , "peterz@infradead.org" , "ralf@linux-mips.org" , "sparclinux@vger.kernel.org" , "stefan@agner.ch" , "tglx@linutronix.de" , "tony.luck@intel.com" , "tycho@tycho.ws" , "will@kernel.org" , "x86@kernel.org" , "ysato@users.sourceforge.jp" , Palmer Dabbelt Subject: Re: [PATCH v4 2/5] fs: Add fchmodat2() In-Reply-To: (David Laight's message of "Thu, 27 Jul 2023 09:01:06 +0000") References: X-Yow: Darling, my ELBOW is FLYING over FRANKFURT, Germany.. Date: Thu, 27 Jul 2023 18:28:53 +0200 Message-ID: <87ila5jp2y.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 27 2023, David Laight wrote: > From: Aleksa Sarai >> Sent: 25 July 2023 17:36 > ... >> We almost certainly want to support AT_EMPTY_PATH at the same time. >> Otherwise userspace will still need to go through /proc when trying to >> chmod a file handle they have. > > That can't be allowed. IIUC, fchmodat2(fd, "", m, AT_EMPTY_PATH) is equivalent to fchmod(fd, m). With that, new architectures only need to implement the fchmodat2 syscall to cover all chmod variants. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."