Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp148310rwb; Thu, 27 Jul 2023 10:33:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlEaAqTHIJMvt1buzKZJ0wZ/HnrRdI/wN5x3sd3xW2TKt+nShMCugQlt8qz+xWjBskXkkRiw X-Received: by 2002:a05:6a00:22d2:b0:680:98c:c595 with SMTP id f18-20020a056a0022d200b00680098cc595mr8698363pfj.13.1690479230061; Thu, 27 Jul 2023 10:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690479230; cv=none; d=google.com; s=arc-20160816; b=m9dYrNPmhTHOyFXMRtxQvPNBw5vJgbBTh+OFZG+mp+OD1p4tcHYQMMOi+b8y6PDgzK iRPuTxjPRTyiuxo6TH5mNUNZ/N6TNdRYtgfugrdYwj9KXL5W+lOLPVabWi3xNOxwWELJ UbcTa67rQQvs1N+OQRCXbcYuhWzrcF7sGdPSegnAcW3bc5uJGorWiIRv8mhCb5MvYBWA yKeC0ehGytIv2uakFJ41Dy5bodZz9IAGeM1Ev1nYZeJliYUr4ISt3nspHMkmtLTqzZ4N 3rSKnmEyAX9kpk8ufCTBCAtEg6i5UEjD4A7mu6eCZFYyemdqO7zccNYpqv9lqblUqRd6 bL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=s3gsQ/z+5cLrXPpwpVaTZvQsvN9FODKSUkdcyjzCiwU=; fh=22qH3x48SC+61uDVCxmNlyZRuqTaETIsZDRq9eh/RlQ=; b=o3IjzB3BA0vizRtG1dGoIt2DlZMToYriicozfqdajpwkfcX6wcKmQnytASPVJdfLh5 a2RZ3epWxOFOOxg0wGoHM9X0M5NODXlge8chawdsTY6s2GQI2n3HwWFjM7eaTGnkvOFS KmD/NH/T0B/tOmn3Nj7WRLmKjHMdKDSbptYSaqWtMfQkXCyi/ybtD3xNRtitY5+CWfa+ 2cfLy3jpTAk1C/LOlx/ApMtbCElxTUJq8a1vhwxTWeqntrw+BVf3yp9ZUYglPb+zMNb9 9turqOQmZsZ8PSazazkUT0D+r1Q0R86vaA+Q5px3wh/xsas7AvUp7QuMpmvmTG/FCk6z C0Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=WISleUu8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bq13-20020a056a000e0d00b00662ba7f8a5fsi20022pfb.170.2023.07.27.10.33.37; Thu, 27 Jul 2023 10:33:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=WISleUu8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230282AbjG0Qrv (ORCPT + 99 others); Thu, 27 Jul 2023 12:47:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230061AbjG0Qru (ORCPT ); Thu, 27 Jul 2023 12:47:50 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E78F2704; Thu, 27 Jul 2023 09:47:49 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-52164adea19so1487732a12.1; Thu, 27 Jul 2023 09:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690476467; x=1691081267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s3gsQ/z+5cLrXPpwpVaTZvQsvN9FODKSUkdcyjzCiwU=; b=WISleUu8k7GFgZS9rTGQ7cB9ImJwmBpIA7sy3L+MrjSk2mS0YEUYfLqRfd/X2WcTJ3 C1oNku7OG7wHXFGIrU2f4TK7PAk93TAwSwTtOc7LHtd9q0IvswtebEc42W6W/mWiDgiE QvCcJhJeY0UlajqCi3iD98Zhzl9+LoNK6iltG6Qp9EBnUg9TgKTSfgcRfGdm6oGdx/7T xcF+yMFHI+VY3e0HvMTnfgna0zBSE//5s1e5MLoWtw9eUu1SjDJTX90HwD7HLC9esNyJ pWOjcOa+pBc6jINP3kH4i1ArDP0FS3TaW2k4pNVgKXIvbgLyNXPYXbQybJNZLj1j8LfF uTMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690476467; x=1691081267; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s3gsQ/z+5cLrXPpwpVaTZvQsvN9FODKSUkdcyjzCiwU=; b=kNSI2lHs8h+mZ13UGpbvDri5S4fPeTE9cJMYBdDcauW2YdF95KYe8I8sQHq0amLESm 7bry1AI5UZ6vfzZDPHwT6k03VRBZuPxHCHMI3rTP3Z9zMP2/uCYHEjF2uEhc2jPtBcUL xpBjGIqCNXkdaJrzmUBEyRNK3Wqdr4gf3OD5aK9hUQPpVsCCd8AUQx0+XoSOpUViy1U8 8h1b9vBzR3z8Q/NcWmQ7RGxYvUW8HHOrQFrL3Rihee3qc/Zjvq31Oz/cndjK2MxKL3ke Np7febKExWd7z9EqNVrwqM3z9yHe+0pP8VV98Vh6DOljWU12abm/4uO3hyfeM29IFalf B5VA== X-Gm-Message-State: ABy/qLaYSJG1+6//uZQrWsRd+ACCn0UbuG2pOnK8GkDRHUq+I/J5HW35 GR2gewUJjZA5bPcmuf1mQIg= X-Received: by 2002:aa7:d7c3:0:b0:522:2a3c:6eb with SMTP id e3-20020aa7d7c3000000b005222a3c06ebmr1656540eds.39.1690476467343; Thu, 27 Jul 2023 09:47:47 -0700 (PDT) Received: from localhost (p200300e41f1bd600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1b:d600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id l1-20020a056402028100b005224d15d3dfsm832370edv.87.2023.07.27.09.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 09:47:46 -0700 (PDT) From: Thierry Reding To: jonathanh@nvidia.com, Jiapeng Chong Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] soc/tegra: cbb: Remove unnecessary print function dev_err() Date: Thu, 27 Jul 2023 18:47:41 +0200 Message-ID: <169047644218.3097949.1702711496048962025.b4-ty@nvidia.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230506090735.23936-1-jiapeng.chong@linux.alibaba.com> References: <20230506090735.23936-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding On Sat, 06 May 2023 17:07:35 +0800, Jiapeng Chong wrote: > The print function dev_err() is redundant because platform_get_irq() > already prints an error. > > ./drivers/soc/tegra/cbb/tegra-cbb.c:130:3-10: line 130 is redundant because platform_get_irq() already prints an error. > ./drivers/soc/tegra/cbb/tegra-cbb.c:140:2-9: line 140 is redundant because platform_get_irq() already prints an error. > > > [...] Applied, thanks! [1/1] soc/tegra: cbb: Remove unnecessary print function dev_err() commit: 10f975f8b0e8e563bf1e5c2f5e4ebada29fa7edc Best regards, -- Thierry Reding