Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755943AbXJ2MgO (ORCPT ); Mon, 29 Oct 2007 08:36:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752696AbXJ2Mf7 (ORCPT ); Mon, 29 Oct 2007 08:35:59 -0400 Received: from allen.werkleitz.de ([80.190.251.108]:47214 "EHLO allen.werkleitz.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752623AbXJ2Mf6 (ORCPT ); Mon, 29 Oct 2007 08:35:58 -0400 Date: Mon, 29 Oct 2007 13:35:33 +0100 From: Johannes Stezenbach To: Ingo Molnar Cc: Randy Dunlap , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org Message-ID: <20071029123533.GA17331@linuxtv.org> References: <20071026073736.GA24172@elte.hu> <20071027213057.GA15211@linuxtv.org> <20071027163932.e0a0522b.randy.dunlap@oracle.com> <20071029112303.GA18994@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071029112303.GA18994@elte.hu> User-Agent: Mutt/1.5.16 (2007-06-11) X-SA-Exim-Connect-IP: 84.190.153.223 Subject: Re: [build bug, 2.6.24-rc1] CONFIG_VIDEO_DEV=m & CONFIG_VIDEO_SAA7146_VV=y X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on allen.werkleitz.de) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 39 On Mon, Oct 29, 2007, Ingo Molnar wrote: > * Randy Dunlap wrote: > > > > config VIDEO_SAA7146_VV > > > tristate > > > depends on VIDEO_DEV = y || VIDEO_DEV = VIDEO_SAA7146_VV > > > select VIDEOBUF_DMA_SG > > > select VIDEO_SAA7146 > > > > > > (untested) > > > > Nope, won't work. I tried that last night. VIDEO_DEV_SAA7146_VV > > has too many "select"s involved, but select doesn't follow the dependency > > chains. IOW, as written in Documentation/kbuild/kconfig-language.txt: > > > > select is evil.... select will by brute force set a symbol > > equal to 'y' without visiting the dependencies. So abusing > > select you are able to select a symbol FOO even if FOO depends > > on BAR that is not set. > > so ... what should we do? Remove those ~7 select VIDEO_SAA7146_VV lines > and replace them with depends on VIDEO_SAA7146_VV ? Hm, the idea is that the SAA7146 driver is like a library, and the V4L or DVB card drivers select the library functions they need (base driver or common V4L helper functions). The user shouldn't have to worry about those details. But yeah, if it's not possible to do that with kbuild then it's probably best to s/select/depends on/ for VIDEO_SAA7146_VV and provide a meaningful help text for VIDEO_SAA7146_VV. Johannes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/