Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756647AbXJ2M5o (ORCPT ); Mon, 29 Oct 2007 08:57:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752608AbXJ2M5h (ORCPT ); Mon, 29 Oct 2007 08:57:37 -0400 Received: from twin.jikos.cz ([213.151.79.26]:35788 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752431AbXJ2M5g (ORCPT ); Mon, 29 Oct 2007 08:57:36 -0400 Date: Mon, 29 Oct 2007 13:57:25 +0100 (CET) From: Jiri Kosina To: Dmitry Torokhov cc: Dirk Hohndel , Jeff Garzik , linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device In-Reply-To: Message-ID: References: <20071029084917.GA12968@bigserver.hohndel.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 20 On Mon, 29 Oct 2007, Dmitry Torokhov wrote: > Please don't - the fix is completely broken for multi-input devices - > if 2nd device fails to register we bail out of hidinput_connect and > thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we > never call hidinput_disconnect and who knows what will happen after > that. You are of course right, stupid me. I won't commit anything before first morning coffee any more. Thanks a lot. -- Jiri Kosina - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/