Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp284659rwb; Thu, 27 Jul 2023 12:41:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlGIUpmGCjwuLwtxkWBdvoiqIKqegl/rO+5zQ6YPrSascooquAxOdm1c/TLKoXjqbzi45JAP X-Received: by 2002:a05:6a00:a01:b0:66f:fa65:483 with SMTP id p1-20020a056a000a0100b0066ffa650483mr156529pfh.0.1690486908387; Thu, 27 Jul 2023 12:41:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690486908; cv=none; d=google.com; s=arc-20160816; b=z4Slho44OBMByZeXAKD0a41v3gtzul8a6hJnA7MzEPpS15dEguW70Q62tX0RkPO/z/ YKXdh6fTFsA975PwZkplax6gsnz5MBcalHtJcnZA2KFIR6b1fQgcX9tH4Hq9Dk9Ida+K S8/XyixnVTsqn1vqIPhs3rlCf3tLEi0AumWXq1h8M3Eui/W9MQdQOwg4JpXB85qCA1GU unJDEktW/5KFORy4KgdghDjS2Mfkghvs2vyvHHC67JILsfYz1CWFucytNrVC3FvmQZBi VlMS+CeT1j8Q2NLCzedyuvK0nmaB1niqPow0lSER814vp74W7ugoP+xs9usv4had3CQq /p7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Ggn1jB5xtYjezqG+rL8HQ1VUYfWWCXabgGh9TYMMppE=; fh=6Nf8iSUFIororGuJxj4Ix+FVD9R188YnzMLADH8Si84=; b=nfL7Wk8G+c0urFR91Vn6VGd8mZjLJ3NOReiZio5FxHCDC7J/r7TJ8f1Xo0aNOSvugM /vxnHZ4y3QeuILrzm5kLaV1vEHzoRwS9HfmlLZq8ZaSBhQPZUMr878VRdmXxCovCNUHS 3tkm4T90ujpril4+2p52HaahQckg5PlGMK8U61Cy22F83RdyXxBv1owpnr5U822Xtdid YUUULSklAkVl14V708/i6CTyFQSxmJeArjFzBMts2HBQqwB3qiSCBfEPhapgsAsnSEIL WYTCcsWc5MJz93Hp2am/orc5qH5zWRS/zdvw2x2G/mc2Gh/+0tkwfU2iKLIakJ+4vWbs nOAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Mf+VQ3XA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h132-20020a62838a000000b0067bc790ce11si206338pfe.161.2023.07.27.12.41.35; Thu, 27 Jul 2023 12:41:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Mf+VQ3XA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229447AbjG0Snf (ORCPT + 99 others); Thu, 27 Jul 2023 14:43:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjG0Snf (ORCPT ); Thu, 27 Jul 2023 14:43:35 -0400 Received: from mgamail.intel.com (unknown [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5716F2D5D; Thu, 27 Jul 2023 11:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690483413; x=1722019413; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=L5z8yin9ZxPjzkBPLKHCZpn/sE75lTZ1e/7BXlD4ZOQ=; b=Mf+VQ3XAJc/iLO67f2K9XkOKaQD2SxFOG2HELrfz3LkOoHJjU6srbyDc OPyWuGI1+l5MT3sNFImp5BOm8p3NCaUi/wPUCP+227JZSeRTO4baa/EN5 4YugVKMc00CocxL8KZXLVF3rGOmhkFOIe6PBcBvZLHt3djFxtHBIUf22K o1ScHiw4m3OIwioylg7XoT/l5qvEqrcdE0MFowe/U69Eg6ITmWt3UkeCV 3+/8krn3+jbddtI9D+0nHu8TgpkJHtcXOclHDavdYFHGgTUvhQv6ekPOQ xOoFMxn5PuECITeL2cJo2ektQBhuIPP23F/o6Q9oF0hUHaIYu0ShxHGmn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="348011715" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="348011715" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jul 2023 11:43:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="817211608" X-IronPort-AV: E=Sophos;i="6.01,235,1684825200"; d="scan'208";a="817211608" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2023 11:43:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qP5xR-00Gb8Y-34; Thu, 27 Jul 2023 21:43:29 +0300 Date: Thu, 27 Jul 2023 21:43:29 +0300 From: Andy Shevchenko To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiri Kosina , Benjamin Tissoires Subject: Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings Message-ID: References: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230703185222.50554-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 03, 2023 at 09:52:10PM +0300, Andy Shevchenko wrote: > After I updated GPIO library for the case Benjamin has with CP2112, > I have a brief look into the CP2112 driver itself. > > From GPIO perspective it has two main (maitenance) issues: > - usage of ->to_irq() with IRQ chip present; > - having IRQ chip not immutable. > > Besides that there are plenty small cleanups here and there. > Hence this series. Any comments on this? -- With Best Regards, Andy Shevchenko