Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c4410ce3-e38d-a935-0e5f-6773cdbfe11b@intel.com>
Date:   Thu, 27 Jul 2023 13:06:56 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
To:     Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>
CC:     Jiri Kosina <jikos@kernel.org>, <x86@kernel.org>
References: <20230726234910.14775-1-rdunlap@infradead.org>
Content-Language: en-US
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20230726234910.14775-1-rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckxUQTJBSlpwVmRqNVFzU1BsMDUrbmlraDA0MGN3aGhXUWVOQXMxdjQzdElt?=
 =?utf-8?B?NHBLb3lNRFMxZHZ5ZjRZbTcvTExvWWR4Um5yR2FyK1pldGVoTGIxVUNIa3FG?=
 =?utf-8?B?WkY1RWQ2bWVvTy8vLzd3NGNiVERqMnVFYkFOVFJpTjVWQ0hnN3ZzbHBmYWtH?=
 =?utf-8?B?ODJsSk1zOUpXa2JBdnJicXozYlMwNzlBN2VvNHBzdnp3TGF4bGcyVXdISU9k?=
 =?utf-8?B?M0tRSHV1Wk5lcVZmM09vZjc4bVhMV3ZFQVNSWVJXTFB5ekhvWmd5WVcxRXB4?=
 =?utf-8?B?UUcvTG1UWGpFVGhyclRDSW5Sd1VJVUFuRHRnR005NDl1L0JWZTNKdjBuRzJ5?=
 =?utf-8?B?a3RkTmlpaFB2YXk5dHZJMXptNkJyODJZM2dGdHU1RC9YdnlBWFV0WUx1MmN2?=
 =?utf-8?B?bGZsSEd3ZVhqaXdPTVdEZlZzMVl5Ti9OMUdOVU1TMUI2dlA4ckdFaEN6YzNp?=
 =?utf-8?B?ZnZjYjBSS2Q2M2lFNDBpVGVBWVpKekVtZVRBbktPMXRybDE4b1g3U2JSWGsv?=
 =?utf-8?B?OFQ2Tk1Qd05QMkNPa25VWTZGSUVDbjJuK2RqT2pyMkFORUgwNjJMTDF1ZEF6?=
 =?utf-8?B?K0lZRDVHL1VaTUIzN2JzRGVWYklKQXlsdkJRd3g2VXY1MVpaZ09sdW5BdDBv?=
 =?utf-8?B?VmtYaStKUm5XblBjT3hzREdGWjBXbDE5OXB5K0E2a2tkdXhsNFB2bE80MFRh?=
 =?utf-8?B?RGs4bURpMUN3ZE5mNmtIdzFaRUFiNWJIRWtzVytZMUJuSHpwRGxqMU1jT0dW?=
 =?utf-8?B?QWhieEN2V3paWHJFREtJV3drY1BxT0FpdjJhT1c2L1llT2J0SG00dmQ0bTY1?=
 =?utf-8?B?dDBkMS9Qb1ZsSzFlODFPYmJKTnU2aVVzQTJLaHIwdDhPNUZNSEx1RnFjSGlB?=
 =?utf-8?B?SmF1ekMzU2xvR1k0RDl1OGJLTWVqb1FOVGxFZ1lRQmE1MmZNQW1oSWUrWTlD?=
 =?utf-8?B?SDZxcDBGU0lyT05qMzMxb29XYlRIYkpBengreXJXM0h1b2hmeTFHdXU5VzdY?=
 =?utf-8?B?eDJUSXU4OEo0dFFCdE0xV3g1b2xXOTF4ZTRxZFJTZS9HQzBzUW0vN2w2eW1Z?=
 =?utf-8?B?UXpjZXUwTjJFdXozVmNzSWtVbTJubmx2MGhORURFSGVuNklxQ1NuTkJkK25y?=
 =?utf-8?B?clhDRlZDenVLai9zRGFycmhVRndYMU4vMmpYRVJKOENzYWJSRDlPRllCdHJ0?=
 =?utf-8?B?U3F0bk5NZStFMHhvWnkwRVlVOUIySVdDTmZZcDc0NTJrNDlJTzBYTHA3OUc2?=
 =?utf-8?B?ejRjQWI1UjNSMjlEbXBjQ2NTQmUzRUdBdEFhUEx2bC9uamxQS2JpdjQyZFZm?=
 =?utf-8?B?cjNyZ3NTang2RWRQUUYzTGtodEhuc3ZrWkZjR3lJS1daeEZwMHQ0Nk5TN0xy?=
 =?utf-8?B?cWdNNjVUcW9jbWRoeXFWRDk5SE5lT24vb3RZdjloRXlncXBqUlNYSTVFcHBu?=
 =?utf-8?B?SURpYUJxVlpwcjVlZlFmWGg5aTFaUmZkdk1UUEViekFPbG8wSzB2YkUzYysx?=
 =?utf-8?B?RHl4Y0svY09NZWwvVlI4Vnp6RDc5cG04RnRibU83Q0pQMVJxNXU2cmZEb3ox?=
 =?utf-8?B?d3NPOUdQOUkxM2QxNGhEK21zU0Urc1lSZTRQQ2Y4bGNBd28xcUJCV3lzOXB5?=
 =?utf-8?B?TVZuc0NibzRKUTUzREMrb3AwOGtkcG9uVit4R01WZ0Z4Q3llRkcyMkpnQUFF?=
 =?utf-8?B?QWZadG5WVjN6VnJhWFUxb1VJQ1ROa3hocmpsYUMxQXVzL1dEd0N4ZS9JRHZl?=
 =?utf-8?B?NXhUTnhQdnE3anl3cnliUEhpcCtEcHAwZ1Z2eEZOVkFBQUVVKzVwWG9vbDJn?=
 =?utf-8?B?Um9Pc0dhRXJaWUdCdUlQdldtYlY3UzZBSVVySE11cVF1L2FkWGgvOURKai9o?=
 =?utf-8?B?bytqUnpsSkl0Mk90c2gxaGNUc2hsRmQyRkt2S1doTWN5QnJhMmV6dExYcGNE?=
 =?utf-8?B?ZFlrOVBxaGszR20xMjFYcG56QnhJeWIwUWRZQlVEdDNXSXZZS1kvRkRIVnVT?=
 =?utf-8?B?YkxETnd6ak9OelBTek56VUZ4TEdKWTBPUE5xM09EWldaZEV6alhjbjNLSTJn?=
 =?utf-8?B?UWpYcHhYTXV1QWt5dFhzdHJFM2F6Z3EvOTNTU0grTHdYZzBIL1dkMkRkVDBC?=
 =?utf-8?Q?KdOZxXD9RGlz3jP+Na0mjtAub?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 58953e12-0f90-4b67-fae0-08db8edd08a8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 20:06:58.8712
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TwK+nlmFZYGBWw8vxY8k9ealOpsjsaEPptNR6Ypwl7ID7wb1Rg26y8Gq7lbLHVIuY+nKKrNbSiuJxKEw6y/F6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR11MB5999
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

s/drop/Drop

On 7/26/2023 4:49 PM, Randy Dunlap wrote:
> This source file already includes <linux/miscdevice.h>, which contains
> the same macro. It doesn't need to be defined here again.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: x86@kernel.org
> ---

I am not sure if a Fixes tag is really needed for a redundant macro
definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
move APM_MINOR_DEV to include/linux/miscdevice.h") ?

Either way,
Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>