Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <772ac95d-9eab-2090-245e-fcc40bd7a5da@infradead.org>
Date:   Thu, 27 Jul 2023 14:21:46 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>, linux-kernel@vger.kernel.org
Cc:     Jiri Kosina <jikos@kernel.org>, x86@kernel.org
References: <20230726234910.14775-1-rdunlap@infradead.org>
 <c4410ce3-e38d-a935-0e5f-6773cdbfe11b@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <c4410ce3-e38d-a935-0e5f-6773cdbfe11b@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Sohil,

On 7/27/23 13:06, Sohil Mehta wrote:
> s/drop/Drop
> 
> On 7/26/2023 4:49 PM, Randy Dunlap wrote:
>> This source file already includes <linux/miscdevice.h>, which contains
>> the same macro. It doesn't need to be defined here again.
>>
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jiri Kosina <jikos@kernel.org>
>> Cc: x86@kernel.org
>> ---
> 
> I am not sure if a Fixes tag is really needed for a redundant macro
> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
> move APM_MINOR_DEV to include/linux/miscdevice.h") ?

I don't see any need for this patch to be backported.

Should it be commit 874bcd00f520c?  Maybe. That one certainly
missed moving this macro.

> Either way,
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

Thanks.

-- 
~Randy