Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230623123820.42850-1-arkadiusz.kubalewski@intel.com> <20230623123820.42850-8-arkadiusz.kubalewski@intel.com>
In-Reply-To: <20230623123820.42850-8-arkadiusz.kubalewski@intel.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 27 Jul 2023 23:16:42 +0200
Message-ID: <CACRpkdar39x8nd5cWEDiFDHwLqHghUQZqkR0rEcv2-sZOZZ0KQ@mail.gmail.com>
Subject: Re: [RFC PATCH v9 07/10] ice: add admin commands to access cgu configuration
To:     Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc:     kuba@kernel.org, jiri@resnulli.us, vadfed@meta.com,
        jonathan.lemon@gmail.com, pabeni@redhat.com, corbet@lwn.net,
        davem@davemloft.net, edumazet@google.com, vadfed@fb.com,
        jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
        saeedm@nvidia.com, leon@kernel.org, richardcochran@gmail.com,
        sj@kernel.org, javierm@redhat.com, ricardo.canuelo@collabora.com,
        mst@redhat.com, tzimmermann@suse.de, michal.michalik@intel.com,
        gregkh@linuxfoundation.org, jacek.lawrynowicz@linux.intel.com,
        airlied@redhat.com, ogabbay@kernel.org, arnd@arndb.de,
        nipun.gupta@amd.com, axboe@kernel.dk, linux@zary.sk,
        masahiroy@kernel.org, benjamin.tissoires@redhat.com,
        geert+renesas@glider.be, milena.olech@intel.com, kuniyu@amazon.com,
        liuhangbin@gmail.com, hkallweit1@gmail.com, andy.ren@getcruise.com,
        razor@blackwall.org, idosch@nvidia.com, lucien.xin@gmail.com,
        nicolas.dichtel@6wind.com, phil@nwl.cc, claudiajkang@gmail.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
        linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        poros@redhat.com, mschmidt@redhat.com, linux-clk@vger.kernel.org,
        vadim.fedorenko@linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Arkadiusz,

On Fri, Jun 23, 2023 at 2:45=E2=80=AFPM Arkadiusz Kubalewski
<arkadiusz.kubalewski@intel.com> wrote:

> +/**
> + * convert_s48_to_s64 - convert 48 bit value to 64 bit value
> + * @signed_48: signed 64 bit variable storing signed 48 bit value
> + *
> + * Convert signed 48 bit value to its 64 bit representation.
> + *
> + * Return: signed 64 bit representation of signed 48 bit value.
> + */
> +static s64 convert_s48_to_s64(s64 signed_48)
> +{
> +       return signed_48 & BIT_ULL(47) ?
> +               GENMASK_ULL(63, 48) | signed_48 : signed_48;
> +}

Can't you just use sign_extend64() from <linux/bitops.h>
passing bit 48 as sign bit istead of inventing this?

Yours,
Linus Walleij